Skip to content

remove a sleep timer that is only useful for async requests #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cehbrecht merged 1 commit into from
Mar 11, 2019
Merged

remove a sleep timer that is only useful for async requests #457

cehbrecht merged 1 commit into from
Mar 11, 2019

Conversation

@davidcaron
Copy link
Contributor

@davidcaron davidcaron commented Mar 8, 2019

But annoying for sync requests and tests. The purpose of this timer is to
cover a case when a request finishes more or less at the same
time another is stored. The stored request is not started until another
request ends.

Introduced in #455 that was recently merged.

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@davidcaron
remove a sleep timer that is useful for async requests, but ...
ce6e8fe 
annoying for sync requests and tests. The purpose of this timer is to
cover a case when a request finishes more or less at the same
time another is stored. The stored request is not started until another
request ends.
@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage decreased (-0.0006%) to 74.567% when pulling ce6e8fe on davidcaron:remove-sleep-timer into 034b185 on geopython:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage decreased (-0.0006%) to 74.567% when pulling ce6e8fe on davidcaron:remove-sleep-timer into 034b185 on geopython:master.

cehbrecht
cehbrecht approved these changes Mar 11, 2019
View reviewed changes
Copy link
Collaborator

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine.

@cehbrecht
Copy link
Collaborator

cehbrecht commented Mar 11, 2019

@davidcaron Haven't noticed this issue. I will merge.

@cehbrecht cehbrecht added this to the 4.4.0 milestone Mar 11, 2019
@cehbrecht cehbrecht added the bug label Mar 11, 2019
@cehbrecht cehbrecht merged commit 702a21f into geopython:master Mar 11, 2019
@davidcaron davidcaron deleted the remove-sleep-timer branch May 9, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cehbrecht cehbrecht cehbrecht approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@davidcaron @coveralls @cehbrecht