Do not call Session.close_all

[elemoine]

Overview

Do not call Session.close_all as this will close all the Sessions that exist in memory, including the sessions that are specific to the application and unrelated to PyPWS.

And here the closing of sessions is already handled by _LAST_SESSION.close(), so we can just remove the call to _SESSION_MAKER.close_all.

Related Issue / Discussion

None

Additional Information

None. The overview covers it all.

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

• I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
• I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

[coveralls]

Coverage decreased (-0.009%) to 74.881% when pulling 25161b3 on elemoine:ele_close-all into ec1d90f on geopython:master.

[coveralls]

Coverage decreased (-0.009%) to 74.881% when pulling 25161b3 on elemoine:ele_close-all into ec1d90f on geopython:master.

[cehbrecht]

Sounds persuasive.

[elemoine]

In other words a library should never call Session.close_all, as this may close sessions belonging to the application, or to other libraries used by the application.

[cehbrecht]

@elemoine done. Thanks :)

[elemoine]

Thanks to you!