Skip to content

Adding type to layer dialog hooks #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 13, 2025
Merged

Adding type to layer dialog hooks #937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df05094
Adding type to hooks
nakul-py Sep 23, 2025
7101462
Adding new ClassificationMode type
nakul-py Sep 24, 2025
0f37850
Refactor classification mode handling to use ClassificationMode type …
nakul-py Sep 24, 2025
da56e22
Add validation for number of shades in ColorRamp and update usage in …
nakul-py Sep 24, 2025
d4d9064
Refactor ColorRamp and mode components to improve type handling.
nakul-py Oct 1, 2025
0d69ede
making selectedMode or numberofShades required
nakul-py Oct 22, 2025
bd83973
Resolve merge conflicts in ColorRamp.tsx
nakul-py Nov 5, 2025
dd2fd55
lint fix 🔔
nakul-py Nov 5, 2025
c4d3a23
Resolving conflicts again
nakul-py Nov 10, 2025
707720a
Removing duplicate export for
nakul-py Nov 10, 2025
5824fc2
by mistake forget this file to commit
nakul-py Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/base/src/dialogs/symbology/components/color_ramp/ColorRamp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ export type ColorRampOptions = {
selectedMode: ClassificationMode | undefined;
};

const isValidNumberOfShades = (value: number | undefined) => {
return value !== undefined && !isNaN(value) && value > 0;
};

const ColorRamp: React.FC<IColorRampProps> = ({
layerParams,
modeOptions,
Expand Down Expand Up @@ -84,6 +88,7 @@ const ColorRamp: React.FC<IColorRampProps> = ({
) : (
<Button
className="jp-Dialog-button jp-mod-accept jp-mod-styled"
disabled={!isValidNumberOfShades(numberOfShades)}
onClick={() =>
classifyFunc(
selectedMode,
Expand Down
7 changes: 2 additions & 5 deletions packages/base/src/dialogs/symbology/tiff_layer/types/SingleBandPseudoColor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,8 @@ const SingleBandPseudoColor: React.FC<ISymbologyDialogProps> = ({
const currentBand = bandRows[selectedBand - 1];
const source = model.getSource(layer?.parameters?.source);
const sourceInfo = source?.parameters?.urls[0];
if (!numberOfShades) {
console.warn('No number of shades provided');
return;
}
const nClasses = selectedMode === 'continuous' ? 52 : +numberOfShades;
const nClasses =
selectedMode === 'continuous' ? 52 : (numberOfShades as number);

setIsLoading(true);
switch (selectedMode) {
Expand Down
17 changes: 6 additions & 11 deletions packages/base/src/dialogs/symbology/vector_layer/types/Graduated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,40 +230,35 @@ const Graduated: React.FC<ISymbologyTabbedDialogWithAttributesProps> = ({

const values = Array.from(selectableAttributesAndValues[selectedAttribute]);

if (!numberOfShades) {
console.warn('No number of shades provided');
return;
}

switch (selectedMode) {
case 'quantile':
stops = VectorClassifications.calculateQuantileBreaks(
values,
+numberOfShades,
numberOfShades as number,
);
break;
case 'equal interval':
stops = VectorClassifications.calculateEqualIntervalBreaks(
values,
+numberOfShades,
numberOfShades as number,
);
break;
case 'jenks':
stops = VectorClassifications.calculateJenksBreaks(
values,
+numberOfShades,
numberOfShades as number,
);
break;
case 'pretty':
stops = VectorClassifications.calculatePrettyBreaks(
values,
+numberOfShades,
numberOfShades as number,
);
break;
case 'logarithmic':
stops = VectorClassifications.calculateLogarithmicBreaks(
values,
+numberOfShades,
numberOfShades as number,
);
break;
default:
Expand All @@ -277,7 +272,7 @@ const Graduated: React.FC<ISymbologyTabbedDialogWithAttributesProps> = ({
: Utils.getValueColorPairs(
stops,
selectedRamp,
+numberOfShades,
numberOfShades as number,
reverseRamp,
);

Expand Down
Loading