Fgb async iterator #974
Fgb async iterator #974
Conversation
|
I changed the base to #966 in the hope that it would make this easier to review... not sure I succeeded 😅 |
|
Ok switched it back to main 😅 |
|
@H-Plus-Time I've been swamped and on vacation; I have a couple days back working before taking Friday and Monday off ⛷️ I really appreciate this PR and hope to get to a review very soon! |
|
Oh, no rush at all (personally I'd be duct-taping my laptop shut if it were ski season here). There's a bunch of failing CI, I'll have a bit of a poke around there (I'm guessing it's just combinations of features / slightly outdated imports). |
|
Mm, ok, I suppose we just restore the read_flatgeobuf_async function (as a simple wrapper around the stream builder struct) and that should silence most of the above. Interestingly though, I see you've started messing with async iterators over at https://github.com/kylebarron/arro3/pull/258/files. That would be really nice, and I'm guessing that's something you'd want to do in arro3/pyo3_arrow (though I do wonder how it'd work with the dynamically linked bits)? |
No description provided.