Add tests for merge_driver_ekeyword #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has been dead since commit c819d14 in 2009. Signed-off-by: Matt Turner <[email protected]>
Fixes: a667d93 ("bin/merge-driver-ekeyword: Look for KEYWORDS changes in upstream commit") Signed-off-by: Matt Turner <[email protected]>
Makes unit testing easier. Signed-off-by: Matt Turner <[email protected]>
Signed-off-by: Matt Turner <[email protected]>
To facilitate unit testing. Signed-off-by: Matt Turner <[email protected]>
Signed-off-by: Matt Turner <[email protected]>
mattst88
force-pushed
the
merge-driver-ekeyword-tests
branch
from
a255686 to
c649f33
Compare
And provide a Makefile to generate the test data from gentoo.git. Signed-off-by: Matt Turner <[email protected]>
Signed-off-by: Matt Turner <[email protected]>
mattst88
force-pushed
the
merge-driver-ekeyword-tests
branch
from
c649f33 to
59a4f91
Compare
|
I feel pretty good about the test coverage now. The only wart is that the |
|
cc: @mgorny, @thesamesam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial commits are ready. The commits adding the unit tests are not. I'm still trying to figure out the right way of organizing them. Suggestions welcome.
cc: @thesamesam