Skip to content

refactor(agent-streaming): Convert server to TS#116

Open
agduan wants to merge 1 commit into
agent-streaming/1-vite-migrationfrom
agent-streaming/2-ts-server
Open

refactor(agent-streaming): Convert server to TS#116
agduan wants to merge 1 commit into
agent-streaming/1-vite-migrationfrom
agent-streaming/2-ts-server

Conversation

@agduan

@agduan agduan commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
  • chore: Add TS compiler, executor, typings
  • chore: Add tsconfig.json
  • refactor: Convert backend to TypeScript
  • chore: Update npm scripts

@agduan agduan requested a review from nohe427 June 12, 2026 03:52

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the server-side code of the agent-streaming application from JavaScript to TypeScript, introducing a Genkit AI streaming flow with Gemini 3.5 Flash and updating the project configuration and dependencies. The review feedback highlights several key improvements: safely handling pre-stream errors in the SSE endpoint by checking res.headersSent, optimizing the regex logic for extracting the last thought step to avoid performance issues, validating the parsed PORT to prevent NaN errors, removing browser-specific DOM libraries from tsconfig.json, and deleting the obsolete src/server/index.js file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread agent-streaming/src/server/index.ts
Comment thread agent-streaming/src/server/index.ts Outdated
Comment thread agent-streaming/src/server/index.ts Outdated
Comment thread agent-streaming/tsconfig.json
Comment thread agent-streaming/src/server/index.js Outdated
@agduan agduan force-pushed the agent-streaming/2-ts-server branch 4 times, most recently from dae6383 to 835c31f Compare June 15, 2026 04:47
- chore: Add TS compiler, executor, typings
- chore: Add tsconfig.json
- refactor: Convert backend to TypeScript
- chore: Update npm scripts
@agduan agduan force-pushed the agent-streaming/2-ts-server branch from 835c31f to 4e5665c Compare June 15, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants