refactor(go/plugins): extract modality string constants#5488
refactor(go/plugins): extract modality string constants#5488IzaakGough wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for text-to-speech (TTS) models in the Google Gen AI plugin. It defines modality constants, adds a TTSSupports capability definition, registers three new Gemini TTS preview models, and adds corresponding unit tests to verify model classification, options, and registration. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
adesinah
left a comment
There was a problem hiding this comment.
The changes look good. This PR needs to convert this chore for other Go plugins too.
Summary
Refactor the Go
googlegenaiplugin to replace repeated modality string literals with shared constants, and update the related TTS assertion to use the same constant.Problem/Root Cause
models.gorepeated raw modality strings such as"media","text","image", and"video"across model and embedder capability definitions. Keeping these values duplicated makes the registry harder to maintain and increases the risk of inconsistent updates when a modality value is reused in multiple places.Solution/Changes
Testing