Skip to content

style(copy): question bank copy pass#28

Merged
Bissbert merged 1 commit into
mainfrom
style/copy-pass-questions
May 12, 2026
Merged

style(copy): question bank copy pass#28
Bissbert merged 1 commit into
mainfrom
style/copy-pass-questions

Conversation

@Bissbert

Copy link
Copy Markdown
Contributor

Summary

  • Audited all 50 YAML files in src/content/questions/**/*.yaml for em-dashes, AmE spellings, AI-cadence patterns, and login/account mentions
  • Removed 3 em-dashes from _example/example-mcq.yaml (comment header, rationaleCorrect parenthetical, metadata comment); replaced with colons and semicolons per the project style rule established in PR style(lang): British English compliance and AI-tell removal across UI strings #20
  • One em-dash remains in that file at line 140: it is part of an official GIA publication title in a citation string and has not been altered

What changed

Category Count Files
Em-dashes removed 3 _example/example-mcq.yaml
AmE spellings fixed 0 — all 50 files already use BrE
AI-cadence patterns fixed 0 — none found
Login/account mentions 0 — none found
Files modified 1 _example/example-mcq.yaml

Before / After examples

Line 2 (comment header)
Before: # EXAMPLE QUESTION — for curator reference and scaffolder template only.
After: # EXAMPLE QUESTION: for curator reference and scaffolder template only.

Lines 82-83 (rationaleCorrect parenthetical)
Before: fluorescence alone is never diagnostic — some Burma spinel also / fluoresces red — so it confirms but does not establish the identification.
After: fluorescence alone is never diagnostic; some Burma spinel also / fluoresces red, so it confirms but does not establish the identification.

Line 111 (metadata comment)
Before: # High-value metadata — populate whenever there is a known confusion pair.
After: # High-value metadata: populate whenever there is a known confusion pair.

Learn content findings (forward to upstream gemmology-knowledge)

AmE spellings found in src/content/learn/ — these are synced from a separate repo and must be patched upstream. Top hits:

  1. fundamentals/crystal-systems.yaml:34Center of Symmetry (BrE: Centre)
  2. fundamentals/colour-theory.yaml:23Physics and Chemistry of Color (publication title — leave)
  3. fundamentals/colour-theory.yaml:381Physics and Chemistry of Color (publication title — leave)
  4. fundamentals/colour-theory.yaml:391color in beryl (in journal article title — leave)
  5. fundamentals/physical-properties.yaml:515Physics and Chemistry of Color (publication title — leave)
  6. equipment/chelsea-colour-filter.yaml:146Chemistry of Color (publication title — leave)
  7. origin/tajikistan.yaml:141Color Mechanism in citation (journal article title — leave)
  8. origin/pakistan/topaz.yaml:48"the color is due (quoted source text — leave as quoted)
  9. origin/pakistan/emerald.yaml:60"small stones with saturated color" (quoted source — leave)
  10. origin/brazil/tourmaline.yaml:92Pink center, green rim (BrE: centre)
  11. origin/russia/demantoid.yaml:137aluminum content (BrE: aluminium)
  12. origin/ethiopia.yaml:44Play-of-Color Opal (journal article title — leave)
  13. origin/ethiopia.yaml:179Play-of-Color Opal (journal article title — leave)
  14. market/professional-practice.yaml:168FTC Guides for Jewelry Industry (proper name — leave)
  15. phenomena/fire-dispersion.yaml:150Chemistry of Color in citation (publication title — leave)
  16. phenomena/tenebrescence.yaml:40the color-active sulfur species (BrE: colour-active)
  17. phenomena/schiller.yaml:133ideal behavior of thicknesses (BrE: behaviour)

Actionable upstream fixes (non-title, non-quoted body copy): items 1, 10, 11, 16, 17 — five instances across four files.

Test plan

  • npm run validate:questions — 50/50 pass
  • npm run build — 912 pages built, 0 errors

Remove three em-dashes from _example/example-mcq.yaml (comment header,
rationaleCorrect parenthetical, and metadata comment). All 49 live question
files were audited and required no changes: spelling is already BrE, no
AI-cadence patterns, and no login/account copy found.
@github-actions

Copy link
Copy Markdown

🚀 Preview deployed to: https://8eaa877b.gemmology-dev.pages.dev

@Bissbert Bissbert merged commit 80d3ec5 into main May 12, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant