style(copy): question bank copy pass#28
Merged
Merged
Conversation
Remove three em-dashes from _example/example-mcq.yaml (comment header, rationaleCorrect parenthetical, and metadata comment). All 49 live question files were audited and required no changes: spelling is already BrE, no AI-cadence patterns, and no login/account copy found.
|
🚀 Preview deployed to: https://8eaa877b.gemmology-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/content/questions/**/*.yamlfor em-dashes, AmE spellings, AI-cadence patterns, and login/account mentions_example/example-mcq.yaml(comment header, rationaleCorrect parenthetical, metadata comment); replaced with colons and semicolons per the project style rule established in PR style(lang): British English compliance and AI-tell removal across UI strings #20What changed
_example/example-mcq.yaml_example/example-mcq.yamlBefore / After examples
Line 2 (comment header)
Before:
# EXAMPLE QUESTION — for curator reference and scaffolder template only.After:
# EXAMPLE QUESTION: for curator reference and scaffolder template only.Lines 82-83 (rationaleCorrect parenthetical)
Before:
fluorescence alone is never diagnostic — some Burma spinel also / fluoresces red — so it confirms but does not establish the identification.After:
fluorescence alone is never diagnostic; some Burma spinel also / fluoresces red, so it confirms but does not establish the identification.Line 111 (metadata comment)
Before:
# High-value metadata — populate whenever there is a known confusion pair.After:
# High-value metadata: populate whenever there is a known confusion pair.Learn content findings (forward to upstream gemmology-knowledge)
AmE spellings found in
src/content/learn/— these are synced from a separate repo and must be patched upstream. Top hits:fundamentals/crystal-systems.yaml:34—Center of Symmetry(BrE: Centre)fundamentals/colour-theory.yaml:23—Physics and Chemistry of Color(publication title — leave)fundamentals/colour-theory.yaml:381—Physics and Chemistry of Color(publication title — leave)fundamentals/colour-theory.yaml:391—color in beryl(in journal article title — leave)fundamentals/physical-properties.yaml:515—Physics and Chemistry of Color(publication title — leave)equipment/chelsea-colour-filter.yaml:146—Chemistry of Color(publication title — leave)origin/tajikistan.yaml:141—Color Mechanismin citation (journal article title — leave)origin/pakistan/topaz.yaml:48—"the color is due(quoted source text — leave as quoted)origin/pakistan/emerald.yaml:60—"small stones with saturated color"(quoted source — leave)origin/brazil/tourmaline.yaml:92—Pink center, green rim(BrE: centre)origin/russia/demantoid.yaml:137—aluminum content(BrE: aluminium)origin/ethiopia.yaml:44—Play-of-Color Opal(journal article title — leave)origin/ethiopia.yaml:179—Play-of-Color Opal(journal article title — leave)market/professional-practice.yaml:168—FTC Guides for Jewelry Industry(proper name — leave)phenomena/fire-dispersion.yaml:150—Chemistry of Colorin citation (publication title — leave)phenomena/tenebrescence.yaml:40—the color-active sulfur species(BrE: colour-active)phenomena/schiller.yaml:133—ideal behavior of thicknesses(BrE: behaviour)Actionable upstream fixes (non-title, non-quoted body copy): items 1, 10, 11, 16, 17 — five instances across four files.
Test plan
npm run validate:questions— 50/50 passnpm run build— 912 pages built, 0 errors