feat: use flat_forms() for CDL v1.3 FormNode compatibility#7
Merged
Conversation
Update geometry pipeline to use desc.flat_forms() instead of desc.forms for compatibility with CDL v1.3 FormGroup tree structure. Add 36 regression tests validating grouped vs ungrouped CDL produces identical geometry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desc.forms->desc.flat_forms()FormGrouptree structureFiles changed
src/crystal_geometry/geometry.py- 3 call sites updatedtests/test_geometry.py- 36 new regression testsDependencies
gemmology-cdl-parser >= 1.3.0(PR: gemmology-dev/cdl-parser#)Test plan
pytestpasses all tests (existing + 36 new regression tests)({111} + {100})|striationproduces identical polyhedron to{111}|striation + {100}|striation