Skip to content

Better handling of the service in stopped state#98

Closed
lisuml wants to merge 1 commit intogeerlingguy:masterfrom
lisuml:stopped_service_support
Closed

Better handling of the service in stopped state#98
lisuml wants to merge 1 commit intogeerlingguy:masterfrom
lisuml:stopped_service_support

Conversation

@lisuml
Copy link
Copy Markdown

@lisuml lisuml commented Nov 29, 2023

  • Prevented waiting for Elasticsearch when elasticsearch_service_state is set to stopped.
  • Avoided triggering 'restart elasticsearch' handler under the same condition.

Reasoning:
Encountered a need to configure security features mandatory for Elasticsearch 8.x. Initial attempts to configure pre-installation were unsuccessful, as these settings require Elasticsearch to be installed first. Thus, opted for post-installation configuration. This necessitated the ability to install and configure Elasticsearch without starting the service.

Note:
Security settings required by default in Elasticsearch 8.x ideally should be incorporated into the role itself. Plan to explore adding this support to the existing role when possible.

* Prevented waiting for Elasticsearch when `elasticsearch_service_state` is set
  to `stopped`.
* Avoided triggering 'restart elasticsearch' handler under the same condition.

Reasoning:
Encountered a need to configure security features mandatory for Elasticsearch
8.x. Initial attempts to configure pre-installation were unsuccessful, as these
settings require Elasticsearch to be installed first. Thus, opted for
post-installation configuration. This necessitated the ability to install and
configure Elasticsearch without starting the service.

Note:
Security settings required by default in Elasticsearch 8.x ideally should be
incorporated into the role itself. Plan to explore adding this support to the
existing role when possible.
@pulse-mind
Copy link
Copy Markdown

Hi, would you like to accept and merge this PR please ?

@github-actions
Copy link
Copy Markdown

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions Bot added the stale label Jun 23, 2024
@pulse-mind
Copy link
Copy Markdown

Hi, would you like to accept and merge this PR please ?

@github-actions github-actions Bot removed the stale label Jun 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2024

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions Bot added the stale label Nov 3, 2024
@lisuml
Copy link
Copy Markdown
Author

lisuml commented Nov 4, 2024

Ping? 😢

@github-actions github-actions Bot removed the stale label Nov 10, 2024
@github-actions
Copy link
Copy Markdown

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions Bot added the stale label Mar 16, 2025
@lisuml
Copy link
Copy Markdown
Author

lisuml commented Mar 18, 2025

Bump.

@github-actions github-actions Bot removed the stale label Mar 23, 2025
@github-actions
Copy link
Copy Markdown

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions Bot added the stale label Jul 27, 2025
@lisuml
Copy link
Copy Markdown
Author

lisuml commented Jul 28, 2025

Bump.

@github-actions github-actions Bot removed the stale label Aug 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 7, 2025

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions Bot added the stale label Dec 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 8, 2026

This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

@github-actions github-actions Bot closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants