Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpson Rule #223

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Simpson Rule #223

wants to merge 5 commits into from

Conversation

jigneshoo7
Copy link
Contributor

No description provided.

geekquad
geekquad requested changes Oct 6, 2020
View reviewed changes
Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the file name to "simpson_rule". We have clearly mentioned it in our Contibuting Guidelines.

geekquad
geekquad reviewed Oct 7, 2020
View reviewed changes
Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jaccard Similarity was assigned to someone else.

geekquad
geekquad requested changes Oct 7, 2020
View reviewed changes
Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a CPP code. You are merging it into the Python folder. Please change the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekquad geekquad geekquad requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jigneshoo7 @geekquad