Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fibonacci search, bucket sort and PCA code added (issue #7) #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fibonacci search, bucket sort and PCA code added (issue #7) #13

wants to merge 4 commits into from

Conversation

chaturvediabhay24
Copy link
Contributor

No description provided.

@geekquad
Copy link
Owner

Hello @chaturvediabhay24
Please go through the contributing guidelines. The codes we want must be written in Python and not C++.
Please create an issue if you wish to add code in a language that we don't currently have here.

@chaturvediabhay24
Copy link
Contributor Author

Hey @geekquad i have updated code in python

@chaturvediabhay24
Copy link
Contributor Author

added bucker sort and fibbonacci search

@chaturvediabhay24 chaturvediabhay24 changed the title fibonacci search added (issue #7) fibonacci search and bucket sort added (issue #7) Sep 30, 2020
@chaturvediabhay24 chaturvediabhay24 changed the title fibonacci search and bucket sort added (issue #7) fibonacci search, bucket sort and PCA code added (issue #7) Sep 30, 2020
@chaturvediabhay24
Copy link
Contributor Author

Is there any problem with my code? I have changed my code in python also updated the two other files. If still there are more things needed to improve before merging PR please do let me know.

MAJOR-BEAST
MAJOR-BEAST suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@MAJOR-BEAST MAJOR-BEAST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some issue in the 346th line "execution_count": null
Just go through it once again.

MAJOR-BEAST
MAJOR-BEAST suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@MAJOR-BEAST MAJOR-BEAST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good to go, but when you copy it from somewhere, at least so it a bit smartly. You also copied the line who actually contributed it.

MAJOR-BEAST
MAJOR-BEAST suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@MAJOR-BEAST MAJOR-BEAST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is also good to go, just make the required changes as in who wrote the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MAJOR-BEAST MAJOR-BEAST MAJOR-BEAST requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaturvediabhay24 @geekquad @MAJOR-BEAST