fix(ethexe-cli): use patched version of alloy to fix bug with uploading codes#5154
fix(ethexe-cli): use patched version of alloy to fix bug with uploading codes#5154StackOverflowExcept1on merged 8 commits intomasterfrom
Conversation
Summary of ChangesHello @StackOverflowExcept1on, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the alloy dependency to a patched version from a git repository to fix a bug with uploading codes related to max_fee_per_blob_gas. This also involves updating the MSRV to 1.91 and adjusting several other dependencies in Cargo.lock.
The approach of using a git dependency is a valid temporary solution. However, the way it's implemented can be improved for better maintainability. I've left a comment suggesting how to centralize the patch configuration in the root Cargo.toml, which would make the setup cleaner and easier to manage in the long run. It's also a good practice to add a TODO comment to remind developers to switch back to the crates.io version once the patch is released.
Resolves #5179
Actual fix: gear-tech/alloy@eb448ca
Cons: need to bump MSRV to 1.91 due to alloy update