Skip to content

fix(ethexe-cli): use patched version of alloy to fix bug with uploading codes#5154

Merged
StackOverflowExcept1on merged 8 commits intomasterfrom
av/fix-alloy-bug
Mar 2, 2026
Merged

fix(ethexe-cli): use patched version of alloy to fix bug with uploading codes#5154
StackOverflowExcept1on merged 8 commits intomasterfrom
av/fix-alloy-bug

Conversation

@StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Feb 23, 2026

Resolves #5179
Actual fix: gear-tech/alloy@eb448ca
Cons: need to bump MSRV to 1.91 due to alloy update

@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team C0-bug Something isn't working D8-ethexe ethexe-related PR labels Feb 23, 2026
@semanticdiff-com
Copy link

Review changes with  SemanticDiff

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @StackOverflowExcept1on, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the ethexe-cli that prevented code uploads due to missing wallet properties. It updates the alloy dependency to a patched version, which necessitates raising the MSRV. The changes primarily involve dependency updates in Cargo.lock and Cargo.toml to ensure compatibility with the new alloy version.

Highlights

  • Alloy Update: This PR updates the alloy dependency to version 1.7.3, resolving an issue related to missing max_fee_per_blob_gas properties during code validation requests.
  • MSRV Bump: The Minimum Supported Rust Version (MSRV) is increased to 1.91 due to the alloy update.
  • Dependency Changes: Several dependencies in Cargo.lock and Cargo.toml are updated to align with the new alloy version, including alloy-chains, alloy-primitives, and others.
Changelog
  • Cargo.lock
    • Updated alloy and related dependencies to version 1.7.3 from a git source.
    • Updated alloy-chains to version 0.2.30.
    • Updated alloy-primitives to version 1.5.7.
    • Removed tiny-keccak dependency.
    • Downgraded several windows-sys dependencies.
    • Updated keccak-asm and sha3-asm to version 0.1.5.
    • Downgraded proc-macro-crate to version 1.1.3.
    • Downgraded heck to version 0.4.1.
  • Cargo.toml
    • Bumped rust-version to 1.91.
    • Updated alloy dependency to version 1.7.
    • Added patch for alloy to use the fix-blob-gas-filler branch from the gear-tech repository.
  • utils/gear-workspace-hack/Cargo.toml
    • Updated alloy and related dependencies to use the fix-blob-gas-filler branch from the gear-tech repository.
    • Added keccak dependency.
    • Added socket2 dependency.
    • Downgraded itertools dependency.
Activity
  • The PR author, StackOverflowExcept1on, has addressed a bug related to code uploads in ethexe-cli.
  • The PR updates the alloy dependency to a patched version to fix the bug.
  • The PR also bumps the MSRV to 1.91 due to the alloy update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the alloy dependency to a patched version from a git repository to fix a bug with uploading codes related to max_fee_per_blob_gas. This also involves updating the MSRV to 1.91 and adjusting several other dependencies in Cargo.lock.

The approach of using a git dependency is a valid temporary solution. However, the way it's implemented can be improved for better maintainability. I've left a comment suggesting how to centralize the patch configuration in the root Cargo.toml, which would make the setup cleaner and easier to manage in the long run. It's also a good practice to add a TODO comment to remind developers to switch back to the crates.io version once the patch is released.

@StackOverflowExcept1on StackOverflowExcept1on merged commit 5d72c7b into master Mar 2, 2026
32 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/fix-alloy-bug branch March 2, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview PR is ready to be reviewed by the team C0-bug Something isn't working D8-ethexe ethexe-related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ethexe-cli: bug with upload code

2 participants