Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slides #2

Merged
merged 2 commits into from
Feb 13, 2017
Merged

Fix slides #2

merged 2 commits into from
Feb 13, 2017

Conversation

stevekinney
Copy link

The slides weren't be styled for some reason. So, I fixed it.

@stevekinney stevekinney force-pushed the fix-slides branch 2 times, most recently from 519d7f9 to 62bb55f Compare May 16, 2015 15:16
@erindepew
Copy link

@stevekinney @cfarm was this ever resolved? I'm also having trouble with the reveal submodule not being integrated properly.

@Roenok Roenok merged commit 4a2e209 into gdi-curriculum-review:master Feb 13, 2017
@Roenok
Copy link
Member

Roenok commented Feb 13, 2017

I merged this change in. In general, though, we are trying to move away from submodules because they complicate the repo and tend to spawn error messages.

@erindepew
Copy link

@Roenok completely agree, would we be able to use a non-custom version of reveal for this and just use NPM ?

@Roenok
Copy link
Member

Roenok commented Feb 13, 2017

@erindepew We have a template repo with our custom version of reveal: https://github.com/girldevelopit/gdi-slides-template. We just have people include the reveal.js plugin directly in the repo, so there is no need to use an package manager: just download a zip and open the slides. Many of our students are beginners, so we want there to be as little friction as possible.

When these slides are ready to "graduate" to the main repo, I'll move the contents over the standard template.

@erindepew
Copy link

@Roenok 👌 thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants