New endpoint to allow admins to get all access requests #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quests, with auth and flexibility to return only user relevant accessRequests
…lst working around express middleware
…nticationConnector
JR40159
requested changes
Nov 12, 2025
JR40159
requested changes
Nov 12, 2025
ARADDCC002
previously approved these changes
Nov 18, 2025
JRB66955
added
enhancement
JR40159
requested changes
Nov 19, 2025
| * - user is not the owner of the model | ||
| * - the user is trying to delete or update an existing AR | ||
| */ | ||
| if ( |
Member
There was a problem hiding this comment.
I think this condition should remain as being for updating and deleting an access and request and a new condition should be added for viewing access requests where we reject if the user cannot view the model or is not named on the access request
ON93754
reviewed
Nov 19, 2025
|
|
||
| // authorisation | ||
| const modelIds = results.map((result) => result.modelId) | ||
| let auths: any[] = [] |
Member
There was a problem hiding this comment.
Is it worth creating a return type for authorisation.accessRequests() so we don't have to use any here?
Although tracing through to accessRequests it looks a little more complicated than i thought
… new condition for viewing ARs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:- work out api routing issue with middleware- tests tbd