Add more commands to WIP sgb.inc - #96
Closed
Narishma-gb wants to merge 19 commits into
Closed
Conversation
Closes gbdev#76
Add header Add include guard Add comments Lowercase DEFs and EQUs Rename SGB_SOUND_ATTRS to SGB_SOUND_FLAGS
- Additional constants for header byte components - Sentence casing for heading comments - Local vertical alignment, not one column level in the whole file Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Collaborator
|
Thank you! That's been cherry-picked to #77. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some more command constants to the new
sgb.incintroduced in #77.It also adds the multiplayer values read from
rJOYPin hardware.inc, that have been suggested here: #77 (comment)Opened as a draft, because I couldn't directly add this to #77. Feel free to pick the commit and continue merging the other PR.