Skip to content

Version 6.0 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Version 6.0 #65

wants to merge 8 commits into from

Conversation

Rangi42
Copy link
Collaborator

@Rangi42 Rangi42 commented Jun 30, 2025

To do before review/merge:

  • Keep using hardware.inc constants in pret disassemblies and look for value use cases that aren't in hardware.inc yet

Fixes #64
Fixes #67
Fixes #68

Whenever this is merged, update rgbds-live's js/gbz80.js tooltips accordingly.

This is technically a backwards-incompatible renaming (just _AUD3WAVERAM -> AUD3WAVERAM), but it would feel excessive to do another major release just for one constant. Still, there's nothing else I currently see to change/add. (Any suggestions? Any niche Pan Docs content that's not yet covered?)

Maybe the next update should take care of TPP1 support? (As discussed in #52, it would create a new hardware_tpp1.inc file to redefine the necessary names.)

@Rangi42 Rangi42 requested a review from avivace June 30, 2025 03:12
Co-authored-by: Eldred Habert <[email protected]>
@Rangi42 Rangi42 changed the title Changed _AUD3WAVERAM to AUD3WAVERAM Version 6.0 Jul 3, 2025
@Rangi42 Rangi42 requested a review from ISSOtm July 3, 2025 03:35
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constants for the base addresses of all four audio channels Add constants for color shades Rename _AUD3WAVERAM to AUD3WAVERAM
2 participants