-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start 👍
Review has been done till line 19.
Let us get these fixed and then we will continue further
Done |
Great work with the fixes. I have added two more suggestions, can you get those fixed and we will continue with the review post that |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Added review till 41
Done |
@KiranAkadas Added few more suggestions |
Fixed them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with fixes till now.
I have reviewed rest of the file.
Lets get these fixed and it will be good to go from my end
Made all the changes :) |
Nice work. A couple of fixes more and this will be good to go |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🎉
Looks good. Let's get this merged 👍
Addresses #1