Conversation
Revert to maintain Python 3.7 support.
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the lap package release v0.5.13, updating packaging metadata and CI/release workflows to add Python 3.14 support while keeping Python 3.7 build compatibility.
Changes:
- Simplifies
setup.py(move tofind_packages, rely oncythonizedirectly, add Py3.14 classifier). - Lowers the build-system NumPy minimum to
>=1.21.6to keep Python 3.7 build support. - Updates GitHub Actions workflows for testing, benchmarking, and publishing wheels across Python 3.7–3.14.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Simplifies setuptools config; uses find_packages and cythonizes from .pyx; adds Python 3.14 classifier. |
| pyproject.toml | Adjusts build-system NumPy requirement to >=1.21.6. |
| lap/lapmod.py | Fixes a docstring typo (“assignement” → “assignment”). |
| lap/init.py | Bumps package version to 0.5.13. |
| README.md | Updates wheels table/linking and Python support text to include 3.14 and v0.5.13. |
| .github/workflows/test_simple.yaml | Expands test matrix to Python 3.14 and updates install-from-branch behavior. |
| .github/workflows/benchmark.yaml | Expands benchmark matrix to Python 3.14 and installs from the current branch. |
| .github/workflows/publish.yaml | Reworks wheel build matrix/jobs (incl. separate Py3.7 jobs) and updates tooling versions. |
| .github/workflows/prepublish.yaml | Mirrors publish workflow structure for manual builds (incl. separate Py3.7 jobs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Improve artifact naming. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improve artifact naming. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.