Repository navigation
fix(github): leave transferred issues alone and stop GHE push duplicates - #7948
gascity-eddie[bot] wants to merge 4 commits into
Conversation
|
This PR has been added to the review queue. Track progress: https://factory.gascity.com/city/maintainer-city/runs/gcg--9223372036829329568 The review restarted at 2026-11-18 13:36 UTC; the link above follows the current run. |
|
Triage: |
Factory review complete: waiting on maintainer approvalApproval request: #7948 What it does:
Review: attempt 4 decision APPROVE, scorecard 881/1000 (threshold 850), required changes: none, review coverage identical. Review TL;DR:
Fixes applied:
CI: pass (PR success, PR Risk success; trusted-fork farm and rbe sync skipped as N/A). Merge path: original PR #7948 (same-repo branch, live head = reviewed head). Reviewed head: |
bee-ghosttrack
left a comment
There was a problem hiding this comment.
APPROVE at 6fcfe7b.
Read: the full production diff — internal/github/{links,tracker,client}.go, internal/tracker/{engine,tracker}.go and the new engine_unaddressable.go. The fix is the one #7794 pointed at: once the tracker has a client, ExtractIdentifier goes through RefScope.IssueNumberFromRef, so a ref to another repository (or another host) yields "" and the engine's pull-fallback key can no longer collide on the bare number. IsExternalRef stays repo-agnostic (now also case-insensitive and GHE-aware via onHost), which is what lets the engine tell "linked outside the configured repository" from "no ref". splitIssueURLPath reads the first issues/{n} pair, so the REST form, the /api/v3 prefix, a repo literally named issues, and /issues/42/comments all resolve as the comments say. ResolveTarget learns the repository's other names by ID through GET /repos/{owner}/{repo} (one call for the configured name, one per distinct foreign owner/repo named in local refs; an HTTP status skips the name, a transport or rate-limit error stops the sync, as the interface doc says).
Ran locally (dolt 2.6.0 on PATH, go test -count=1): the canonical 8 — TestExtractIdentifierScopedToRepository TestExtractIdentifier TestPullFallbackKeyIsRepoScoped TestPull_SameNumberInOtherRepoCreatesNewBead TestPull_SameRepoRespellingsUpdateInPlace TestPush_SkipsBeadLinkedToOtherRepo TestSync_NoConflictWithBeadLinkedToOtherRepo TestEngineDryRunSkipsUnaddressableRef → ok internal/github, ok internal/tracker. gofmt -l clean, go vet clean on both packages.
Mutant: restored the legacy repo-agnostic parse in Tracker.ExtractIdentifier (dropped the t.client != nil branch) → 5 red in internal/github (TestPullFallbackKeyIsRepoScoped, TestPull_SameNumberInOtherRepoCreatesNewBead, TestPush_SkipsBeadLinkedToOtherRepo, TestSync_NoConflictWithBeadLinkedToOtherRepo, TestExtractIdentifierScopedToRepository); internal/tracker stays green, as expected for its fake tracker. Restored.
Notes, none blocking:
CHANGELOG.mdconflicts withmain(git merge-tree): rebase owed before the queue.- The title says
test(github): …but this is a +2183/−35 fix across the github and tracker packages with a newTargetResolverinterface; afix(github):title would describe what lands. Engine.resolveTargetrunsStore.SearchIssues(ctx, "", IssueFilter{})on everySyncto collect refs, on top of the pull/push's own full reads: one more full scan per sync. Fine for correctness; worth a follow-up if sync time on a large store matters.- CI:
proxied-server tierand the Dolt tiers are SKIPPING on this PR (as on every PR), so the local run above is the only read of those packages.
Supersedes contributor #7794 for #7781 (same ExtractIdentifier scoping, plus the warnings, changelog and engine tests it lacked).
|
Approved by @julianknutsen in the maintainer console, for review workflow |
|
Approval from @julianknutsen relayed to review workflow |
Maintainer Adoption ReviewThanks for the contribution, @NahumLitvin! This PR carries your fix from #7794 for the bug you reported in #7781. This PR was reviewed and adopted with maintainer fixes pushed directly to the PR branch. Original PR ReviewDecision: request_changes resolved to approve. Specific gaps fixed:
Review findings addressed (all in maintainer commit
Non-blocking follow-ups (shared for visibility — NOT completed in this PR): Filed as follow-up beads:
Not filed (below the follow-up bar):
Maintainer Changes
Final Review StatusReady for the merge queue: final head GitHub shows a conflict again because #7933 ( CI: https://github.com/gastownhall/beads/actions/runs/41288895375 Review Iterations4 review passes: the first three requested changes (rename and transfer handling, URL spellings, Enterprise hosts, warnings, conflict detection), and the fourth approved. At finalize, one base refresh onto current main, with the PR's package tests re-run on the rebased head: Adopted via |
6fcfe7b to
877fc35
Compare
|
Awesome! Can I consider myself as contributor? |
#8068 landed its own fix for #7781 while this PR waited for the merge queue, so this PR's scoping commits no longer apply: the rebase onto it keeps #8068's code and drops theirs. Two of their regression tests pin behavior #8068 shares and cover what its tests do not. TestPullFallbackKeyIsRepoScoped, the triage repro, checks that a bead linked to another repository's issue never shares the pull fallback key of the configured repository's same-numbered issue. TestEngineDryRunSkipsUnaddressableRef pins the sequential push preview's skip of a ref the tracker cannot address for any tracker, with counts equal to the real run's. Derived-From: 16ab73f, 692c979 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
877fc35 to
72edfd6
Compare
…lone Review of #7948 found two holes in its transferred-issue handling. A pull by bead ID, or a hydration, of an issue GitHub serves under another repository's URL skipped it only when no bead held that URL. A bead linked to the new URL was not asked for and is linked outside the configured repository, yet the pull wrote the issue over it, on a first sync without even the last_sync guard for its local edit. The pull now skips every issue it fetched on its own under a ref the tracker cannot address, whichever bead holds that ref. When Init cannot read the configured repository (its lookup fails while the issue endpoints answer), every issue of a renamed repository comes back under a name the tracker does not know and looked transferred: a push skipped its bead with a warning about a transfer that never happened, the conflict check dropped a bead edited on both sides while last_sync moved past the remote edit, and the next healthy sync wrote the older local edit over it. A tracker can now report whether it knows its target's names (tracker.TargetNamesReporter; GitHub: Init read the repository's current name), and push and conflict detection infer a transfer only when it does. A pull takes an issue from the repository's own issue list into the bead that links its number in the configured repository, under the conflict guard, instead of skipping it, so a conflict resolved for the remote edit lands in that bead rather than nowhere. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
#8068 landed its own fix for #7781 while this PR waited for the merge queue, so this PR's scoping commits no longer apply: the rebase onto it keeps #8068's code and drops theirs. Two of their regression tests pin behavior #8068 shares and cover what its tests do not. TestPullFallbackKeyIsRepoScoped, the triage repro, checks that a bead linked to another repository's issue never shares the pull fallback key of the configured repository's same-numbered issue. TestEngineDryRunSkipsUnaddressableRef pins the sequential push preview's skip of a ref the tracker cannot address for any tracker, with counts equal to the real run's. Derived-From: 16ab73f, 692c979 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
…lone Review of #7948 found two holes in its transferred-issue handling. A pull by bead ID, or a hydration, of an issue GitHub serves under another repository's URL skipped it only when no bead held that URL. A bead linked to the new URL was not asked for and is linked outside the configured repository, yet the pull wrote the issue over it, on a first sync without even the last_sync guard for its local edit. The pull now skips every issue it fetched on its own under a ref the tracker cannot address, whichever bead holds that ref. When Init cannot read the configured repository (its lookup fails while the issue endpoints answer), every issue of a renamed repository comes back under a name the tracker does not know and looked transferred: a push skipped its bead with a warning about a transfer that never happened, the conflict check dropped a bead edited on both sides while last_sync moved past the remote edit, and the next healthy sync wrote the older local edit over it. A tracker can now report whether it knows its target's names (tracker.TargetNamesReporter; GitHub: Init read the repository's current name), and push and conflict detection infer a transfer only when it does. A pull takes an issue from the repository's own issue list into the bead that links its number in the configured repository, under the conflict guard, instead of skipping it, so a conflict resolved for the remote edit lands in that bead rather than nowhere. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
72edfd6 to
04d2b7d
Compare
Factory review complete: waiting on maintainer approvalAdopt-PR approval request: #7948 What it does: Review: attempt 2 = approve, scorecard 906/1000 (threshold 850), required changes: none. Coverage: delta_review.
CI: pass. Both required checks pass (PR, PR Risk green). Reviewed head: |
bee-ghosttrack
left a comment
There was a problem hiding this comment.
APPROVE (delta review at 04d2b7d, rebased onto main c28ee23; previously approved at 6fcfe7b, r1066)
With #8068's repo-scope fix now on main, this PR keeps #8068's code and policy and adds what #8068 does not have: transferred-issue handling (conflict detection and push skip an issue GitHub serves under another repository's URL; a pull by ID or a pre-linked hydration skips such an issue), the push-preview skipped count and one-line skip warnings naming the configured repository (TargetDescriber), RefScope host respellings (www., no scheme, default port, trailing dot) plus the html_url host for an API proxy, and IsExternalRef recognizing a GitHub Enterprise host without "github.com" in its name, so a push updates the linked issue instead of creating a second one.
What ran at 04d2b7d: go vet ./internal/github ./internal/tracker rc=0. internal/github, -run over TestPullFallbackKeyIsRepoScoped|TestIsExternalRef|TestExtractIdentifier|TestPull_|TestPush_|TestSync_|TestResolveRepositoryNames|TestRenamedRepository|TestDetectConflicts|TestInit_ (go test -list: 24 tests): 24 top-level pass, 56 subtests pass, 0 fail, 0 skip. internal/tracker, -run over the unaddressable, dry-run, selective, pull, push, conflict and match-key families (-list: 69): 69 top-level pass, 46 subtests pass, 0 fail, 0 skip (local Dolt server, so the Dolt-backed tests ran). CI at this head: 29 pass, 11 skipped (the Dolt-server tiers), 0 failing.
Mutants against the new behaviour, all bitten:
- leftTarget ignores TargetNamesKnown (engine_unaddressable.go:37): bitten by TestSync_RenamedRepositoryWithoutItsNames, TestPush_RenamedRepository/configured acme/old without the repository's names, and TestEngineWarnsOnceForUnaddressableRefs/push of an issue served under another name, target names unknown.
- the tip's pull guard reverted to existing == nil only (engine.go:492): bitten by TestSync_TransferredIssue/pull by bead ID with the new URL linked to another bead, .../pull hydrating with the new URL linked to another bead, and TestEngineWarnsOnceForUnaddressableRefs/pull by ID.
- unaddressablePull reverted to the approved skip-when-matched (engine_unaddressable.go:65): bitten by TestSync_RenamedRepositoryWithoutItsNames and TestEngineWarnsOnceForUnaddressableRefs/pull.
- IsExternalRef without the onHost arm (github/tracker.go:343): bitten by TestPull_RenamedRepositoryOnEnterpriseHost, TestPush_UpdatesLinkedIssueOnEnterpriseHost and TestIsExternalRefRecognizesConfiguredHost.
- TargetNamesKnown always true (github/tracker.go:399): bitten by TestSync_RenamedRepositoryWithoutItsNames and TestPush_RenamedRepository/...without the repository's names.
- withIssueHost a no-op (links.go:97): bitten by TestResolveRepositoryNamesLearnsTheIssueHost.
Approved semantics that changed, each deliberately and named in the PR body: (1) the per-sync TargetResolver is gone; #8068's Init learns the names, and a failed lookup no longer stops the sync, it keeps the configured name. The new TargetNamesReporter guard makes push and conflict detection fall back to main's behaviour in that case instead of taking a renamed repository's issues for transferred ones. (2) A bulk-list row under an unaddressable URL that a bead links by number in the configured repository is now taken into that bead under the usual local-edit guard; the approved head skipped it, so the remote edit was never pulled and the cursor passed it. (3) A pull by ID or a hydration now skips a transferred issue even when a bead holds its new URL; the approved head wrote over that bead. (4) A path below an issue (/issues/42/comments) is no longer read as that issue, per #8068's TestExtractIdentifierScopedToRepository. The push-preview skipped count is unchanged and is now pinned for any tracker by TestEngineDryRunSkipsUnaddressableRef.
The two carried tests do not contradict #8068's. TestPullFallbackKeyIsRepoScoped is a unit-level twin of #8068's engine-level TestPull_SameNumberInOtherRepoCreatesNewBead. TestEngineDryRunSkipsUnaddressableRef pins at engine level, for any tracker, what #8068 covers only through GitHub (TestPush_OtherRepoBeadLeavesConfiguredRepoIssueAlone). They overlap but cost little. GHE and host handling did not regress: the respellings narrow nothing, a non-default port on github.com stays foreign, and userinfo and suffix spoofs (ghe.example.test@evil.test, ghe.example.test.evil.test) are rejected in TestIsExternalRefRecognizesConfiguredHost.
Non-blocking notes:
- internal/tracker/engine_unaddressable.go:61-65 with engine.go:580 (buildPullIssueUpdates): when Init cannot read the names, the bulk pull takes a renamed repository's issue into the bead linked under the old name and relinks that bead to the new-name URL. That URL is unaddressable until a later sync reads the names, so meanwhile a push skips the bead as "linked outside" and its local edits wait. TestSync_RenamedRepositoryWithoutItsNames asserts the relink and the recovery. The README's known limit (README.md:383-389) and the PR body describe the selective-pull and hydration side of this but not the relink; one sentence would cover it, or keep the bead's addressable ref when taking such a row.
- IsExternalRef still matches /issues/42/comments while ExtractIdentifier rejects it, so a push reports such a bead as "linked outside" the repository. The message is slightly off, but this is #8068's behaviour and the PR body declines to change it.
#8068 landed its own fix for #7781 while this PR waited for the merge queue, so this PR's scoping commits no longer apply: the rebase onto it keeps #8068's code and drops theirs. Two of their regression tests pin behavior #8068 shares and cover what its tests do not. TestPullFallbackKeyIsRepoScoped, the triage repro, checks that a bead linked to another repository's issue never shares the pull fallback key of the configured repository's same-numbered issue. TestEngineDryRunSkipsUnaddressableRef pins the sequential push preview's skip of a ref the tracker cannot address for any tracker, with counts equal to the real run's. Derived-From: 16ab73f, 692c979 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
…a ref PR #8068 scoped GitHub refs to the configured repository and learns its other names at Init, which this PR did through a tracker TargetResolver at the start of each sync. The rebase onto it keeps #8068's design and policy and carries the rest of this PR onto them. An issue transferred out of the configured repository: GitHub follows the transfer, so fetching a bead's issue returns it under the other repository's URL. Conflict detection compared the bead with it, a push could write the bead over it, and a pull by bead ID or a pre-linked hydration imported it as a new bead. Now conflict detection and the push leave it alone, and a pull skips such an issue when it fetched it on its own, or, from the issue list, when a bead already links the configured repository's issue with that number. Warnings: a push says when it skips a bead linked outside the configured repository, in one line for a bulk push (a rate-limit abort included) and once per bead for a push by ID, and a pull says when an issue came back under a URL outside it, naming the configured repository (new optional tracker.TargetDescriber). Hosts: IsExternalRef recognizes an issue URL on the configured host and github.com in any letter case, so on a GitHub Enterprise host whose name lacks "github.com" a push updates a linked issue instead of creating a second one and relinking the bead. RefScope accepts the host respellings the legacy parse did (a www. prefix, a missing scheme, an explicit default port, a trailing dot), and the host of the repository's html_url, which Init now records with its name, so an API proxy in front of github.com addresses the github.com refs it returns. Not carried: the TargetResolver and its failure policy (a failed lookup stopped the sync; #8068's Init keeps the configured name and goes on), this PR's wording of the pull-by-bead-ID warning (#8068's stays), and reading a path below the issue (/issues/42/comments) as that issue, which #8068's TestExtractIdentifierScopedToRepository rejects. The renamed-repository tests resolve names as Init does, and still pin that a renamed repository's refs raise none of these skips or warnings. Derived-From: 877fc35, 08ec414, af3248b Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
…lone Review of #7948 found two holes in its transferred-issue handling. A pull by bead ID, or a hydration, of an issue GitHub serves under another repository's URL skipped it only when no bead held that URL. A bead linked to the new URL was not asked for and is linked outside the configured repository, yet the pull wrote the issue over it, on a first sync without even the last_sync guard for its local edit. The pull now skips every issue it fetched on its own under a ref the tracker cannot address, whichever bead holds that ref. When Init cannot read the configured repository (its lookup fails while the issue endpoints answer), every issue of a renamed repository comes back under a name the tracker does not know and looked transferred: a push skipped its bead with a warning about a transfer that never happened, the conflict check dropped a bead edited on both sides while last_sync moved past the remote edit, and the next healthy sync wrote the older local edit over it. A tracker can now report whether it knows its target's names (tracker.TargetNamesReporter; GitHub: Init read the repository's current name), and push and conflict detection infer a transfer only when it does. A pull takes an issue from the repository's own issue list into the bead that links its number in the configured repository, under the conflict guard, instead of skipping it, so a conflict resolved for the remote edit lands in that bead rather than nowhere. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
When Init cannot read a renamed repository's names (the lookup answers 404) and the configuration names the old one, a bulk pull returns issue N under the new name, a URL the tracker cannot address. unaddressablePull takes the row into the bead linked to issue N under the configured repository, but the pull then wrote the row's URL into that bead's external_ref. From the next sync on, conflict detection skipped the bead and the push skipped it as linked outside the configured GitHub repository, so a local edit never reached GitHub and the next remote edit overwrote it. Base imported a duplicate instead and kept the bead pushable, and the README says that after a 404 push and conflict detection handle the issue as the configured repository's. unaddressablePull now also returns the ref to link the row under: the matched bead's own ref when the tracker can address it, else the row's URL (with no match the import keeps the row's URL, as on base). The pull uses that ref for the update, the equality check, the label check, the push hash and the dry-run preview, so the bead keeps its link until Init reads the names, after which a pull relinks it to the current-name URL as before. TestSync_RenamedRepositoryWithoutItsNames now expects the bead to keep its acme/old link after the first sync, and a new subtest makes a local edit and syncs again without the names: the push PATCHes /repos/acme/old/issues/42 and the bead stays linked under acme/old. TestEngineWarnsOnceForUnaddressableRefs checks that the matched beads keep their refs; its fake store now applies an external_ref update, as the real stores do, so that check can fail. Review: PR #7948 iteration 1 (Behavioral Correctness, major). Agent-Signature: claude-code-opus-5.5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com>
04d2b7d to
0a7afb5
Compare
Factory review complete: waiting on maintainer approvalPR #7948 — fix(github): leave transferred issues alone and stop GHE push duplicates What it does: Review: attempt 2 = approve, scorecard 906/1000 (threshold 850), required changes: none, review coverage: identical. Review TL;DR:
CI: pass — both required checks green (PR, PR Risk); Bazel Farm (trusted forks) skipped. Merge path: original PR #7948 (same-repository branch fix/bd-ijkgro, updatable by maintainers). Reviewed head: |
bee-ghosttrack
left a comment
There was a problem hiding this comment.
Delta approve at 0a7afb5c68 (bee, r1256) over the head I approved, 04d2b7d364: a rebase from main c28ee2357a onto 36a4823240 (the three earlier commits range-diff =) plus one production commit.
0a7afb5c68: when a bulk pull takes a row that came back under a URL the tracker cannot address (a renamed repository whose names Init could not read) into the bead linked under the configured repository's ref, the pull used to write the row's URL into that bead's external_ref, after which push and conflict detection skipped it as linked outside the repository and the next remote edit overwrote the unpushed local edit. unaddressablePull now also returns the ref to link under — the matched bead's own ref when the tracker can address it, else the row's URL — and doPull uses that ref from there on (update, equality check, label check, push hash, dry-run preview). I read the call site: outsideRefs is appended before the ref is replaced, so the once-per-sync warning still names the URL the row came back under; the skip path (i >= bulkRows) returns the ref unchanged, so skippedOutsideRefs is as before; with no match existing is nil and the row imports under its own URL, as on base.
Base leg: with this head's test files over 04d2b7d364's engine.go and engine_unaddressable.go, TestEngineWarnsOnceForUnaddressableRefs fails on the two kept-ref assertions (external_ref = ".../foreign/EXT-3", want ".../EXT-3") and TestSync_RenamedRepositoryWithoutItsNames fails on still linked to acme/old, on the PATCH the local edit must produce (wrote [], want ["PATCH /repos/acme/old/issues/42"]) and on the Skipped local issue bd-o42 warning. On the unmodified head both pass. The engineIssueUC fake now applies external_ref updates, which is what lets the tracker-package check fail at all.
What I ran at 0a7afb5c68 in a fresh worktree: go build ./... rc 0; go test -count=1 ./internal/tracker ./internal/github -run 'Renamed|Unaddressable|TestSync_|TestPush_' PASS; the base leg above. Every check is green at this head.
#8068 fixed #7781 on main first, with its own design: GitHub refs
resolve only within the configured repository, and Init learns the
repository's other names. This PR is rebuilt on that fix. It keeps
#8068's code and policy and carries the rest of this PR onto it.
Transferred issues. GitHub follows a transfer, so fetching a bead's
issue returned it under the other repository's URL. Conflict detection
compared the bead with it, a push could send the bead's content to its
old URL, and a selective pull (by bead ID or issue number) or a
pre-linked hydration imported it as a new bead, or wrote it over a bead
already linked to its new URL. Now:
says why it skipped the bead.
a URL the configured repository cannot address, whichever bead holds
that URL.
repository's own issue, served under a name the tracker does not
know. The pull takes it into the bead that links its number in the
configured repository, under the usual local-edit guard, and imports
it when no bead does. That bead keeps its link, so the push still
updates the issue: relinked under the new name, it would drop out of
push and conflict detection.
Push and conflict detection infer a transfer only when the tracker
knows its target's names (new optional tracker.TargetNamesReporter;
GitHub: Init read the repository's current name). Without them an issue
of a renamed repository looks transferred, so when GitHub answers that
lookup with a 404, push and conflict detection treat the issue as the
configured repository's, as main does. Any other failure stops the
command, as on main since #8399. The README says so.
Warnings. A push says when it skips a bead linked outside the
configured repository: in one line for a bulk push, including one a
rate limit cuts short, and once per bead for a push by ID. A pull says
when an issue came back under a URL outside the configured repository,
and which ones it skipped. The warnings name the configured repository
(new optional tracker.TargetDescriber).
Hosts. IsExternalRef recognizes an issue URL that contains github.com in
any letter case or, once the tracker is initialized, sits on a host of
the configured repository. On a GitHub Enterprise host whose name lacks
"github.com", a push now updates the linked issue instead of creating a
second issue and relinking the bead to it. RefScope accepts the host
respellings the legacy parse did: a www. prefix, a missing scheme, an
explicit default port, a trailing dot. Init records the host of the
repository's html_url with its name, and that host counts as the
configured host, so an API proxy in front of github.com addresses the
github.com refs it returns.
Not carried from this PR's first design: its per-sync TargetResolver
and that resolver's failure policy (a failed lookup stopped the sync;
main's Init goes on with the configured name after a 404, and since
#8399 fails on any other error), its wording of the
pull-by-bead-ID warning (#8068's stays), and reading a path below an
issue (/issues/42/comments) as that issue, which #8068's
TestExtractIdentifierScopedToRepository rejects.
Known limits:
sync cannot tell a renamed repository's issue from a transferred one.
A selective pull or a hydration skips either as outside the
repository, while the same sync's push can write the bead over it,
as main's push can.
"Would update" for a bead whose issue was transferred; the real run
skips it.
Testing at 0a7afb5, with bazel-test (--config=ci):
skipped; //internal/tracker:tracker_dolt_test with --config=doltserver:
222 passed, 0 skipped.
//internal/jira:jira_test, //internal/linear:linear_test,
//internal/notion:notion_test and
//internal/tracker/conformance:conformance_test: all passed.
The tests this PR adds include TestSync_TransferredIssue,
TestSync_RenamedRepositoryWithoutItsNames, TestPush_RenamedRepository,
TestPush_SkipsBeadLinkedToOtherRepo,
TestPush_UpdatesLinkedIssueOnEnterpriseHost,
TestResolveRepositoryNamesLearnsTheIssueHost,
TestIsExternalRefRecognizesConfiguredHost,
TestEngineWarnsOnceForUnaddressableRefs and
TestEngineReportsUnaddressablePushSkipsOnRateLimitAbort.
TestPullFallbackKeyIsRepoScoped (the #7781 triage repro) and
TestEngineDryRunSkipsUnaddressableRef pin behavior #8068 shares.
Source bead:
bd-ijkgro· checkpoint pipeline v0Fixes #7781