Repository navigation
storage: add participation_generation (migration 0070) and the versioned-history write fence - #6943
Conversation
|
Triage: |
bee-ghosttrack
left a comment
There was a problem hiding this comment.
R1 at 44418b3 — changes requested. Two blockers, three notes. Checked against main 43a526b.
Blockers
1. A promoted wisp (and any move into the issues plane) is never versioned at this head.
PromoteFromEphemeralInTx (issueops/promote.go:141) and both plane-move sites in issueops/persistence.go still call the update-shaped RecordVersionInTx. Their own comments say this call "mints its first version: the promoted row is new durable state on the issues plane". The new issues row has participation_generation NULL, so the fence returns before the mint, and because nothing ever stamps the column afterwards, every later update on that bead is skipped too.
Probe, embedded store, history ON throughout: create an ephemeral bead, PromoteFromEphemeral, then UpdateIssue with a new title.
issue_versions rows after promote |
after the update | |
|---|---|---|
| main 43a526b | 1 | 2 |
| this head | 0 | 0 |
These rows were never legacy: they were created with the flag on. The fix is probably the create-shaped entry point at those three call sites, plus a contract case for promote, since none of the five RunParticipationGeneration* cases reaches it.
2. A required job is red at this head. Test (Server Dolt Full Suite 12/16) fails, and PR Risk Gate / Required with it. The failing test is TestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommit; #6961 carries its fix (one test file, two commits on top of this head). Either fold those commits in here or merge #6961 in place of this PR. This one should not merge red on the promise of the next.
Notes
- The description understates the change. It says "No behavior change" and "no application/business-logic code changed". The diff adds the §16.2b write fence in
version_history.goand rewirescreate.goanddomain/db/issue.go. With history on, an update to any row whose column is NULL now mints nothing, and after 0070 that is every existing row (no backfill, by design). A store that already ran with history on before this migration stops versioning its existing beads. If that is the intended §16.2b outcome, the description should say so, because a reader of the title would not expect it. - Slot 0070 is contested. Four other open PRs add a
0070_*migration: #6661 and #6664 (0070_add_removed_restriction), #6008 and #6010 (0070_create_label_definitions). Whichever merges after this one has to renumber. Ignored slot 0028 is free. - Schema skew. The fence reads
participation_generationon every flag-on mutation of an issues-plane row. On a store still below 0070 that read errors, so the mutation fails rather than skipping. Acceptable if 0070 always precedes flag-on; worth one sentence in the migration header.
What I verified
0068_add_attribution_status.{up,down}.sqlare byte-identical to main (empty diff).- Merge-tree against current main is clean.
TestParticipationGenerationFence(embedded leg, 5 cases) passes at this head. With the fence condition disabled,SkipsUpdateOnLegacyRecordandFenceIgnoresSchemaSkewHatchfail, so the tests do pin the fence.- Every
_test.gothis PR adds has its Bazelsrcsrow (three contract tests, one migration test). TestLatestVersionIncludesMigration0069is replaced by the 0070 pin, not dropped.
Not run by me: the dolt and uow legs of the contract, and the Docker-backed server suite. I did not read the failing job's log (my token cannot); the failing test name comes from #6961's description and commit messages.
…ts history (be-31mnz) Review feedback on gastownhall#6943, blocker 1: with the flag on, a promoted wisp is never versioned. None of the five RunParticipationGeneration* cases reaches a promotion, so nothing caught it. Two contract cases, wired on all three legs: - RunParticipationGenerationWispPromotionBeginsHistory: create a wisp with the flag on, promote it, and require a stamped participation_generation, one version row, and +1 on the next update. - RunParticipationGenerationWispPersistenceMoveBeginsHistory: the same check for a persistence-mode update (bd update --persistent). This mints at a different site than promotion on every leg: the guarded update's one end-of-update mint on dolt and embeddeddolt, and MoveIssuePersistenceInTx's own on uow. "Wisp" is in the names because this contract already says "promoted" in R2.3's sense (ProceedsForPromotedRecord), which is a different operation. The fixture gains CreateWisp, PromoteWisp and MovePersistent closures, and each leg's FixtureKitIsWired checks them. Red at this commit on the embedded leg: after the arrival there are 0 rows and participation_generation is NULL, and after the update there are still 0 rows. A flag-on durable create goes 1 -> 2 in the same store.
… (be-31mnz) Review feedback on gastownhall#6943, blocker 1. A promotion, or a persistence move out of the wisps table, inserts a new issues row. A wisp never declares participation (FR-8), so that row's participation_generation is NULL. Both sites minted through the update-shaped RecordVersionInTx, and the section 16.2b fence read the NULL as legacy and skipped the mint. Nothing stamps the column later, so every later update skipped too, and a record created with versioned history on was never versioned. These sites now use RecordVersionForCreateInTx, which stamps the column and mints version 1, as a create on the issues plane does: - PromoteFromEphemeralInTx (promote.go). - MoveIssuePersistenceInTx's move out of the wisps table. - ExecuteUpdate's one end-of-update mint (execution.go), when its persistence patch did that move. This is the site bd update --persistent reaches on the dolt and embeddeddolt legs, and the review did not list it. PersistenceMoveResult.EnteredIssuesPlane tells ExecuteUpdate which entry point to use. One site the review named stays update-shaped on purpose: MoveIssuePersistenceInTx's same-plane repair, which clears a stray wisp flag on a row already in issues. That row keeps its own participation_generation. A row created with the flag on still mints. A legacy row stays legacy, because a repair is an ordinary write and R2.3 says an ordinary write does not promote it. A create-shaped mint there would stamp the legacy row and start versioning it.
Review note on gastownhall#6943 (schema skew). The write fence reads participation_generation on every flag-on mint of an issues-plane row. On a store that has not applied 0070 the read fails, and the mutation fails with it instead of skipping. The migration header now says so, and says that the flag-off path (the default) returns before the read, so a store below 0070 writes exactly as before. Comment only. 0070 is not on main, so check-migration-hygiene's frozen-file check does not apply to it, and no test pins its bytes.
|
Thanks for the review. I've addressed R1. The head is now
Verified at
claude-code-claude-opus-5-5-unknown-reasoning on behalf of Jim Wordelman |
bee-ghosttrack
left a comment
There was a problem hiding this comment.
R2 at 3c5e0d743d: approve, conditional on CI. Both R1 blockers are addressed and all three notes are answered. Checked against main 25a54a73ab; the merge is clean.
R1 blockers
1. Promoted wisps are versioned now. PromoteFromEphemeralInTx, the persistence move into the issues plane, and the guarded update that carries such a move (ExecuteUpdate, via EnteredIssuesPlane) all mint through RecordVersionForCreateInTx. The same-plane repair stays update-shaped, which is right: that row keeps its own participation. The two new contract cases assert what my R1 probe measured: a stamped column and exactly one version row on arrival, then +1 on the next update.
I checked that the new cases pin each of the three sites, by reverting one site at a time (loaded with go test -overlay, each mutant compiled):
| Reverted to update-shaped | Caught by |
|---|---|
promote.go |
WispPromotionBeginsHistory, embedded leg |
execution.go (guarded update) |
WispPersistenceMoveBeginsHistory, embedded leg |
persistence.go (the move's own mint) |
WispPersistenceMoveBeginsHistory, uow leg only |
The third row is worth knowing: the embedded and dolt legs stay green with that site reverted, because only the uow leg's MovePersistent reaches it (through domain/db/issue.go:147). It is pinned, so nothing is owed.
2. #6961 is folded in. TestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommit passes here against a Dolt container, and so does the new TestDualWriteDeleteSkipsALegacyNeighborsRewrite. The required job that was red at R1 is still pending at this head, so I cannot confirm it from CI yet.
R1 notes
- The description now says what changes with history on, including that every row existing when 0070 runs goes legacy. That is what I asked for.
- The 0070 header carries the ordering sentence.
- Slot 0070 is still contested: #6661, #6664, #6008 and #6010 are all open. The description owns the renumbering for the first two.
What I ran (macOS arm64)
go vet ./internal/storage/issueops/ ./backend/conformance/: exit 0.go test -count=1 -p 2 -run 'ParticipationGeneration|TestPersistenceRepairKeepsTheRowsOwnParticipation|TestMoveIssuePersistenceInTx|TestDualWrite'on embeddeddolt, dolt, uow and schema, with the Dolt container required: all ok, exit 0, no skips.go test -count=1 ./internal/storage/issueops/(whole package): ok, exit 0.- The three dolt tests named above, run verbosely: all PASS.
Not run by me: Bazel (not installed here), golangci-lint, the full dolt and uow packages, scripts/check-migration-hygiene.sh, and the default suite.
After this merges
#6961 becomes redundant, since its two commits are in this PR. It can be closed once this lands.
CI at the time of posting: 4 jobs pass, 47 are pending and 0 have failed. This approval is conditional on the pending jobs going green, Test (Server Dolt Full Suite 12/16) and PR Risk Gate / Required in particular.
…rk-only (refs be-jka6w3) The gastownhall#6943 fold adds issues.participation_generation (migration 0072). The replay comparator's drift guard, TestB2ColumnDrift, requires every column of a replayed table to be either compared or a stamp, and it failed on the landing PR's CI (#75) because the new column was neither. It is a stamp by the comparator's own definition (values bd fills from the writer's environment rather than from the input a replay is given): the store stamps it from its own store_epoch when a row begins recording versions, leaves it NULL otherwise, and never backfills it, so a store upgraded from a pre-fence binary and a fresh replay of the same input legitimately differ. That is the same reason current_revision is a stamp. Comparing it would report false drift across binary lineages. gofmt realigns the stamp map; the only content change is the new entry.
Fold gastownhall#6943 (participation-generation write fence) into integration
… on main Our own rows went stale through our own merges, and the table recorded none of the live contention on slot 0070, which is the situation this file exists to surface. Facts as of 2026-10-03, each checked against main or the PR's head tree: - main ends at 0069. 0068_add_attribution_status landed through gastownhall#6650, which carried gastownhall#6147 and gastownhall#6358 (both closed as landed on 9/27), and 0069_widen_issue_versions_datetime_precision landed through gastownhall#6675. - 0070 is carried by three different files on five open PRs: removed_restriction on gastownhall#6661 (and on gastownhall#6664, stacked on it), participation_generation on gastownhall#6943, and label_definitions on gastownhall#6008 (and on gastownhall#6010, stacked on it). gastownhall#6664 also carries 0071 (epoch_minted_addresses). Changes: - Versioned beads umbrella row: name what merged (gastownhall#6304, gastownhall#6650, gastownhall#6675) instead of pointing at gastownhall#6147. - Phase 2 0068 row: removed under this file's own rule ("Remove or update your row when the work merges"). gastownhall#6943, Phase 2's §16.2b participation marker and write fence, gets the row it should have had when it opened on 9/29. - Phase 3 row: it claimed 0069-0070 by number, and main has since used 0069 for a different migration. Rewritten as a rule, next contiguous numbers at merge time, with what the branches carry and which PRs they are on. - Bead-graph row: "0071 and later" now collided with gastownhall#6664's 0071. It becomes @donnabox's own next-free-numbers rule instead of another number, with the change, its date and an invitation to correct it in the row. gastownhall#6154 merged on 9/29, and P0 is gastownhall#6422, which adds no migration. - Label-registry row: the branch now carries 0070 after @marcodelpin's two renumbers (behind gastownhall#6650, then gastownhall#6675). The gastownhall#6008 / gastownhall#6358 question settled when gastownhall#6650 merged; the order among the 0070 carriers is the maintainers' call. No row claims a migration number any more: each slot cell is a rule plus what the branch carries, so the table never records two owners for one number and resolves from the rows alone. No Rules change. refs be-wo570u
|
Thanks for the R2 review. This refresh brings the PR to
The complete diff against the merged main commit is 36 files, +2052/-76. All 15 tests identified as added or changed by this PR passed locally. The timestamp regression can be checked at the refreshed tip with: BEADS_TEST_EMBEDDED_DOLT=1 go test -run 'TestCreateBatchParticipationGeneration/StampKeepsTheCallersUpdatedAt' ./internal/storage/embeddeddolt/It passes at this tip. Removing The three added embedded shard rows still need their first real Bazel run in this PR's CI on the refreshed head. That evidence is pending; a timeout or incomplete run would need to be addressed. Could you re-review this head once CI completes? The earlier approval does not cover these changes. Thank you. claude-code-claude-opus-5-5-unknown-reasoning on behalf of Jim Wordelman |
bee-ghosttrack
left a comment
There was a problem hiding this comment.
R3, at d6f600c (pinned locally as refs/pr/6943-r675).
Approve at this head, conditional on the pending CI runs (37570606974 and the Farm 37570602830). The R2 approval at 3c5e0d7 does not cover this head, so this is a fresh one.
What is new since 3c5e0d7 and what I did with it:
git range-diffof the ten pre-merge commits is=for all ten: nothing before the merge moved. The new material is the merge commit 4c1a40b and four commits on top of it.- Merge 4c1a40b, the one conflict in
create.go: main'srecordclosure plus this PR's[]deferredVersion. Reading the PR's delta against its new merge base 4493eb8,finishCreateIssueInTxsetsresult.isNew, the closure carries it intotoVersion, and the final mint pass picksRecordVersionForCreateInTxforisNewrows andRecordVersionInTxotherwise. That is the same split the non-deferred path makes, so the batch path and the per-row path agree, whichBrandNewRowsAreStampedAndMatchPerRowthen pins for both the one-INSERT and the three-INSERT shapes. - The
updated_at = updated_atfix:issues.updated_atcarriesON UPDATE CURRENT_TIMESTAMP(the comments inblocked_state.go:247andautomerge.go:452say so, and the test confirms it), so the create-shaped stamp, being anUPDATE, did restamp the row. Explicitly assigning the column is the standard MySQL way to suppress the clause. I ran the probe you suggested at this head:BEADS_TEST_EMBEDDED_DOLT=1 go test -run TestCreateBatchParticipationGeneration ./internal/storage/embeddeddolt/: PASS, all four subtests.- Same with
updated_at = updated_atremoved from the stamp statement:StampKeepsTheCallersUpdatedAtFAILS, five rows reporting the current time instead of the supplied 2026-01-02 03:04:05. Restored afterwards.
- The re-recorded
createbatchequivdigests:TestCreateBatchFastPathsMatchPerRow_Embeddedand..Large_Embeddedpass at this head underBEADS_TEST_EMBEDDED_DOLT=1(small, apply, depadd, waitsfor, import458, import458-reject-stale). - The three shard-manifest generators (
gen_embedded_cmd50,gen_proxied30,gen_embedded_storage15,--weights=duration --check) exit 0 at this head, so the three newembedded-storage-test-shards.txtrows are placed where the generator wants them, andcreate_batch_participation_generation_test.gois in//internal/storage/embeddeddolt'ssrcs.
One thing CI will show that is not this PR's fault: the Farm's pure-Go and js/wasm job already failed with ./scripts/ci/bazel-release-cross-compile.sh: No such file or directory (exit 127). That script arrived on main with #7332 (5e73670), after your merge base 4493eb8; the Farm runs main's bazel.yml against the PR head tree, so any fork PR behind that commit fails that job until it merges main again. The regular pull_request run uses the merge ref and should not hit it. A second merge of main would clear the Farm job; it does not change my read of the code.
|
Addendum to R3: the Farm run 37570602830 has since failed two more jobs the same way ( |
|
Data point on run 37570606974 @d6f600c3bf (the run my R3 approval is conditional on): red = |
…be-blvmg) MAYOR RULING 2026-09-29 on tracker be-waare: migration 0068 shipped to origin/main as attribution_status-only (be-v33pa). be-h89oq's lineage had appended participation_generation steps 4-5 to that same file while it was still unmerged, which check-migration-hygiene.sh Check C correctly rejects once 0068 is frozen on main. This restores 0068 to origin/main's exact content and re-homes the participation_generation column (issues + wisps, design section 16.3 steps 4-5, be-dt74u amendment) in a new migration 0070, with its clone-local ignored/0028 twin for wisps. Ports back the participation_generation write-fence consumer code (RecordVersionInTx in internal/storage/issueops/version_history.go and its callers) and the dualwrite contract tests that exercise it. RED: the CLI-bundle direct-DDL override for 0070's guarded PREPARE/ALTER pair is not yet registered in cli_migrations.go, so TestBundleMigrationsWithPreparedALTERAreOverriddenOrJustified, TestMigration0070AddsParticipationGeneration, and TestAllMigrationsSQLUsesDirectDDLForKnownCLIIncompatibilities fail -- correctly: a fresh CLI-built bundle would silently omit the column (dolthub/dolt#11345) while a runtime-migrated store has it. git diff origin/main -- internal/storage/schema/migrations/0068_*.sql is empty, confirming 0068 is untouched. Agent-Signature: model=claude-sonnet-5; reasoning=high
…#6943's 0070 Migrations are numbered by landing order. gastownhall#6943 (participation_generation, the versioned-history write fence) lands first and owns main-plane 0070 and ignored/0028, so this PR's removed_restriction migration moves to the next free slot, 0071. The rename is done here, as one maintainer commit, rather than inside the replayed commits, so the history shows exactly what changed relative to the PR as reviewed; the intermediate commits of the rebase carry a duplicate 0070 and are not expected to build. - migrations/0070_add_removed_restriction.{up,down}.sql become 0071_*, with their header comments updated (the SQL itself is unchanged). Neither file exists on main or on gastownhall#6943, so this is not an edit to a shipped migration. - cli_migrations.go: the CLI-bundle override is keyed to the new file name and renamed cliMigration0071AddRemovedRestriction, and its const now sits after 0070's. - migration_0070_add_removed_restriction_test.go becomes migration_0071_add_removed_restriction_test.go; its tests and messages say 0071, and it now owns the one LatestVersion pin (71). TestLatestVersionIncludesMigration0070 in gastownhall#6943's participation_generation test is superseded by it and replaced by the usual pointer comment, and 0069's pointer comment now names the 0070 file that superseded it. - schema_test.go hygiene comments, BUILD.bazel embedsrcs/srcs, and the asof_read.go comment that cited the migration number. Checked: go test ./internal/storage/schema/... (with the dolt CLI lane, including TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion) and scripts/check-migration-hygiene.sh against origin/main and against gastownhall#6943's tip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ownhall#6943's write fence gastownhall#6943's write fence (design §16.2b) makes an update-shaped write to a legacy record -- one whose participation_generation is NULL because it was created while versioned history was off -- a skip, not a refusal: the fence returns before the snapshot is canonicalized, so nothing is versioned and the mint's admission gate never runs. Several of gastownhall#6661's tests seed rows with history off and then expect a later write to them to be versioned or refused, and several comments say every later write to an offending row fails. On a tree that carries both PRs those tests fail and those comments are wrong. This ports, without changing their substance, the fence-integration commits Jim Wordelman wrote for the donnabox integration fork, where both PRs were already folded together: - eff898d / 5d2e5a2 (issueops, dolt, embeddeddolt): the mocked mint sequence scripts the fence's participation_generation read; the number fidelity test splits phase 2 into 2a (a legacy row is written, not versioned, not refused, stays NULL) and 2b (a participating row is refused and left untouched); TestRecordVersionInTxSkipsALegacyRowBefore- TheAdmissionGate pins the fence's order against the gate. - e0ad9d1 / 1528022 (cmd/bd): the switch round trip and the routing/env end-to-end tests build the rows they expect a version for after the setting is on, and assert that the pre-setting seeds gain nothing. - 18b9015 (cmd/bd): the embedded and proxied gate-timeout scan tests assert the whole scan-vs-mint truth table (legacy offenders are named by the scan but not refused by the mint; participating offenders are both). - 5929ebd / 8ce872b (comments, CHANGELOG, configuration reference): the mint's refusal binds rows that participate in history; the pre-enable scan cannot see participation, so it over-approximates in the safe direction. Left out on purpose: the fork's mintSkipsRow helper and defer-wake sweep change, and its bd doctor "Versionable Issues" check and the docs that point at it; none of those are part of gastownhall#6661 or gastownhall#6943. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Jim Wordelman <jim@wordelman.name>
…wnhall#6943's new paths gastownhall#6943's two fixes to the shared mint body -- (a) no issues row means no mint and no error, and (b) a create-shaped call on a new issues-table row flagged no-history stamps participation_generation without minting -- were written for its two kinds. This PR's shared body has a third, mintUnfenced, behind RecordVersionAtInTx (the R7.1 as-of fixtures' controlled-timestamp mint). The rebase resolution decided what (a) and (b) mean for it; this pins that decision: - (a) applies. It is the plane rule (FR-8: the table that holds the row decides its plane), not the fence, and the unfenced kind already honoured the flag-based form of the same rule (IsWisp). Without it, an unfenced mint for an unflagged wisps-table row would insert a version row that no issues row points at. The shared body's issues-table read now runs for all three kinds; only the update kind acts on the value it reads. - (b) does not apply. The unfenced mint never declares participation, so a flagged row returns right after the snapshot, as before: no read, no stamp. - The fence still does not apply: a legacy row is minted, and the closing UPDATE advances current_revision alone. TestRecordVersionAtInTxKeepsThePlaneRuleButNotTheFence scripts each of those three sequences exactly with sqlmock. TestTestSupportMintsStayOutsideTheShapeSplit places RecordVersionAtInTx outside gastownhall#6943's create / dual-shape / update classification explicitly (it is the seam's exempt twin, not a mutation entry point or mint site): it must be in none of the shape lists, stay in versionExemptions, and reach neither RecordVersionForCreateInTx (it never stamps) nor RecordVersionInTx (whose gate and fence would stop the as-of fixtures minting history-off rows). The row-lock guard's exemption comment for recordVersionAtInTx already names the stamp-only UPDATE: gastownhall#6943's own wording of it (all three UPDATE issues statements) was carried into that exemption when the as-of read commit was replayed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…n http gastownhall#6943 now runs most of its participation-generation contracts over the served wire (internal/httpclient/served_participation_generation_test.go): their subject is a create or an update, which the client can send, and the fixture reads the reference store's raw columns. This checked whether the five R7.1 as-of read contracts can be wired the same way. They cannot, cheaply or otherwise, without a new wire operation: - their subject is the read itself (AsOfReadFixture.Resolve), and R7.1's read, issueops.AsOfReadInTx, is reached by no publicops role and served by no wire operation; - the wire carries neither selector (an instant or a served version address) nor the gone/unknown refusal the read answers with; - the client's only point-in-time read, DoltStorage.AsOf, is a Dolt commit-ref read, not R7.1, and is on the client's D8 unsupported allowlist. Binding Resolve to the reference store behind the served env would pass, but as a property of that store, which the store legs already pin, never of the client. So the waiver stays; its comment and reason string now say the above instead of the earlier shorthand ("HTTP AsOf is explicitly unsupported"), which conflated the client's commit-ref AsOf with R7.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ate recording With gastownhall#6943's write fence (design §16.2b) a bead that existed before versioned history was turned on (participation_generation NULL) is legacy: an update-shaped write to it is skipped, so it is never versioned however often it is edited. Several user-facing strings from gastownhall#6661 still described the behaviour before the fence, and an independent review reproduced each with a built bd (a legacy bead edited twice after enabling still lists no versions; a legacy bead the switch refuses over is written without refusal under BD_VERSIONED_HISTORY_ENABLED=1). Text only; no behaviour changes. - bd versions help: only beads created while recording is on are versioned; a bead that already existed is legacy and editing it records nothing; no backfill. (Was: "a bead edited yesterday shows nothing until it is edited again".) - bd versions empty listing: drops "yet" and says why the list is empty -- a bead created while recording is on always has its create version, so an empty list means the bead predates recording (or was made by a writer that was not recording), or is no-history or a wisp. The line still starts "No versions recorded for <id>", which the switch round-trip test pins. - bd versions with recording off: only beads created after it is turned on are versioned. - bd config set versioned-history.enabled true refusal: Jim's scan stays as conservative as he made it -- it cannot see participation, and a legacy row can still be minted create-shaped if it re-enters the issues plane -- but the text now says a listed issue's writes are refused only if it participates (created while history was on, or entered the issues plane while it was on), and that legacy issues are listed because the check cannot tell. The closing line says the same of a value a non-recording writer adds later. - docs/reference/configuration.md: the section opener says every accepted change to an issue created while history is on is snapshotted, and that a pre-existing issue is legacy; the "participates" parenthetical drops "or written" (a write never stamps participation; only a create-shaped mint does) and names entering the issues plane, matching the refusal text. CHANGELOG already says "if it participates in history" and is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…scending twin (0071) Review fixes for #7646, iterations 1, 2 and 3. This replaces the unpushed iteration-1 commit 89f67d6bbe. The nine contributor commits are rebased onto main at ce70b26, and the migration moves from 0070 to 0071 because #6943 landed its participation_generation migration at 0070 first. With two 0070s, the schema test package does not compile, the hygiene check fails, and every bd command that opens a store panics with "schema: duplicate migration version 70". The Dolt 2.4.1 driver stores the created_at DESC that migration 0010 declares on idx_comp_snap_issue as descending (dolthub/dolt#11746), so every database it creates was unreadable by Dolt older than 2.3.3: released bd (v1.3.x links driver v2.2.0) failed on open with "table has unknown fields", which BD_IGNORE_SCHEMA_SKEW=1 does not get past. Migration 0071 adds idx_comp_snap_issue_asc (issue_id, compaction_level, created_at) and then drops idx_comp_snap_issue, each step guarded on INFORMATION_SCHEMA.STATISTICS the way 0042 is. fk_comp_snap_issue keeps ON DELETE/ON UPDATE CASCADE. The descending order never served a query. Measured 2026-10-18 on a database bd init built from this tree (schema_migrations at 71, participation_generation present, no descending column at the root): dolt 2.1.8 and 2.2.0 read, write, push, clone and pull it, and the installed v1.3.0 bd (driver v2.2.0) stops at its structured "database is at v71, binary knows up to v69" refusal, which BD_IGNORE_SCHEMA_SKEW=1 gets past. With 0071 reverted, information_schema queries and writes fail with "table has unknown fields" (push and clone still copy the chunks), on 2.1.8 an UPDATE or DELETE on issues reports a fk_comp_snap_issue violation, 2.2.0's pull fails, and the v1.3.0 bd fails with the engine error that BD_IGNORE_SCHEMA_SKEW=1 does not get past. History keeps the descending column: bd init commits each migration separately, so the commits from before 0071 still hold it. On 2.1.8 and 2.2.0, reading compaction_snapshots at one of them (AS OF, dolt_history_compaction_snapshots, dolt_diff_compaction_snapshots) fails, and so does any dolt diff with one as an endpoint, even a diff limited to issues. issues AS OF, dolt_history_issues and dolt_diff_issues work. The up.sql header, the CHANGELOG and docs/architecture/dolt.md say so. Migrations take slots in landing order, and versions must stay gap-free (TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion). #6661 also numbers a migration 0071; whichever lands second renumbers. Tests: TestLatestVersionIncludesMigration0071 is the slot pin, and main's TestLatestVersionIncludesMigration0070 is deleted, as each earlier pin was when the next migration landed. A pure-Go test checks the frozen text and the down file, and a dolt CLI test checks the bundle leaves no descending column. An embedded test covers the upgrade from v69 through 0070 and 0071, a replay, the foreign key's cascade, resume after the add, a store without the table, and a fresh store. cli_prepared_ddl.go's inventory justifies the prepared ADD/DROP INDEX, measured to execute through the CLI batch path on 2.1.8 and 2.4.1. The example modules replace github.com/steveyegge/beads with the repo root, so they have to follow its dependency bump. On the iteration-2 head 72f5a6794e, scripts/build-examples.sh failed both with "updates to go.mod needed". go mod tidy in examples/library-usage and examples/bd-example-extension-go moves them to the root's versions (driver v2.4.1, dolthub/file-locks v0.1.2 and the go-deps group). Every requirement they share with the root go.mod now matches it except golang.org/x/exp, which both already pinned to a newer version on main. The script now prints "2 example module(s) type-check cleanly". Minor and nit findings: - The proxied-server old-version warning scopes each reason to the releases it covers, without naming a schema version: the CALL DOLT_RESET('--hard') regression measured on 2.3.0 and 2.3.1 (2.3.2 through 2.4.0 unmeasured, 2.4.1 measured clean), the join mis-plan before 2.4.0, and "table has unknown fields" before 2.3.3. A 2.4.0 user now reads why 2.4.1 is still recommended. TestWarningMessage pins all three; dropping the DOLT_RESET clause fails it. - scripts/ci/install-dolt.sh no longer says 2.4.1-engine storage is unwritable by 2.2.0. It names the join bug and the split between the current root, which 2.1.8 and 2.2.0 read and write, and the commits from before 0071. - scripts/test-git-remote.sh keeps its dolt >= 2.2.0 floor, backed by a 2.2.0 run of its write, push, clone and pull steps. - The dated cross-version measurements live in docs/architecture/dolt.md; policy.go and troubleshooting.md point there. - The CHANGELOG scopes the fk_comp_snap_issue violation to 2.1.8. - The localdoltserver port comment covers 2.4.1 as well as 2.2.0; both print "Port N already in use." on a held port (measured). - TestEmbeddedFirstMintOnEmptyHistoryIsRevisionOne pins that revisions count per issue. - docs/architecture/dolt.md says 2.4.1 is the only release after 2.3.1 measured for the DOLT_RESET regression and that 2.3.2, 2.3.3 and 2.4.0 have not been. It had said no release after 2.3.1 was, right under the 2.4.1 0 / 250 row. - cli_migrations.go puts the parity oracle's green run against the then-pinned 2.2.0 sql-server in the past tense. Probed 2026-10-18, a prepared ADD COLUMN vanishes on the 2.2.0 CLI and lands on 2.4.1, so on the 2.4.1 pin the oracle cannot catch a dropped override; the comment names the two binary-free tests that still can. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… that makes versioned beads usable (gastownhall#6138) (gastownhall#6661) * test(conformance): author R7.1 as-of-read conformance contract Adds a new Phase 0 conformance contract for R7.1 (as-of reads, gastownhall/beads#6136, design doc #5898 rev 9) -- no fixture existed for this anywhere in backend/conformance/, so this is authored from scratch, not un-skipped. AsOfReadFixture supplies three hooks: Resolve (the read under test), MintAt (seeds a version at a controlled accept-time), and MakeUnanswerable (arranges a Gone/Unknown refusal independently of RetentionFixture/EpochFixture's own removal machinery, since R7.1's refusal is a sibling contract to R17/R20, not a dependent of them). Five Run* functions cover the bead's five required-coverage points verbatim: - selector accepts either an instant or a version address, and both name the same answer when they resolve to the same version; - resolution returns the latest version at-or-before T, with a version accepted after T strictly excluded even when close by; - a served result reports the exact address it served; - an unanswerable read refuses as a typed Gone*/Unknown outcome with a reason, and never substitutes a neighboring version, the nearest surviving version, or current state -- asserted directly by requiring Address == "" on every refusal; - local completeness only (TC3): a lineage minted into one of two stores resolves there and refuses Unknown (FR-06) on the store that never received it, asserting nothing about agreement between the two. The file's doc comment states the Memory-plane-consumer-policy non-goal explicitly (closed-before-T boundary, sibling exclusion, supersession exclusion are consumer policy per #5877, not part of this primitive) so the gap reads as deliberate scope, not an oversight. Wired onto all three storage legs (dolt, embeddeddolt, uow) with unconditional "not implemented" stubs rather than partial-real hooks, so every case fails via MintAt on its first fixture call -- deterministic RED with no risk of an accidental pass, per the precedent set by be-x5jqd.1. Sentinel error messages reference be-x5jqd.5, the implementation child this suite is written ahead of. TestEveryLegWiresEveryRoleContract requires zero waivers: all 5 new entrypoints are fully wired (not nil) on all three legs. Branch cut from the rebased be-2h167 head (5fdfb92fe5). Verified via go build ./..., go vet ./..., gofmt -l, and go test -tags cgo across all three legs: all 5 new subtests (8 counting the 4-way Gone/Unknown table) FAIL for the documented reason, TestEveryLegWiresEveryRoleContract passes cleanly on all three legs, and TestVersionedHistoryPhase0RunsInFullSkipMode is unaffected. Bead: be-x5jqd.2 * fix(history): refuse metadata integers binary64 cannot hold exactly (refs be-wdlod, #6358 follow-up) canonicalDurableState canonicalizes numbers per RFC 8785 (JCS), which renders every number as an IEEE-754 binary64 double regardless of magnitude. An integer-valued metadata literal past 2^53-1 therefore rounds to a DIFFERENT VALUE on the way into durable_state -- not a formatting change, a value change -- which can collapse two distinct issue states onto one durable_state and therefore one content token. refuseUnrepresentableIntegers is the fix: an admission gate, one layer above the JCS step, that parses each JSON number literal exactly with math/big (never float64 -- float64 rounding is the exact thing being guarded against) and refuses whenever the literal's VALUE, not its spelling, is an integer whose magnitude exceeds 2^53-1. Value-not-form matters because the first cut of this gate skipped any literal containing '.', 'e', or 'E' outright, reasoning that non-integer forms round-trip losslessly -- true for genuinely fractional literals, but not for an integer VALUE spelled in decimal or exponential form: QA found that 9007199254740993.0 and 9.007199254740993e15 walked straight past that first gate and canonicalized to the same colliding target as the bare literal. The predicate now inspects the value via big.Rat.SetString/.IsInt, so all three spellings are refused alike. 1e300 is refused too, no notation carve-out: it denotes the integer 10^300, and binary64 spacing near that magnitude is roughly 2^248 -- vastly wider than the collision window at the 2^53 boundary this gate exists to close. Admitting that spelling while refusing 9007199254740993 would be the same defect with a bigger window (mayor's ruling, citing this collision-window argument as decisive). Non-integer values stay admissible past the bound (1.5e300 is fine): ES6 shortest-round-trip formatting is a bijection on doubles, so two non-integer literals collide only if they already denoted the same double before this gate ever ran, and a fractional literal never carried a promise of exact decimal storage the way an integer -- an id, a count, a timestamp -- carries a promise of exactness that silent rounding would corrupt. jcsCanonicalize is canonicalDurableState's RFC 8785 step pulled out on its own, below the gate rather than behind it, because refusing 1e300 puts the admission policy at odds with one of this store's own spec- conformance fixtures: testdata/jcs/input/values.json, one of the 10 official RFC 8785 vectors shipped verbatim from the spec's reference suite (not authored here), itself contains 1E30. RFC 8785 conformance is a claim about the canonicalizer, not about this store's admission policy, so TestCanonicalDurableStateIsJCS now runs all 10 shipped vectors -- values.json included, still asserting 1E30 folds to 1e+30 per spec -- through the ungated jcsCanonicalize, while its two local ad hoc cases keep exercising the full gated canonicalDurableState, since neither conflicts and both are more faithful to production traffic that way. The gate's own refusal of that magnitude is pinned separately, on its own terms, in version_history_integer_admission_test.go. Severity is MINOR, not MAJOR: Dolt's JSON column type already renormalizes metadata to float64 on every read regardless of this gate (measured on dolt 2.2.3: 9007199254740993 reads back as 9007199254740992, 1e300 as 1e+300), which converges two distinct in-memory states to one stored state before any version row is minted. The collision this gate closes is therefore unreachable through normal bd update traffic on this backend; it stays real for off-path writes -- bd sql, a hand-written JSONL import, or a TEXT-column backend -- which is why this landed as a follow-up rather than gating Phase 2 itself. Verified clean: a full module compile; static analysis over the storage tree; the complete issueops package suite (260 subtests); the schema package suite; and the broader storage tree, apart from one dolt-package test that fails identically against the pre-this-diff baseline (a Dolt server port collision with a concurrent session's process on this host) -- confirmed pre-existing and environmental, not caused by this change. * feat(issueops): implement R7.1 as-of read's store-layer primitive (be-x5jqd.5) Turns backend/conformance/versioned_read_contract.go (authored RED in 6aefdce60, gastownhall/beads#5898 rev 9, #6136) towards GREEN. This commit lands the shared production seam; wiring the three per-leg fixtures (dolt, embeddeddolt, uow) onto it is a follow-up commit. asof_read.go (new): AsOfReadInTx resolves an AsOfSelector (an instant or a previously-served version address) to one issue_versions row -- the latest version accepted at or before T, everything later strictly excluded -- and reports either its state and address, or a typed refusal (gone-retention/gone-erasure/gone-reorganization/unknown) with a reason. storeID is accepted only for signature parity with the fixture hook shape (Design D: the conformance suite's own ad hoc dispatch string selects among per-leg isolated test stores; issue_versions carries no store_id column, matching CurrentEpochInTx's precedent). AsOfRestriction is string-backed, unlike R20's int-backed EpochRestriction, because it round-trips directly through the new removed_restriction column with a plain cast. Migration 0069 adds issue_versions.removed_restriction VARCHAR(30), nullable (NULL = live, never a stored value). Sits alongside removed_at/ removed_reason (migration 0067, virgin until this slice); AsOfReadInTx only READS all three -- a future R17 is the real writer via hold/remove/ erase primitives, no collision. Guarded PREPARE + CLI direct-DDL override + schema_test.go hygiene entries, all modeled on 0068's pattern; TestLatestVersionIncludesMigration0068 is superseded per the one-pin-at-a-time convention. version_history.go: splits RecordVersionInTx into a versionedHistoryEnabled- gated wrapper and a new exported RecordVersionAtInTx, both delegating to a shared recordVersionAtInTx(..., at time.Time) body. RecordVersionAtInTx is test-support only -- ungated, caller-chosen timestamp -- so an as-of- read fixture's MintAt hook can mint version rows dated in the past without flipping a store's history-enabled flag. No behavior change for existing RecordVersionInTx callers. The new/moved code shifted which function each completeness guard sees as the enclosing write site, so all three needed updating, not bypassing: - row_lock_guard_test.go's funcNameExemptions key moves from RecordVersionInTx to recordVersionAtInTx (the write's new actual enclosing function), reasoning extended to cover both callers. - journal_completeness_test.go's beadDMLExemptions and version_completeness_test.go's versionExemptions each gain a RecordVersionAtInTx entry mirroring RecordVersionInTx's own (test- support twin, no production caller, no mutation of its own to journal/mint beyond the seam itself). Also fixed a latent test-helper gotcha found while writing the 0069 Dolt-CLI test: queryDoltCSV trims the whole `dolt sql -r csv` output before parsing, so a row whose ONLY selected column is NULL renders as a bare blank line that strings.TrimSpace silently swallows when it's the trailing line, collapsing "one row, NULL value" into "zero rows". Fixed by selecting a non-NULL anchor column (issue_id) alongside the column under test. Verification performed: full module compile and static analysis, gofmt clean; the complete internal/storage/schema suite with the real-Dolt-CLI lane enabled; and the complete internal/storage/issueops suite, including every completeness/row-lock structural guard -- all clean. * feat(issueops): wire dolt, embeddeddolt, and uow onto R7.1 as-of read (be-x5jqd.5) Turns backend/conformance/versioned_read_contract.go fully GREEN (authored RED in 6aefdce60, gastownhall/beads#5898 rev 9, #6136): this follows up on 4da98a9a8's shared production seam by wiring all three storage legs' AsOfReadFixture (Resolve/MintAt/MakeUnanswerable) onto issueops.AsOfReadInTx, per that commit's own stated plan. Each leg's asOfReadHarness is Design D's dispatch table: the conformance suite invents storeID strings to select among N isolated stores, and isolating them is entirely the harness's job -- AsOfReadInTx itself stays storeID-oblivious. The three legs differ only in how they get that isolation cheaply: - dolt: one shared testcontainer, N randomly-named databases - embeddeddolt: N fully independent on-disk databases - uow: one shared dolt sql-server subprocess (NewDoltServerUOWProvider's adoption semantics collapse repeat calls against the same root dir onto the same process), N randomly-named databases All three harnesses are Fatalf/Skip-free below their own TestAsOfReadContract body: AsOfReadFixture's hooks carry no *testing.T of their own and run from inside t.Run subtest closures (sometimes nested two deep), where FailNow/SkipNow would panic with "subtest may have called FailNow on a parent test". Failures instead flow back as a plain error into conformance.RunAsOfReadXXX, which Fatalfs correctly on the subtest's own goroutine. Two small companion fixes surfaced while wiring the legs on: - issueops.asOfVersionAddress -> AsOfVersionAddress (exported): each leg's MintAt needs to build the exact token its own RecordVersionAtInTx write will resolve against, from a different package than issueops. - recordVersionAtInTx now truncates `at` to whole seconds before writing it to issue_versions.change_at (DATETIME, migration 0067). Measured on dolt 2.2.3: the column ROUNDS a sub-second value rather than truncating it, so a change_at of 13:32:04.77 lands at 13:32:05 -- strictly later than the instant it was meant to record. That breaks resolveAsOfRevisionInTx's "at or before T" comparison (asof_read.go) for any T between the true instant and the rounded- up one. This is a production correctness fix, not test-only: RecordVersionInTx hits the identical hazard on every real time.Now().UTC() call whose nanosecond component rounds up. Verification performed: - uow: TestAsOfReadContract green standalone (5 subtests, 4 nested restriction variants) and the full uow package green in isolation (673s, includes pre-existing TestReleaserContract and everything else). A `go test ./internal/storage/...` full-tree sweep flagged uow FAIL via a 600s hang inside TestReleaserContract's migration lock -- traced to cross-package parallel resource contention from running the whole storage tree's dolt-sql-server-spinning suites concurrently, not a regression: the same test is clean when the package runs alone. - embeddeddolt: TestAsOfReadContract green (22.89s, all subtests and all 4 restriction variants). - dolt: skipped on this host -- no Docker for the leg's testcontainer, the same pre-existing skipIfNoDolt gate the whole dolt package already runs under, unrelated to this change. - TestEveryLegWiresEveryRoleContract and TestEveryContractImporterInTheStorageTreeIsRegistered both pass for all three legs. - gofmt clean; whole-module build and vet clean. Bead: be-x5jqd.5 * feat(versions): bd versions + a config switch for versioned history (refs be-hs42e.6.2) Versioned history has been buildable but not usable: migrations 0067+ create issue_versions, and the Phase 2 writer fills it, but SetVersionedHistoryEnabled was a Go method nothing in cmd/bd ever called. There was no supported way for a person to turn the feature on, and no way at all to read it back without raw Dolt SQL. This adds the switch and a reader. - versioned-history.enabled (env BD_VERSIONED_HISTORY_ENABLED), default off, applied at the top of wireStorageDecorators. It MUST run on the raw store: the capability is a type assertion and no decorator forwards it, so applying it after a wrap would silently leave history off while the config said it was on. TestVersionedHistoryConfigAppliesToTheRawStore pins the ordering, and fails rather than skips if a decorator ever starts forwarding. - storage.VersionLister + issueops.ListVersionsInTx over issue_versions, on the dolt and embeddeddolt legs. A narrow capability rather than a Storage method, following ExternalRefHistoryQuerier: a backend that cannot know must be able to say so instead of answering "none". - bd versions <id>, with three distinguishable outcomes rather than two. Off, unsupported, and empty are different answers with different fixes; an empty list is a claim about the bead, and returning it for the other two would be a wrong answer rather than an empty one. The four removal restrictions render as four sentences, and unknown (no lineage knowledge here) is not gone. - REV is printed as a local ordinal with a footer saying so. It is deliberately NOT presented as a citable address: AsOfVersionAddress mints over the ordinal, two clones can both hold revision 8 of the same bead, and the durable version_id primary key has not landed. An address printed now would break every citation once it does. - bd version <id> now points at bd versions <id> instead of printing bd's own build and looking like the bead has no history. Bare bd version is unchanged. No migration: 0067/0068/0069 already carry every column this reads. Verified on a scratch store: create + 2 updates + close with the flag on lists 4 attributed versions; with the flag off, 0 rows in issue_versions and the command refuses naming the key. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(versions): emit local_revision, not revision, in --json (bee's #5898 consumer read) types.Issue already ships `json:"revision"` (types.go:1206) and it is the row-lock CAS token — an unrelated value, and a string where this one is an int64. Emitting "revision" from the versions payload would put two meanings and two types on one key in the place machines read: the `bd version` collision again, with worse consequences, since a script that learned one shape gets the other and cannot tell. local_revision also carries the non-citability with the value rather than only in a footer no script parses, and needs no rename when version_id lands beside it. Raised by @bee-ghosttrack's consumer read on #5898, who reported a couple of hundred script files parsing `bd … --json` — this is the part of the surface they would actually touch. Pinned by TestVersionsJSONDoesNotCollideWithIssueRevision. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(versions): make the advertised switch actually switch it on (#6661 review) @bee-ghosttrack's blocking finding: the help text and the off-refusal both told the user to run `bd config set versioned-history.enabled true`, and that command did not turn the feature on. The key is not yaml-only, so `bd config set` routed it to the workspace DATABASE; both readers called config.GetBool, which is viper (yaml + env) only. The user ran exactly what they were told, was told it was set, and recording stayed off — configured on, actually off, one layer up from the decorator-ordering hazard this command already guards. Takes bee's option (b): read the switch from the store's own config, where `bd config set` already writes it. That also makes recording a property of the STORE rather than of whoever is calling, which is what closes finding 2 — two clients of one sql-server can no longer disagree about whether a write is recorded. The two planes are OR'd rather than ranked. The hazard is a write that fails to record, never one that records when it needn't, so either saying yes is enough and neither can silently switch the other off. BD_VERSIONED_HISTORY_ENABLED still works for a one-off run. A store with no settings plane (proxied, no-db) falls back to viper instead of failing the command. Also from that review: - finding 3: the read no longer refuses just because recording is off. A store that recorded for a month and was switched off HAS versions; refusing made a claim about the store from a fact about this invocation's config, which VersionLister's own doc says are independent. Rows are listed either way, with a note when recording is currently off; refuse-with-remedy only when off AND empty. - finding 4: an unresolved id with no versions is "no such bead", not "none yet". Falling through on an unresolved id stays right — a deleted bead can still have versions — but only until the answer is empty. - finding 5: the ordering test's escape hatch is t.Fatal, not t.Skip; a skip returned before the assertion that actually guards the ordering. The storage_chain.go doc cited a test name that never existed. version_lister.go promised a list of compile-time assertions that was not there; the assertions now exist in each leg's own package, where they can compile. - `versioned-history.` is a recognized config prefix, so the set no longer prints "not a recognized config key" immediately before confirming the set. Test: TestVersionedHistorySwitchRoundTrip_Embedded drives the real `bd config set` through to a real `bd versions` against a real store, with BD_VERSIONED_HISTORY_ENABLED cleared so a pass proves the store setting carried it alone. This is the round trip bee asked for, and it is the only shape that could have caught the original defect — a fake-backed unit test cannot see a disagreement between two real planes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(versions): name what the OR'd switch planes cost (#6661 review) @bee-ghosttrack, round 2: with the two planes OR'd rather than ranked, the consequence worth naming is that once the store setting says on, BD_VERSIONED_HISTORY_ENABLED=0 cannot countermand it for a single run. The help now says so, and says where to turn it off instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(versions): gate the wiring store read on the capability, not a recover (#6661 review) @bee-ghosttrack's round-3 blocking finding. wireStorageDecorators reads the versioned-history switch off the raw store on every bd invocation, and did so before anything established that the store could use the answer. cmd/bd's own fakeProbingDoltStore embeds a nil storage.DoltStorage, so the promoted WorkspaceConfig SIGSEGV'd at wiring time -- and a panic takes the whole test binary down, which is why one unguarded read showed up as two red CI steps (Test (macos-latest), PR Core (wrapper timing)) rather than one failed test. Takes the fix bee prescribed: assert storage.VersionedHistoryConfigurer first and read the store plane only when the store could act on the answer. The previous round fixed this with a recover plus a WorkspaceConfig on the fake, and left a comment arguing that no capability assertion could work. That argument was wrong, and wrong in a specific way worth recording: it reasoned about asserting WorkspaceConfig, which IS declared on storage.DoltStorage and so matches every store including the nil-embedding fake. bee proposed asserting VersionedHistoryConfigurer, which is a different interface -- SetVersionedHistoryEnabled is NOT part of DoltStorage, so the fake does not promote it and does not satisfy it. The comment rebutted a fix that had not been proposed. It now states what is actually true. So the fake goes back to byte-identical with the pushed head: the wiring fix fixes that test without touching it, as bee said it would, and the fake keeps the "only the methods below may be called" constraint its own doc asserts. The recover stays, as a backstop rather than the guard. It covers what the assertion does not: versionedHistoryEnabled is also called from `bd versions`, where the read is the point and no capability gate precedes it, and a store that DOES implement the capability can still have a half-built settings plane. The viper plane is still read first and unconditionally, so a set-but-unsupported store still reaches applyVersionedHistoryConfig and still gets its warning. Only the store-plane read is gated. The one case that loses a warning is a store whose own settings plane says true but which lacks the capability -- and `bd config set` could not have written that plane on such a store to begin with. Tests, split so each layer fails for its own reason: - TestWireStorageDecoratorsSkipsTheStoreReadForANonConfigurer asserts calls == 0, not merely that it survived. "It survived" is what the recover delivers too, which is how this regressed the first time. - TestWireStorageDecoratorsSurvivesAStoreThatCannotAnswer keeps the recover's case, now on a store that IS a configurer so the guard lets it through. - TestVersionedHistoryEnabledForWiringReadsTheStoreWhenItCanRecord pins that the guard did not stop reading the plane finding 1 existed to start reading. Mutation-verified both ways: removing the guard fails the first test on calls=1/want=0 while everything still "passes" by surviving; removing the recover leaves the first test green and fails only the second. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(versions): name the embedded round-trip so CI selects it (#6661 review) @bee-ghosttrack's round-3 finding 2. The round-trip test that proves the two config planes agree ran only on the author's machine. .github/scripts/embedded-test-shard.sh discovers what to run with `grep -rh '^func TestEmbedded' cmd/bd/*_embedded_test.go` and validates manifest entries against ^TestEmbedded[A-Za-z0-9_]+$. TestVersionedHistorySwitchRoundTrip_Embedded matched neither, so the only lane that sets BEADS_TEST_EMBEDDED_DOLT=1 for cmd/bd never selected it; the generic Test jobs run without that env, where the test's own guard skipped it. Skipped and passed look alike from outside, which is what made it invisible. Renaming is the whole fix -- a test absent from the shard manifest still gets a shard from the fallback distribution. Verified by running the script's own selector over the tree and confirming the new name is discovered. The rationale is now a comment on the test, because the old name reads more naturally and nothing else in the file explains why the prefix is load-bearing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(versions): drop the dead fixture, name the empty arm (#6661 review) @bee-ghosttrack's round-3 finding 3. TestVersionsRefusesWhenFlagOff built a backend holding one recorded version, handed it to nothing, and ended in `_ = backend`. The fixture was load-bearing for the assertion the test was named after -- that the read was refused BEFORE the backend was consulted. Finding 3 removed that behaviour on purpose, so the assertion went with it; the fixture stayed behind, unused, under a name still promising the old contract. Renamed to TestVersionsOffAndEmptyRefusesWithRemedy for what it actually pins, moved beside TestVersionsOffButRecordedStillLists so the two read as the pair they are -- recording off decides the FOOTER, never whether to read; off with rows lists them, off and empty is the one case that refuses -- and the dead fixture is gone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(proxy): give bd versions a capability row, a typed refusal (#6661) main's proxied-server capability registry (#6582) requires every command path to carry a row, and TestProxyCapabilityRegistryCoversCommandTree fails for `bd versions`, which this PR adds. It is refused, reason unimplemented, rather than permitted. It is a pure read (issueops.ListVersionsInTx in one read transaction), so nothing about it is unsafe on a shared backend and "design" would be wrong. But it reaches the backend only through the optional storage.VersionLister, which the dolt and embedded stores implement and the uow provider does not. Permitting it would open the proxied provider in the root pre-run (starting the proxy and dolt) and then fail untyped at errVersionsUnsupported. The row refuses with proxy.versions.unsupported before any side effect, and its tracking names the missing piece: a VersionLister over the proxied uow provider (tracker #6132). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(uow): register verified shutdown cleanup in TestAsOfReadContract (#6661) main's TestEveryServerFixtureRegistersVerifiedCleanup (#6441) requires every server fixture to use verifiedShutdownCleanup(t, storeRootDir) instead of calling proxy.Shutdown directly, so a shutdown that refuses cannot leave a live dolt sql-server behind a green run. TestAsOfReadContract still had its own proxy.Shutdown cleanup that only logged the error. The cleanup is registered at the same point, so the LIFO ordering the harness relies on (every provider closed before the shared server stops) is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * style(schema): gofmt cli_migrations.go after the 0070 renumber The rebase onto upstream's 0069_widen_issue_versions_datetime_precision (#6675) joined its const and the renumbered 0070 comment without the separating blank line, which make fmt-check rejects. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(history): stop flooring change_at now that 0069 widened it (refs be-hs42e.10) recordVersionAtInTx carried `at = at.Truncate(time.Second)`. That was correct while 0067's plain DATETIME was in force: Dolt's datetime(0) does not truncate sub-second input, it ROUNDS half-up, so a change_at could be stored strictly LATER than the instant it recorded and break AsOfReadInTx's "latest version accepted at or before T". Flooring first left nothing to round. Migration 0069 widened change_at and removed_at to DATETIME(6), which removes the rounding entirely and makes the floor actively harmful — it threw away the microseconds the widening exists to keep. Two versions minted in the same second collapsed onto one stored value and stopped being distinguishable by change_at, which defeats --at, the only PORTABLE selector the read surface offers while revision stays a per-store ordinal and no durable version address has shipped. This was measured, not inferred. On a store carrying both the widening and the floor, four versions minted inside one second all read back 15:40:38.000000: the column could hold microseconds and the writer refused to supply them. Two correct fixes cancelling each other, and only the second one was visible. removed_at needs no matching change: MarkLatestVersionRemovedInTx already passes time.Now().UTC() straight through and was never floored. Audited rather than assumed. Pinned by TestRecordVersionKeepsSubSecondChangeAt (embeddeddolt), which mints two versions 500ms apart inside one second and asserts both that the fractional part survives and that the two differ. Verified it FAILS with the floor restored — reporting exactly the 11:04:07.000000 collapse — and passes without it, so it is a real guard rather than a test that passes either way. The column's own half of the contract stays pinned by TestMigration0069ChangeAtSurvivesSubSecondPrecisionThroughDoltCLI. Also drops this branch's own tx-minting guard commit, which upstream landed independently as #6833. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(feat): red — Activate versioned history in every store and provider factory, each store reading its own #6661 switch (stacked on #6661) (refs be-qxq70) Tests first, all failing on the right reasons at fb6e219d6a (#6661's head): - D1: on real embedded stores a routed update, a routed close and `bd create --repo` into a rig whose OWN row is on each gain 0 issue_versions rows, want 1; the control (a write inside the rig) gains 1. - D3: BD_VERSIONED_HISTORY_ENABLED=1 records into no routed store, and =0 is shown not to switch off a store whose row is on. - D4: TestEveryStoreConstructionActivatesVersionedHistory flags all 9 store and provider factories, and its mutation probe reports "probed 0 of 9". - wiring: wireStorageDecorators still reads the store's row (1 read) and switches it on; activation belongs to the factories. - internal/versionedhistory (does not exist yet) and the doctor repair opener: the resolver, the provider read (K1), the error-vs-absent diagnostics and the shared-activation requirement. * feat: green — Activate versioned history in every store and provider factory, each store reading its own #6661 switch (stacked on #6661) (refs be-qxq70) Stacked on #6661 (fb6e219d6a). #6661's plane and approved commits are unchanged: the switch stays a row of the store's own config table, OR'd with viper, and `bd config set versioned-history.enabled true` still writes that row and not config.yaml. The defect: applyVersionedHistoryConfig ran only from wireStorageDecorators, so the one store a command opens for its own workspace was activated and every store built by newDoltStoreFromConfig (prefix-routed update/close, `bd create --repo`, the direct-mode open) was not. With the switch on they recorded no issue_versions row while the command reported success. - Activation moves to where a store or unit-of-work provider is constructed (the store_factory.go/_nocgo.go twins, uow_factory.go's two provider constructors, the personal-migration planning store, and bd doctor's repair opener), on the raw store, before anything can wrap it. wireStorageDecorators no longer activates, so each store's row is read once per open. - One resolver, in internal/versionedhistory, reachable from doctor/fix which cannot import package main. #6661's semantics are preserved: one key spelling, viper first, then the capability check, then the row read, with the recover backstop. The behavior-preserving refactor of #6661's versioned_history_switch.go / storage_chain.go is the only edit to files #6661 introduced; the resolver tests moved with the code, assertions unchanged. - K1: a provider has no DoltStorage, so its row is read through a unit of work (NewUOW + ConfigUseCase().GetConfig) at construction: a pooled connection, one SELECT, rolled back. The constructors have already run initSchema, so this starts no server and creates nothing. It does not fall back to viper alone. - A row read that errors resolves to off but is reported under BD_DEBUG; an absent row stays silent. - Docs (configuration.md), a CHANGELOG entry, and a hint at `bd config set ... true` time that the setting replicates and is single-writer only. The bazel-sync run also wanted unrelated BUILD entries for files that already exist at #6661's head (versions.go, versioned_read_contract.go, ...); they are not part of this change and are left out. * test(feat): green — a served mutation records from the provider's own row, on a real server (refs be-qxq70) K1 is the one place the resolver cannot ask a DoltStorage: `bd serve` against a server-mode workspace writes through a unit-of-work provider, so its flag is read through NewUOW + ConfigUseCase().GetConfig at construction. The fakes in internal/versionedhistory prove the read; this proves it WORKS against a real Dolt server at that moment (pool open, database selected, schema migrated). Two server-mode workspaces on the shared test container: the one whose own row says on records a served HTTP mutation (+1 issue_versions row), the one with no row records none. Measured both ways: passes with the provider activation in place, and fails ("added 0 issue_versions row(s), want 1") with it deleted from both provider constructors in uow_factory.go. Proxied lane only (BEADS_TEST_PROXIED_SERVER=1 BEADS_TEST_ENV_RUN_DOLT=1 TESTCONTAINERS_RYUK_DISABLED=true), like TestServeActivatesTheEventsJournal, so it skips in a plain make test. * test(feat): red — #6661 review round, small items: findings 2, 4, 5, 6 and 8 Tests for the small findings in the second review round on #6661. - 2: `bd versions` must decide "recording" from the store's own setting. BD_VERSIONED_HISTORY_ENABLED=1 with the store's row unset and nothing recorded must refuse, not answer "none yet"; the help text must not offer the variable as a per-run switch for a read. - 4: `bd versions --json` is one object, {"versions": [...], "recording": bool}, with [] rather than null when nothing is recorded. - 5: AsOfReadInTx reports any stored removed_restriction outside its four values, "live" included, as unknown. - 6: the 0070 header spells the restriction vocabulary with the underscore spellings the code stores and compares. - 8: `bd version <arg>` exits 1 and points at `bd versions <arg>`. This one pins behaviour the branch already has, so it passes at red; it was shown to fail with the guard removed. Item 7 is a comment-only fix and has no test. * feat: green — #6661 review round, small items: findings 2, 4, 5, 6 and 7 - 2: `bd versions` reports the store's own setting. It read the environment and config.yaml as well, so BD_VERSIONED_HISTORY_ENABLED=1 made a store that never recorded answer "No versions recorded yet" instead of refusing with the remedy. It only reads, so those planes cannot make the store record. The "for one run" hint is dropped from the help and the refusal, since it could only ever produce the wrong answer. - 4: `bd versions --json` is always {"versions": [...], "recording": bool}, with [] rather than null when nothing is recorded. Previously a bare array, or null, and no recording flag. - 5: AsOfReadInTx reports a stored removed_restriction outside its four values, "live" included, as unknown instead of passing it through. - 6: the 0070 header and its test use the underscore spellings the code stores and compares. 0070 is unreleased, and this changes its content hash. - 7: comment only. DATETIME(6) still rounds to the microsecond; the comment said 0069 removed the rounding entirely. * test(fix): red — #6661 number admission: fractions past the bound, exponent cost, pre-enable scan Tests for the review round on the number-admission gate, written before the change: - a fraction whose nearest double is at or past 2^53 is refused (9007199254740993.5, 9007199254740994.5, 9007199254740991.5), and the gate is closed under its own canonicalization, checked as a property over a corpus - classification depends on magnitude, not on the size of an exponent: 1e100000000 and -1e400 are refusals, 1e-100000000 and 1e-400 are admitted, and allocation does not grow with the exponent - the sentinel's text names the I-JSON exact-integer range - CheckMetadataVersionable agrees with the mint, and FindUnversionableMetadata finds what the mint would refuse and skips what it never versions - bd config set versioned-history.enabled true refuses, writing nothing, over rows the mint would refuse, and false never scans Guards that pass before and after by design: the verdict on every literal as the store returns it, the mint's refusal writing nothing, and, on the server and embedded legs, the store-level property that no two literals reading back as different numbers share a canonical form. Those store tests also log what each Dolt holds for a number outside the range when history is off, and pin that a later write to such a row is refused once history is on. * fix: green — #6661 number admission: the nearest-double rule, ParseFloat classification, a pre-enable scan at the switch The admission gate now refuses a JSON number literal if and only if the binary64 nearest to it has magnitude above 2^53-1, or it overflows, whatever the literal's spelling: - a fraction that rounds to or past 2^53 (9007199254740993.5, 9007199254740994.5, 9007199254740991.5) is refused, so the gate is closed under its own canonicalization - literals are classified with strconv.ParseFloat, linear in their length, so 1e1000000 no longer builds a million-digit integer inside the writer's transaction; an overflow is the sentinel and a magnitude too small for binary64 is admitted; math/big is gone - the sentinel reads "number is outside the I-JSON exact-integer range (magnitude above 2^53-1)"; ErrIntegerNotRepresentable keeps its name, with a comment saying why - ordinary fractions such as 0.1 stay admitted; no verdict on a value the store hands back changes The header now says what the mint's refusal is: an integrity backstop inside the writer's transaction, not an admission policy for metadata. bd config set versioned-history.enabled true now checks the store first. It reads every issue the mint would version, runs the mint's own function over each one's metadata (issueops.CheckMetadataVersionable, through issueops.FindUnversionableMetadata), and refuses, writing nothing, while any is refused, printing the count, the ids and the fix. There is no override; setting it false never scans. The environment and config.yaml planes do not pass through the command and rely on the refusal at write time. Also: docs and a CHANGELOG entry, and comments in the existing admission tests that described the old rule. * test(fix): keep the exponent-cost allocation test stable under the race detector TestNumberAdmissionAllocationsDoNotGrowWithTheExponent compared two independently averaged allocation counts with a strict >. Under -race sync.Pool drops one Put in four at random, and the refusal's fmt.Errorf takes its printer from a pool, so a call now and then allocates one more than it would. The test failed on most runs of `go test -race -short`, the flag set of the required lane, and never without -race. That noise only ever adds allocations, so compare the fewest allocations over many single-call samples instead. The comparison stays strict, and it still fails on the exact big.Rat gate this test exists to keep out (49 allocations for 1e1000000 against 36 for 1e400). The doc comment no longer claims the count is deterministic under -race. * test(fix): red — set-many skips the pre-enable scan; pin what the scan reads bd config set-many versioned-history.enabled=true switches versioned history on with no pre-enable scan: only bd config set makes it. With a row holding a number outside the I-JSON exact-integer range the setting is turned on and the next write to that row fails. The new embedded test drives the real verb over such a row and expects the whole batch to be refused, writing nothing. The scan's own embedded test only used open issues, so deleting AllFlag or IncludeAllTypes, or replacing the unlimited Limit, left it green. It now adds a closed, a pinned and a gate offender, and a second test imports more rows than one default page and expects every one of them counted. * fix: green — bd config set-many runs the pre-enable scan for versioned-history.enabled bd config set refuses to turn versioned history on while an issue holds metadata a version could not record. bd config set-many writes the same setting through a validation loop of its own and made no such check, so it switched history on over a row whose next write then failed. It now runs the same check for that one key inside its validation loop, before any pair of the batch is written, so a refusal stores nothing. The check reads through the accessor it already used on both routes: the store the command has opened on the direct route, the provider on the proxied one. * chore: strip internal tracker ids from the comments and tests across #6661's range Comment and test-text changes only; no behaviour changes. Across every commit from the merge-base with upstream main to here, the comments and tests named internal tracker ids (one bead id in eleven comments and in one test failure message, an example id in the `bd version` guard's comment, and an internal decision's attribution in the huge-exponent admission test). They now cite gastownhall/beads#5898 and #6136 only, which is what a reader of the public branch can follow. The 0070 migration's header comment is one of the edits. That migration is new on this branch (it does not exist on upstream main), so the change is not an edit to a shipped migration, but it does change the file's content hash; the schema tests that compute hashes are self-consistent. Text that already exists on upstream main is left as it is, even where it mentions an id: this commit does not rewrite lines the range did not add. * chore(bazel): bazel-sync (gazelle) for the #6661 range * fix(bazel): give fix_test the store.go its activation guard parses TestVersionedHistoryDoctorRepairOpenerUsesTheSharedActivation parses store.go from its working directory. `go test` runs in the package directory, so the file is there. A Bazel test only sees its declared runfiles, so the test failed with parse store.go: open store.go: no such file or directory in //cmd/bd/doctor/fix:fix_test (--config=ci) and in shard 1 of //cmd/bd/doctor/fix:fix_dolt_test (--config=doltserver), which runs the same binary through data = [":fix_test"]. Declare store.go as data on fix_test. * test(fix): red — the pre-enable scan must check the whole issue, as the mint does bd config set versioned-history.enabled true runs a check over every issue before it turns history on. The check looked at each issue's metadata alone, while the mint canonicalizes the whole issue. A gate's timeout is a time.Duration that a version holds as nanoseconds, so a gate whose timeout is past 2^53-1 ns (about 104.25 days) holds a number outside the I-JSON exact-integer range: the mint refuses every write to it, the scan never looked, and the switch could be turned on over it. - The agreement test's domain widens from metadata documents to whole issues: the metadata corpus, plus timeouts at 2500h (admitted), 2600h, 8760h and -2600h (refused), exactly 2^53-1 ns (admitted) and 2^53 ns (refused). - The scan test covers a gate over 105 days and expects the verdict to name the field, "timeout". - The mint-level refusal test covers the same gate and expects the refusal to name the field as well as the literal, for a number in metadata too. - An end-to-end test on the direct route and one on the proxied route create gates with bd gate create --timeout, expect the enable to refuse and name them, and expect the issues the scan names to be exactly the issues whose next write the mint refuses. - Three guards keep the scan's lite read from hiding a number: every column it leaves out is a string or a list of strings, nothing the mint adds and the scan does not load can hold a number, and no exported check over part of an issue exists beside the one the mint runs. Each guard is also run against shapes it must refuse, so it cannot pass by finding nothing. The new symbols (CheckIssueVersionable, FindUnversionable and the Field of UnversionableIssue) do not exist yet, so the issueops tests do not build. * fix: green — the pre-enable scan runs the mint's own check over the whole issue The check behind bd config set versioned-history.enabled true looked at each issue's metadata alone. The mint canonicalizes the whole issue, and a gate's timeout, a time.Duration held as nanoseconds, is a number outside the I-JSON exact-integer range once it is past 2^53-1 ns (about 104.25 days). The mint refuses every write to such a gate, the scan cleared the switch over it, and the first write after that failed. CheckIssueVersionable is now exactly canonicalDurableState's refusal over the whole issue, and FindUnversionable runs it over every issue the mint would version. It replaces FindUnversionableMetadata, and CheckMetadataVersionable is gone, so no check over part of an issue is exported beside the one the mint runs. A refusal names the top-level field it found the value in ("metadata", "timeout") as well as the literal, on the mint and on the scan; the field is located only after a refusal, so a write that is admitted still reads the document once. A gate timeout above 2^53-1 ns is unrecordable by policy: it is refused at the write, named by field and documented, not re-encoded. The refusal at the switch gives the fix for each field. For a number in metadata that is bd update --metadata or --unset-metadata, which works with history on or off because a version is recorded from the state after the write. For a gate timeout, which bd update cannot change, it is removing the gate with bd delete, or setting the timeout_ns column with bd sql while history is off; bd sql needs a server-backed store, and the text says so. It also says the check runs once, now: a writer that does not record (an older bd, bd sql, a pull from a clone that had history off) can add such a row afterwards, and the first write to it then fails with the same refusal. Making the check and the write of the setting one transaction would narrow that window, not close it. Corrected in the comments, the docs and the changelog as well: an import is not a path that skips the mint, since it goes through the same batch create; and Dolt's JSON column collapses duplicate keys when it stores a document, so on a Dolt store neither the scan nor the mint can see one, and the duplicate-key refusal is a defence for a backend that keeps them. * test(fix): red — the listing must answer as the as-of read does; the SDK opens must be accounted for Three review findings on the versioned-history change and one wording fix, tests first. - A removed version's restriction. AsOfReadInTx answers a stored value outside the four-value vocabulary (a NULL or empty column, "live", a hyphenated or arbitrary string) as unknown, but ListVersionsInTx hands the column back as stored, for every row, and the label bd versions prints passes such a string through. A table test runs the listing and the as-of read on the same stored value, for a version that was removed and one that was not, and expects the same answer, and none for a version that was never removed. The label gets the same out-of-vocabulary values and is expected to render what unknown renders. - The SDK's store opens. The shared construction guard now scans the repository root as well, so the Go SDK's five opens (Open, OpenFromConfig and OpenGated, and OpenBestAvailable in each build-tag twin) are noticed. Nothing accounts for them yet, so both guards fail on exactly those five sites. - A bytes bound beside the allocation-count bound on the number admission gate. A classifier that builds the number it is asked about makes one allocation whatever the exponent, so the count bound passes it, and the bytes grow. The fewest bytes one call allocates for a literal with a huge exponent must be no more than for a small one plus a margin. It passes today, because the gate never builds the number; it fails for a gate that does. - The refusal at the switch names the gate remedy as bd delete <id> --force, says that without --force bd only previews, and says that removing the gate unblocks anything it was blocking. The embedded and proxied end-to-end tests expect all three. * fix: green — the listing answers as the as-of read does; the SDK opens are accounted for Three review findings on the versioned-history change and one wording fix. A removed version's restriction. A stored removed_restriction is a free string, and only the four values of the vocabulary are answers. The as-of read already reported anything else (a NULL or empty column, "live", a hyphenated or arbitrary string) as unknown, but the listing handed the column back as stored, for every row, and the label bd versions prints passed it through. NormalizeRemovedRestriction is now the one place that decision is made. AsOfReadInTx calls it; ListVersionsInTx calls it for a version that was removed and gives a version that was not removed no restriction; and restrictionLabel renders through it. The listing, its JSON and the label now say what the as-of read says for the same row. The SDK's store opens. The Go SDK's five opens (Open, OpenFromConfig and OpenGated, and OpenBestAvailable in each build-tag twin) apply neither per-store switch, the events journal's or versioned history's, and they still do not. Applying them would change the library's behavior for every embedder, so that is a separate change; this one declares the boundary. The shared construction guard now accounts for the five with one exemption reason that is true of both switches, so a new SDK open is noticed rather than missed, and its staleness check keeps the exemptions honest. The docs gain one bullet saying that writers built on the SDK do not apply the switch. The bytes bound on the number admission gate needs no production change: the gate never builds the number, which is what the bound pins. The refusal at the switch now names the gate remedy as bd delete <id> --force, says that without --force bd only previews, and says that removing the gate also unblocks anything it was blocking. The docs line says the same. For a gate that blocks an issue, bd delete without --force prints a preview and exits 1, and with --force the gate is removed and what it blocked is ready again. * test(bazel): declare the root package's Go source as data for //cmd/bd:bd_test The shared store-construction scan now reads the repository root, where the Go SDK's opens live, but //cmd/bd:bd_test declared none of the root package's source. Under bazel test the scan therefore saw an empty directory, reported the five SDK exemptions as no longer matching a store construction site, and failed the events-journal guard, while go test, which sees the whole checkout, passed. List the root in tools/bazel/go_srcs.py so the generator emits its managed go_srcs filegroup there, and add that filegroup to bd_test's data. The new block is the generator's own output and nothing else changes. * ci: list the switch scan's proxied gate-timeout test in the 30-shard manifest Upstream main (#7129) moved the proxied-server tier to 30 duration-balanced shards, and TestProxiedShardManifestGeneratorNotStale requires every TestProxiedServer*/TestServerMode* test exactly once in that block. This branch adds TestProxiedServerVersionedHistorySwitchRefusesAnUnrecordableGateTimeout (cmd/bd/versioned_history_switch_scan_proxied_integration_test.go), so the block needs its line. Written by the generator itself: python3 scripts/ci/gen_proxied_shard_manifest.py 30 --weights=duration --write (one line, shard 8); --check exits 0 afterwards. Rebase note (maintainer): regenerated on current main, whose proxied-server tier uses 34 shards; the generator's incremental output (gen_proxied_shard_manifest.py 34 --weights=duration --write) placed this test at shard 6 of the 34-shard block. * ci: list the PR's embedded versioned-history tests in the embedded shard manifests #7156 made the embedded-Dolt tier's shard manifests exact-once (50 cmd shards, 15 storage shards), so every embedded test must be listed. This PR adds five embedded cmd tests and three embedded storage tests; this commit is exactly what the generators write for them: python3 scripts/ci/gen_embedded_cmd_shard_manifest.py 50 --weights=duration --write python3 scripts/ci/gen_embedded_storage_shard_manifest.py 15 --weights=duration --write Incremental: 8 lines added, none moved. Rebase note (maintainer): regenerated on current main, whose embedded manifests use 100 cmd shards and 40 storage shards; the generator's incremental output placed these tests at cmd shards 55 (TestEmbeddedVersionedHistorySwitchScansEveryRowNotOnePage), 56 (...SwitchRoundTrip), 57 (...SwitchRefusesUnversionableMetadata), 58 (...SwitchRefusesAnUnrecordableGateTimeout) and 59 (...SetManyRefusesUnversionableMetadata) of the 100-shard block, and at storage shards 5 (TestRecordVersionKeepsSubSecondChangeAt), 6 (TestVersionedHistoryKeepsNumbersTheStoreDistinguishesApart) and 23 (TestAsOfReadContract) of the 40-shard block. * test: exempt OpenBestAvailableWith, where #7188 moved the SDK's store construction Upstream #7188 split beads.OpenBestAvailable: it now delegates to the new OpenBestAvailableWith, which builds the store. This PR's two construction guards (TestEveryStoreConstructionActivatesTheEventsJournal and TestEveryStoreConstructionActivatesVersionedHistory) share one exemption list keyed by function, so after merging main they flagged OpenBestAvailableWith as an unexempted construction site and reported the OpenBestAvailable entries as stale. The two build-tag twins' keys now name OpenBestAvailableWith. The reason is unchanged: it is the SDK's library surface for embedders, and no code in the bd binary calls it. gofmt realigned the three neighbouring entries. * chore(schema): renumber removed_restriction to 0071 after #6943's 0070 Migrations are numbered by landing order. #6943 (participation_generation, the versioned-history write fence) lands first and owns main-plane 0070 and ignored/0028, so this PR's removed_restriction migration moves to the next free slot, 0071. The rename is done here, as one maintainer commit, rather than inside the replayed commits, so the history shows exactly what changed relative to the PR as reviewed; the intermediate commits of the rebase carry a duplicate 0070 and are not expected to build. - migrations/0070_add_removed_restriction.{up,down}.sql become 0071_*, with their header comments updated (the SQL itself is unchanged). Neither file exists on main or on #6943, so this is not an edit to a shipped migration. - cli_migrations.go: the CLI-bundle override is keyed to the new file name and renamed cliMigration0071AddRemovedRestriction, and its const now sits after 0070's. - migration_0070_add_removed_restriction_test.go becomes migration_0071_add_removed_restriction_test.go; its tests and messages say 0071, and it now owns the one LatestVersion pin (71). TestLatestVersionIncludesMigration0070 in #6943's participation_generation test is superseded by it and replaced by the usual pointer comment, and 0069's pointer comment now names the 0070 file that superseded it. - schema_test.go hygiene comments, BUILD.bazel embedsrcs/srcs, and the asof_read.go comment that cited the migration number. Checked: go test ./internal/storage/schema/... (with the dolt CLI lane, including TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion) and scripts/check-migration-hygiene.sh against origin/main and against #6943's tip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(versions): reconcile #6661's tests and docs with #6943's write fence #6943's write fence (design §16.2b) makes an update-shaped write to a legacy record -- one whose participation_generation is NULL because it was created while versioned history was off -- a skip, not a refusal: the fence returns before the snapshot is canonicalized, so nothing is versioned and the mint's admission gate never runs. Several of #6661's tests seed rows with history off and then expect a later write to them to be versioned or refused, and several comments say every later write to an offending row fails. On a tree that carries both PRs those tests fail and those comments are wrong. This ports, without changing their substance, the fence-integration commits Jim Wordelman wrote for the donnabox integration fork, where both PRs were already folded together: - eff898db80 / 5d2e5a2ac4 (issueops, dolt, embeddeddolt): the mocked mint sequence scripts the fence's participation_generation read; the number fidelity test splits phase 2 into 2a (a legacy row is written, not versioned, not refused, stays NULL) and 2b (a participating row is refused and left untouched); TestRecordVersionInTxSkipsALegacyRowBefore- TheAdmissionGate pins the fence's order against the gate. - e0ad9d1e3c / 1528022dfa (cmd/bd): the switch round trip and the routing/env end-to-end tests build the rows they expect a version for after the setting is on, and assert that the pre-setting seeds gain nothing. - 18b9015bf5 (cmd/bd): the embedded and proxied gate-timeout scan tests assert the whole scan-vs-mint truth table (legacy offenders are named by the scan but not refused by the mint; participating offenders are both). - 5929ebd50c / 8ce872be03 (comments, CHANGELOG, configuration reference): the mint's refusal binds rows that participate in history; the pre-enable scan cannot see participation, so it over-approximates in the safe direction. Left out on purpose: the fork's mintSkipsRow helper and defer-wake sweep change, and its bd doctor "Versionable Issues" check and the docs that point at it; none of those are part of #6661 or #6943. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Jim Wordelman <jim@wordelman.name> * test(versions): adapt #6661's guards to what main changed under it Three test-side adjustments for code that landed on main after #6661's last merge of it; no production code changes. - internal/storage/leg_contract_wiring_test.go: main gained an HTTP storage leg, and TestEveryLegWiresEveryRoleContract requires every leg to name or waive every role contract. The five R7.1 as-of read contracts this PR adds are a storage capability the HTTP client does not serve (internal/httpclient answers AsOf with an explicit unsupported error, and the wire has no instant/address selector or gone/unknown refusal), so they are waived on the http leg with that reason, as the donnabox integration fork does. - cmd/bd/versioned_history_construction_test.go: main split newDoltStoreFromConfig into two thin wrappers over openDoltStoreFromConfig, which is where the activation defer now lives (this rebase's resolution of the activation commit), so the factory guard keys on that body. - cmd/bd/versioned_history_serve_e2e_test.go: main's TestProxiedGatedTestsRunInTheProxiedLane requires a test that skips unless BEADS_TEST_PROXIED_SERVER=1 to be one the proxied lane selects, so TestVersionedHistoryServeActivatesTheProviderFromItsOwnRow becomes TestProxiedServerVersionedHistoryServeActivatesTheProviderFromItsOwnRow, and the 34-shard proxied manifest gains its line (written by gen_proxied_shard_manifest.py 34 --weights=duration --write, incremental; --check passes). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(bazel): emit go_srcs.py's managed blocks for internal/versionedhistory Main's tools/bazel/go_srcs.py now manages a repo_files filegroup block in every package BUILD file, lists those filegroups in the root BUILD.bazel's aggregates, and lists every go_library in tools/bazel's release_cross_build target. internal/versionedhistory is a package this PR adds, so after the rebase those managed blocks were stale and TestBazelGoSrcsBlocksCurrent (go test ./scripts/...) failed. This is the generator's own output (python3 tools/bazel/go_srcs.py) and nothing else; --check passes afterwards. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(versions): don't publish change_agent in bd versions --json `bd versions <id> --json` prints storage.IssueVersion as-is, so every JSON tag on that struct is part of a public contract. Provenance V2 (gastownhall/beads#7510, as ruled by the maintainer) removes the ad hoc agent field in favour of an actor chain; shipping a "change_agent" key now would make a public contract out of a field that is on its way out. IssueVersion.ChangeAgent is now tagged json:"-". Nothing else changes: the issue_versions.change_agent column (migration 0067) stays, ListVersionsInTx still reads it, change_actor and change_message are still published, and the human listing never showed the agent. No doc or golden named the key. TestVersionsJSONDoesNotPublishChangeAgent pins the absence with a non-empty value, so an omitempty-style regression would still fail, and pins that change_actor and change_message are still there. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(issueops): pin what the unfenced test-support mint does on #6943's new paths #6943's two fixes to the shared mint body -- (a) no issues row means no mint and no error, and (b) a create-shaped call on a new issues-table row flagged no-history stamps participation_generation without minting -- were written for its two kinds. This PR's shared body has a third, mintUnfenced, behind RecordVersionAtInTx (the R7.1 as-of fixtures' controlled-timestamp mint). The rebase resolution decided what (a) and (b) mean for it; this pins that decision: - (a) applies. It is the plane rule (FR-8: the table that holds the row decides its plane), not the fence, and the unfenced kind already honoured the flag-based form of the same rule (IsWisp). Without it, an unfenced mint for an unflagged wisps-table row would insert a version row that no issues row points at. The shared body's issues-table read now runs for all three kinds; only the update kind acts on the value it reads. - (b) does not apply. The unfenced mint never declares participation, so a flagged row returns right after the snapshot, as before: no read, no stamp. - The fence still does not apply: a legacy row is minted, and the closing UPDATE advances current_revision alone. TestRecordVersionAtInTxKeepsThePlaneRuleButNotTheFence scripts each of those three sequences exactly with sqlmock. TestTestSupportMintsStayOutsideTheShapeSplit places RecordVersionAtInTx outside #6943's create / dual-shape / update classification explicitly (it is the seam's exempt twin, not a mutation entry point or mint site): it must be in none of the shape lists, stay in versionExemptions, and reach neither RecordVersionForCreateInTx (it never stamps) nor RecordVersionInTx (whose gate and fence would stop the as-of fixtures minting history-off rows). The row-lock guard's exemption comment for recordVersionAtInTx already names the stamp-only UPDATE: #6943's own wording of it (all three UPDATE issues statements) was carried into that exemption when the as-of read commit was replayed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(storage): say exactly why the as-of read contracts stay waived on http #6943 now runs most of its participation-generation contracts over the served wire (internal/httpclient/served_participation_generation_test.go): their subject is a create or an update, which the client can send, and the fixture reads the reference store's raw columns. This checked whether the five R7.1 as-of read contracts can be wired the same way. They cannot, cheaply or otherwise, without a new wire operation: - their subject is the read itself (AsOfReadFixture.Resolve), and R7.1's read, issueops.AsOfReadInTx, is reached by no publicops role and served …
Upstream's 0069_widen_issue_versions_datetime_precision (gastownhall#6675) took slot 0069 first, so removed_restriction moved to 0070 and epoch_minted_addresses to 0071. The three epoch_cas.go headers still named 0070. Rebase note (maintainer): the migration is now 0072, per the landing-order ruling (gastownhall#6943's participation_generation is 0070 and gastownhall#6661's removed_restriction is 0071); the commit "chore(schema): renumber epoch_minted_addresses to 0072 after gastownhall#6661's 0071" updates these three headers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The BUILD files did not list epoch_cas.go in the dolt, embeddeddolt and issueops libraries, issueops' epoch_cas_test.go, or migration 0071 and its test, so Bazel could not compile those packages' tests. This is exactly the patch make bazel-sync writes (gazelle plus go_srcs.py; the PR's BUILD-sync CI step printed it): 4 files, 6 lines, nothing else. Rebase note (maintainer): the migration is now 0072, per the landing-order ruling (gastownhall#6943's participation_generation is 0070 and gastownhall#6661's removed_restriction is 0071); the commit "chore(schema): renumber epoch_minted_addresses to 0072 after gastownhall#6661's 0071" renames these BUILD entries. On the rebased base, this commit's internal/storage/schema/BUILD.bazel hunk is merged with the base's 0070 and 0071 entries.
…all#6661's 0071 Migrations are numbered by landing order. gastownhall#6943 (participation_generation, the versioned-history write fence) owns main-plane 0070 and gastownhall#6661 (removed_restriction) owns 0071, so this PR's epoch_minted_addresses migration moves to the next free slot, 0072. The rename is done here, as one maintainer commit, rather than inside the replayed commits, so the history shows exactly what changed relative to the PR as reviewed. - migrations/0071_add_epoch_minted_addresses.{up,down}.sql become 0072_*. Neither header names its own number, so the SQL and its comments are unchanged. Neither file exists on main, gastownhall#6943 or gastownhall#6661, so this is not an edit to a shipped migration. - cli_migrations.go needs nothing: the migration is a plain CREATE TABLE IF NOT EXISTS with no CLI-bundle override. - migration_0071_add_epoch_minted_addresses_test.go becomes migration_0072_add_epoch_minted_addresses_test.go; its consts, tests and messages say 0072, it owns the one LatestVersion pin (72), and its slot history now records the move past gastownhall#6943's 0070. TestLatestVersionIncludesMigration0071 in gastownhall#6661's removed_restriction test was already retired to a pointer comment by the rebase's resolution of "renumber epoch_minted_addresses to 0070"; that comment now names TestLatestVersionIncludesMigration0072 and its file. - BUILD.bazel embedsrcs/srcs, and the three epoch_cas.go headers (dolt, embeddeddolt, issueops) that cite the migration number. The intermediate commits of the rebase are not expected to build, for two reasons: - a duplicate migration version: the PR's epoch_minted_addresses migration shares 0069 with main's 0069_widen_issue_versions_datetime_precision until the PR's own "renumber epoch_minted_addresses to 0070", and from there shares 0071 with gastownhall#6661's removed_restriction until this commit; - a helper-name collision: from the PR's "feat: green — Fix PR gastownhall#6664: restore R16 honest-skip ... (refs be-ah0jf)" on, internal/storage/issueops declares readStoreEpochInTx twice, once in gastownhall#6943's version_history.go and once in this PR's epoch_cas.go, until "fix(epoch): rename gastownhall#6664's read-only store_epoch read past gastownhall#6943's readStoreEpochInTx" later in this stack. This commit ends the duplicate version, but it still does not compile on its own because of the collision; the stack builds from the rename commit on. Checked at the tip of the stack, where the rename has landed: go test ./internal/storage/schema/... with the dolt CLI lane (including TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion and TestMigration0072RecordsSurvivalInTheAddressTableThroughDoltCLI), and scripts/check-migration-hygiene.sh with BASE_SHA=origin/main and BASE_SHA=vh/6661-rebase. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…in's http leg main gained an HTTP storage leg (gastownhall#7247) after this PR's base, and TestEveryLegWiresEveryRoleContract requires every leg to name or waive every role contract. This PR adds three EpochFixture cases (RunTokenSchemeChangeCarriesLiveAddressesAndOnlyThose, RunACarriedAddressKeepsResolvingAcrossLaterBumps and RunALostAddressStaysGoneAcrossASchemeChange); dolt, embeddeddolt and uow wire them, and the http leg did not name them. They are waived on the http leg with the existing retentionEpochNoRoleWaiverReason, which already covers every other RetentionFixture/EpochFixture case there: EpochFixture is raw storage hooks (CurrentEpoch, BumpEpoch, MintUnderEpoch, StillServes, Resolve, CurrentAddressFor, LoseVersion) with no publicops role behind them, and internal/httpclient is a remote client with no epoch counter or address table of its own. The constant's doc comment now counts eighteen cases. Test-only; no production code changes. After this, the http leg's only unnamed entrypoints are gastownhall#6943's seven RunParticipationGeneration* contracts, whose waivers belong to gastownhall#6943. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…astownhall#6943's readStoreEpochInTx gastownhall#6943's "a create stamps participation even when the row is flagged no-history" (7c00d65) adds readStoreEpochInTx to version_history.go: the mint's read of store_epoch, which SEEDS the singleton row when it is absent. This PR's epoch_cas.go already declared a readStoreEpochInTx of its own, so the package stopped compiling once gastownhall#6664 was stacked on that commit. The two cannot be folded into one. This PR's helper is deliberately read-only: an absent row answers epoch 1 without writing, so CurrentEpochInTx, StillServesInTx, ResolveEpochInTx, CurrentAddressForInTx and LoseVersionInTx never write from a read (review item B4, pinned by TestCurrentAddressForNeverReseedsAnAbsentStoreEpochRow and TestCurrentAddressForWritesAndPublishesNothing). Calling gastownhall#6943's seeding read from those paths would break that. So gastownhall#6664's helper becomes readStoreEpochWithoutSeedingInTx, and its doc comment says why it is not readStoreEpochInTx. The five call sites and the ensureStoreEpochRow comment that names it follow. No behavior changes on either side: gastownhall#6943's mint path keeps its seeding read, and this PR's read-only paths keep theirs. (ensureStoreEpochRow, which BumpEpochInTx and MintUnderEpochInTx use, now has the same body as gastownhall#6943's readStoreEpochInTx; it is left as it is rather than folded in here.) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… waived on http All but four of the participation-generation contracts (gastownhall#6943's write fence) now run over the served wire (internal/httpclient/served_participation_generation_test.go): their subject is a create or an update, which the client can send, and the fixture reads the reference store's raw columns. The four stay waived, because the mutation each needs has no form on the wire. This checked whether the eighteen RetentionFixture/EpochFixture cases waived on the http leg, including the three this PR adds, can be wired the same way. They cannot, cheaply or otherwise, without a new wire operation: - every EpochFixture hook (CurrentEpoch, BumpEpoch, MintUnderEpoch, StillServes, Resolve, CurrentAddressFor, LoseVersion) is the operation under test, not a seed or a raw read. Those operations are methods on the concrete *DoltStore and *EmbeddedDoltStore over issueops' *InTx bodies, on no storage interface, no publicops role and no wire operation. Every call path into them starts in a test: the methods are called only from each store leg's own _test.go files (its EpochFixture, which the conformance contracts drive, and its epoch tests), and the *InTx bodies only from those methods, from each other and from tests (the uow leg's fixture through a test-only type assertion, and issueops' and the dolt leg's own tests). No command, role or server handler reaches them, so no client mutation touches epoch state either; - RetentionFixture's hooks (Resolve, Remove, Hold, ForceRemove, Erase, Mint) are implemented by no backend yet (every store leg wires them nil and its cases skip), and the wire has no removal, hold, erasure or gone/unknown resolve to bind them to. Binding the epoch hooks to the reference store behind the served env would pass, but as a property of that store, which the store legs already pin, never of the client. So the waivers stay; retentionEpochNoRoleWaiverReason's comment and reason string now say the above, in the shape gastownhall#6661 gave asOfReadNoHTTPWireWaiverReason, instead of the earlier general "raw storage hooks with no publicops role" wording. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(#6664) * test(conformance): un-skip R16 CAS + R20 epoch tests with honest not-implemented stubs Wires all 10 ExpectedRevisionFixture-gated Run* functions and both EpochFixture-gated Run* functions to real (non-nil) hooks on all three storage legs (dolt, embeddeddolt, uow), replacing the Phase 0 all-nil fixtures that made these cases t.Skip. Every wired hook is an unconditional "not implemented yet" stub rather than a partial-real implementation. This is deliberate: every Run* function under test calls its primary hook (CompareAndSetVersion, or CurrentEpoch/MintUnderEpoch) first, before any other hook, so a stub that errors unconditionally on that first call guarantees deterministic RED with zero risk of an accidental pass -- a concern that's concrete, not hypothetical, since at least one case (RunExpectedRevisionAcceptsAWriteNamingNoVersion) would go green under a partially-real read/unconditional-write strategy backed by Phase 1's already-persisted current_revision/store_epoch columns. Each case now fails for its documented reason: most via a direct t.Fatalf quoting the stub's "not implemented" error, and two (RefusalIsDistinguishableFromNotFound, RefusalIsDistinguishableFromValidationFailure) via a clean want/got mismatch against the sentinel errors they expect. Explicitly out of scope and untouched: CrossRecordInvariantFixture (R16.1) and the non-epoch RetentionFixture cases (R17) -- confirmed via test run that TestRetentionContract still reports PASS with all 13 subtests SKIP on every leg. TestEveryLegWiresEveryRoleContract (internal/storage/leg_contract_wiring_test.go) is a source-level AST naming check independent of hook nil-ness; all 12 entrypoints were already called by every leg pre-change, so this lock was satisfied before and remains satisfied after. Sentinel error messages reference be-x5jqd.3 (R16 CAS implementation) and be-x5jqd.4 (R20 epoch enforcement implementation), the two builder children this un-skip unblocks. Verified via go build ./..., go vet ./..., and go test -tags cgo across all three legs: all 10 R16 + 2 R20 subtests FAIL for the documented reason, TestRetentionContract unaffected. Bead: be-x5jqd.1 * feat: green — Implement R20 epoch-transition enforcement (refs be-x5jqd.4) * fix(epoch): honor R20-n's retained-mapping exception in StillServes/Resolve StillServesInTx and ResolveEpochInTx only ever checked whether the literal queried address's own row matched the current epoch. Per R20-n (#5898 rev 9), a version that survives an epoch transition keeps its prior-epoch address resolving once its id has been carried forward into the current epoch (via CurrentAddressForInTx or a fresh MintUnderEpochInTx) — that carried-forward row wasn't being consulted, so a legitimately retained address would wrongly stop resolving. Add mintedIDHasAddressAtEpochInTx and consult it as a fallback in both functions when the queried address's own row is stale. Addresses whose id was never carried forward are unaffected (row.mintedID has no row at the current epoch, same false/GoneReorganization answer as before). Round-2 response to be-rskwc's causal_disproof finding: the merge-base commit FAILed honestly on this defect, this branch's tdd_green SKIPped instead (attribution_evidence). This fix is real and verified via a new sqlmock unit test (TestStillServesInTxHonorsARetainedMapping et al.), but does not by itself flip TestEpochContract/EpochBumpVoidsOnlyAddressesOfVersionsNoLongerServed from SKIP to PASS: that test's own construction mints two records identically and never carries either forward before comparing StillServes on both, so no backend implementation can make them differ (escalation follows on a needs-mayor bead). refs be-x5jqd.4, be-rskwc round 2 * test(feat): red — harden EpochBumpVoidsOnlyAddressesOfVersionsNoLongerServed (refs be-9fiaw) Per mayor ruling on be-9fiaw: fix the test rather than waive it. The fixture already lets record-a survive an epoch bump by minting it again under the new epoch; record-b, never re-minted, does not survive. That asymmetry was previously only discovered after the fact (skip if StillServes agreed for both addresses), which meant the case could pass by observing either polarity. Assert the concrete expected values instead: servesA must be true, servesB must be false. This makes the case deterministically exercise both halves of R20-n, and closes a latent gap where a backend with the polarity reversed could have silently passed via the old discover-then-swap logic. * fix(schema): renumber epoch_minted_addresses to 0070, linearizing our own slot collision (refs be-hs42e.7) R20's epoch_minted_addresses and R7.1's removed_restriction both claimed migration slot 0069 on parallel sibling branches. Neither contained the other, so nothing in either branch's own CI could see the union: each was green alone, and the second to merge would panic checkNoDuplicateVersions at store open -- before any command's RunE, so every bd invocation bricks rather than one package reddening. Same hazard bee reproduced for #6358 vs #6008. This linearizes them instead of leaving it to merge order. R7.1 keeps 0069: it is published beneath #6661 and cannot move without rewriting a branch a reviewer is reading. R20 stops being a sibling, rebases onto R7.1, and takes the next contiguous slot. Contiguity is why the renumber could not be done pre-emptively in either branch alone: TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion asserts COUNT(*) == LatestVersion(), so a jump to a far slot fails until the gap is filled. The order had to be settled first. - migrations/0069_add_epoch_minted_addresses.{up,down}.sql -> 0070_* - migration_0069_add_epoch_minted_addresses_test.go -> migration_0070_*, with TestLatestVersionIncludesMigration0069 -> ...0070 (want 70) - 0069_add_removed_restriction_test.go retires its own LatestVersion pin in favour of 0070's, keeping the one-pin-at-a-time chain 0068 -> 0069 -> 0070 cli_migrations.go needs no change: its only override is R7.1's guarded PREPARE, which keeps 0069. The epoch migration is a plain unguarded CREATE TABLE IF NOT EXISTS and needs none. Verified: TestEmbeddedMigrationSourcesHaveNoDuplicateVersions, TestLatestVersionIncludesMigration0070, TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion (applies the full 0001..0070 chain through the dolt CLI), TestBundleMigrationsWithPreparedALTERAreOverriddenOrJustified and TestAllMigrationsSQLUsesDirectDDLForKnownCLIIncompatibilities all pass. go build ./... and go vet ./... clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(feat): red — Fix PR #6664: restore R16 honest-skip (stale be-x5jqd.3 premise) + address bee's 2 blockers on epoch_cas.go (refs be-ah0jf) * feat: green — Fix PR #6664: restore R16 honest-skip (stale be-x5jqd.3 premise) + address bee's 2 blockers on epoch_cas.go (refs be-ah0jf) * test(feat): red — Review: Fix PR #6664: restore R16 honest-skip (stale be-x5jqd.3 premise) + address bee's 2 blockers on epoch_cas.go (refs be-yj55d) * feat: green — Review: Fix PR #6664: restore R16 honest-skip (stale be-x5jqd.3 premise) + address bee's 2 blockers on epoch_cas.go (refs be-yj55d) * docs(epoch): cite epoch_minted_addresses as migration 0071 Upstream's 0069_widen_issue_versions_datetime_precision (#6675) took slot 0069 first, so removed_restriction moved to 0070 and epoch_minted_addresses to 0071. The three epoch_cas.go headers still named 0070. Rebase note (maintainer): the migration is now 0072, per the landing-order ruling (#6943's participation_generation is 0070 and #6661's removed_restriction is 0071); the commit "chore(schema): renumber epoch_minted_addresses to 0072 after #6661's 0071" updates these three headers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(feat): red — move #6664's Dolt server leg to post-transaction publish for store_epoch and epoch_minted_addresses (latent lost-update pattern) Tests only. On the commit before this one they fail for these reasons: - the server leg publishes store_epoch / epoch_minted_addresses inside the open SQL transaction (DOLT_ADD before COMMIT) for BumpEpoch, MintUnderEpoch and CurrentAddressFor: the lost-update hazard documented on doltAddAndCommitInTx - MintUnderEpoch and CurrentAddressFor stage only epoch_minted_addresses, so the first mint leaves store_epoch modified in the working set, on both legs (#6664 Major 2, reproduced with Status() on a real server and embedded) - BumpEpoch must surface a Dolt commit that fails after its SQL commit, while the mint paths keep their rows - ensureStoreEpochRow seeds with INSERT IGNORE and reads the row back TestMintOverlappingABumpCommitsAnAddressThatIsAlreadyGone characterizes current behaviour and passes now: a mint overlapping a bump commits an address the bump already voided. Its doc comment records why that is left as it is. * feat: green — move #6664's Dolt server leg to post-transaction publish for store_epoch and epoch_minted_addresses (latent lost-update pattern) Server leg (internal/storage/dolt/epoch_cas.go): BumpEpoch, MintUnderEpoch and CurrentAddressFor no longer stage and Dolt-commit inside the open SQL transaction. The two mint paths publish through runIssueOperationTxWithMessage, which commits the SQL transaction first. BumpEpoch commits it, then publishes with doltAddAndCommitPostTx and RETURNS a failed Dolt commit: a bump that is committed but unpublished must not read as success. Both legs: a mint stages store_epoch with epoch_minted_addresses, because the first mint inserts the singleton row (#6664 Major 2). The set lives in issueops.EpochMintDirtyTables so the legs cannot drift from what the body writes. issueops: ensureStoreEpochRow seeds with INSERT IGNORE and reads the row back, as version_history.go does for the same row. Not changed, on purpose: a mint overlapping a concurrent bump can still commit an address the bump already voided. Dolt has no lock for it and the only conflicting write would overwrite bumped_at/bumped_reason; see the doc comment on TestMintOverlappingABumpCommitsAnAddressThatIsAlreadyGone. One comment in that test file is reworded; no test logic changed since the red commit. * chore(bazel): bazel-sync (gazelle) for the two new epoch test files Only the two go_test srcs entries for the test files this branch adds: epoch_cas_publish_test.go (dolt) and epoch_cas_status_test.go (embeddeddolt). gazelle wanted nothing else for them (no deps change). * test(conformance): add the optional EpochFixture.LoseVersion capability Record survival explicitly instead of inferring it (#6664, review 5360880888, Major 1). Once an address stays served unless its own row says the store lost it, the only way for the contract to produce a Gone address is an explicit loss, so the contract needs a way to say "the store lost this Version". LoseVersion is additive and optional: no existing field changes signature, and a nil LoseVersion makes the cases that need one skip with a named reason. It is its own commit so that it can be judged, or replaced, on its own: the same semantics could ride on BumpEpoch taking a lost set, and only the plumbing would differ. Nothing uses it yet. * chore(epoch): add signature-only stubs for the survival rework The tests that follow exercise BumpEpochCarryingInTx, LoseVersionInTx, ErrEpochAddressNotServed and the BumpEpochCarrying and LoseVersion store methods (#6664, review 5360880888). Stubs give those names so the tree builds and the tests fail for their real, behavioural reasons instead of failing to compile. No logic: ErrEpochAddressNotServed is a sentinel, BumpEpochCarrying advances the counter exactly as BumpEpoch does and carries nothing, and LoseVersion returns "not implemented". The next commit adds the tests; the one after replaces these bodies. * test(feat): red — record survival explicitly in epoch_minted_addresses, make CurrentAddressFor read-only, carry on a token-scheme change Tests for the survival rework of #6664 (review 5360880888: Major 1, Minors 3 and 4). Every test is written before any production change. - Contract: the earlier mint-driven R20-n case is restated as three named phases (a survivor and a lost Version, loss is terminal, survival needs no upkeep), plus three new cases for a token-scheme change (carry the live lineages and only those, a carried address keeps resolving across later bumps, a lost address stays Gone across a scheme change). All three legs register them and wire LoseVersion and the carrying bump. - Shared body: unit tests for the row-based resolver (exactly the address's row and the epoch, fail closed on a row from a future epoch), a read-only CurrentAddressFor with typed errors, LoseVersion, a bump that writes only store_epoch, a mint that never hands back a lost address, and the per-database counter (Minor 3). Minor 4 gets a guard that no address in the test file is written by hand. - Real engine: the carry on the embedded leg (one carry row per live id, the lineage root, the collision rule, a row from a future epoch, a rewound counter, database-wide, lost lineages), the publication sets of every writer, and on the server leg the overlap of a mint with a bump (now a Live survivor) and a deterministic mint-after-loss interleaving that must not revive the lost address. - Migration 0071 byte pin and a real-dolt shape check for carried_from, gone_at_epoch, the carried_from index and the gone-not-before-mint CHECK. These fail on the current code, and some do not build yet because BumpEpochCarryingInTx, LoseVersionInTx, ErrEpochAddressNotServed and the store methods they exercise do not exist. * feat: green — record survival explicitly in epoch_minted_addresses, make CurrentAddressFor read-only, carry on a token-scheme change The survival rework of #6664 (review 5360880888: Major 1, Minors 3 and 4). An address's status is now a function of its own row and the current epoch, never inferred from other rows. - Migration 0071 (edited in place; no new slot, no ALTER): the table gains carried_from, gone_at_epoch, an index on carried_from and a CHECK that a loss epoch is not before the mint epoch. - Shared body: Live unless gone_at_epoch is set, and a row from an epoch that has not happened yet fails closed; the chain query is deleted. CurrentAddressFor only reads and returns typed errors. LoseVersion marks a whole lineage lost, once, guarded by gone_at_epoch IS NULL. BumpEpochCarrying (token-scheme change) writes one carry row per live lineage naming the lineage root, resolves a shared-id collision by carrying the newest and losing the rest, and fails if a row already sits at the new epoch. A mint only inserts its own root row and never hands back an address that is not served. A restore or reinit bump still writes only store_epoch. - Both Dolt legs: BumpEpochCarrying publishes store_epoch and epoch_minted_addresses, LoseVersion publishes epoch_minted_addresses and returns a failed publication, and CurrentAddressFor runs on the read path and publishes nothing. The per-database epoch counter (Minor 3) and the requirement that a caller of the carrying bump hold the workspace gate exclusively are documented where they apply. One change to tests written in the previous commit: the three real-server publication probes that only need a clean working set now open a database of their own, as the overlap tests do, instead of queueing on the shared test database's schema-init lock. Its five-second acquire timeout ran out under load and failed two of them; no assertion changed. * test(dolt): run the epoch contract on a database of its own TestEpochContract set up through setupTestStore, which puts every parallel test on the shared test database and queues their schema initialization on one lock with a five-second acquire timeout. Under host load a setup that waits behind another parallel test's runs out of it and fails at its first line with "schema migration lock unavailable: timeout". That failed the unchanged first-mint test twice in the dolt lane once this change had added tests to it, and the contract's own setup is exposed to the same timeout. The contract now opens a database of its own, the way the overlap tests and the publication probes already do, so this change adds no contention on the shared database's lock. No assertion changed. * docs: replace internal tracker ids in the epoch comments and test names with plain descriptions Comment and text edits only; no behavior changes and no line is added or removed (21 lines are replaced one for one). Each replaced line named an internal tracker id in a header, a test comment, a failure message or the migration header; it now says what it meant in plain words or cites the upstream issue or pull request. The EpochFixture API lines and the already published commit messages are left as they were. * ci: list this PR's embedded storage tests in the embedded shard manifest #7156 made the embedded-Dolt tier's shard manifests exact-once (50 cmd shards, 15 storage shards), so every embedded test must be listed. This PR adds eleven embedded storage tests and no embedded cmd tests; this commit is exactly what the generators write for them: python3 scripts/ci/gen_embedded_cmd_shard_manifest.py 50 --weights=duration --write python3 scripts/ci/gen_embedded_storage_shard_manifest.py 15 --weights=duration --write Incremental: 11 lines added, none moved; the cmd manifest is unchanged. Rebase note (maintainer): regenerated on current main, whose embedded storage manifest uses a 40-shard block; the generator's incremental output placed these tests at shards 7, 9, 11, 20, 21, 28, 31, 32, 33, 34 and 36 of 40, one test per shard (gen_embedded_storage_shard_manifest.py 40 --weights=duration --write; --check passes). * chore(bazel): bazel-sync for the epoch sources and migration 0071 The BUILD files did not list epoch_cas.go in the dolt, embeddeddolt and issueops libraries, issueops' epoch_cas_test.go, or migration 0071 and its test, so Bazel could not compile those packages' tests. This is exactly the patch make bazel-sync writes (gazelle plus go_srcs.py; the PR's BUILD-sync CI step printed it): 4 files, 6 lines, nothing else. Rebase note (maintainer): the migration is now 0072, per the landing-order ruling (#6943's participation_generation is 0070 and #6661's removed_restriction is 0071); the commit "chore(schema): renumber epoch_minted_addresses to 0072 after #6661's 0071" renames these BUILD entries. On the rebased base, this commit's internal/storage/schema/BUILD.bazel hunk is merged with the base's 0070 and 0071 entries. * chore(schema): renumber epoch_minted_addresses to 0072 after #6661's 0071 Migrations are numbered by landing order. #6943 (participation_generation, the versioned-history write fence) owns main-plane 0070 and #6661 (removed_restriction) owns 0071, so this PR's epoch_minted_addresses migration moves to the next free slot, 0072. The rename is done here, as one maintainer commit, rather than inside the replayed commits, so the history shows exactly what changed relative to the PR as reviewed. - migrations/0071_add_epoch_minted_addresses.{up,down}.sql become 0072_*. Neither header names its own number, so the SQL and its comments are unchanged. Neither file exists on main, #6943 or #6661, so this is not an edit to a shipped migration. - cli_migrations.go needs nothing: the migration is a plain CREATE TABLE IF NOT EXISTS with no CLI-bundle override. - migration_0071_add_epoch_minted_addresses_test.go becomes migration_0072_add_epoch_minted_addresses_test.go; its consts, tests and messages say 0072, it owns the one LatestVersion pin (72), and its slot history now records the move past #6943's 0070. TestLatestVersionIncludesMigration0071 in #6661's removed_restriction test was already retired to a pointer comment by the rebase's resolution of "renumber epoch_minted_addresses to 0070"; that comment now names TestLatestVersionIncludesMigration0072 and its file. - BUILD.bazel embedsrcs/srcs, and the three epoch_cas.go headers (dolt, embeddeddolt, issueops) that cite the migration number. The intermediate commits of the rebase are not expected to build, for two reasons: - a duplicate migration version: the PR's epoch_minted_addresses migration shares 0069 with main's 0069_widen_issue_versions_datetime_precision until the PR's own "renumber epoch_minted_addresses to 0070", and from there shares 0071 with #6661's removed_restriction until this commit; - a helper-name collision: from the PR's "feat: green — Fix PR #6664: restore R16 honest-skip ... (refs be-ah0jf)" on, internal/storage/issueops declares readStoreEpochInTx twice, once in #6943's version_history.go and once in this PR's epoch_cas.go, until "fix(epoch): rename #6664's read-only store_epoch read past #6943's readStoreEpochInTx" later in this stack. This commit ends the duplicate version, but it still does not compile on its own because of the collision; the stack builds from the rename commit on. Checked at the tip of the stack, where the rename has landed: go test ./internal/storage/schema/... with the dolt CLI lane (including TestAllMigrationsSQLAppliesThroughDoltCLIAndRecordsLatestVersion and TestMigration0072RecordsSurvivalInTheAddressTableThroughDoltCLI), and scripts/check-migration-hygiene.sh with BASE_SHA=origin/main and BASE_SHA=vh/6661-rebase. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(epoch): waive #6664's three new epoch contracts on main's http leg main gained an HTTP storage leg (#7247) after this PR's base, and TestEveryLegWiresEveryRoleContract requires every leg to name or waive every role contract. This PR adds three EpochFixture cases (RunTokenSchemeChangeCarriesLiveAddressesAndOnlyThose, RunACarriedAddressKeepsResolvingAcrossLaterBumps and RunALostAddressStaysGoneAcrossASchemeChange); dolt, embeddeddolt and uow wire them, and the http leg did not name them. They are waived on the http leg with the existing retentionEpochNoRoleWaiverReason, which already covers every other RetentionFixture/EpochFixture case there: EpochFixture is raw storage hooks (CurrentEpoch, BumpEpoch, MintUnderEpoch, StillServes, Resolve, CurrentAddressFor, LoseVersion) with no publicops role behind them, and internal/httpclient is a remote client with no epoch counter or address table of its own. The constant's doc comment now counts eighteen cases. Test-only; no production code changes. After this, the http leg's only unnamed entrypoints are #6943's seven RunParticipationGeneration* contracts, whose waivers belong to #6943. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(epoch): rename #6664's read-only store_epoch read past #6943's readStoreEpochInTx #6943's "a create stamps participation even when the row is flagged no-history" (7c00d65) adds readStoreEpochInTx to version_history.go: the mint's read of store_epoch, which SEEDS the singleton row when it is absent. This PR's epoch_cas.go already declared a readStoreEpochInTx of its own, so the package stopped compiling once #6664 was stacked on that commit. The two cannot be folded into one. This PR's helper is deliberately read-only: an absent row answers epoch 1 without writing, so CurrentEpochInTx, StillServesInTx, ResolveEpochInTx, CurrentAddressForInTx and LoseVersionInTx never write from a read (review item B4, pinned by TestCurrentAddressForNeverReseedsAnAbsentStoreEpochRow and TestCurrentAddressForWritesAndPublishesNothing). Calling #6943's seeding read from those paths would break that. So #6664's helper becomes readStoreEpochWithoutSeedingInTx, and its doc comment says why it is not readStoreEpochInTx. The five call sites and the ensureStoreEpochRow comment that names it follow. No behavior changes on either side: #6943's mint path keeps its seeding read, and this PR's read-only paths keep theirs. (ensureStoreEpochRow, which BumpEpochInTx and MintUnderEpochInTx use, now has the same body as #6943's readStoreEpochInTx; it is left as it is rather than folded in here.) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(storage): say exactly why the retention and epoch contracts stay waived on http All but four of the participation-generation contracts (#6943's write fence) now run over the served wire (internal/httpclient/served_participation_generation_test.go): their subject is a create or an update, which the client can send, and the fixture reads the reference store's raw columns. The four stay waived, because the mutation each needs has no form on the wire. This checked whether the eighteen RetentionFixture/EpochFixture cases waived on the http leg, including the three this PR adds, can be wired the same way. They cannot, cheaply or otherwise, without a new wire operation: - every EpochFixture hook (CurrentEpoch, BumpEpoch, MintUnderEpoch, StillServes, Resolve, CurrentAddressFor, LoseVersion) is the operation under test, not a seed or a raw read. Those operations are methods on the concrete *DoltStore and *EmbeddedDoltStore over issueops' *InTx bodies, on no storage interface, no publicops role and no wire operation. Every call path into them starts in a test: the methods are called only from each store leg's own _test.go files (its EpochFixture, which the conformance contracts drive, and its epoch tests), and the *InTx bodies only from those methods, from each other and from tests (the uow leg's fixture through a test-only type assertion, and issueops' and the dolt leg's own tests). No command, role or server handler reaches them, so no client mutation touches epoch state either; - RetentionFixture's hooks (Resolve, Remove, Hold, ForceRemove, Erase, Mint) are implemented by no backend yet (every store leg wires them nil and its cases skip), and the wire has no removal, hold, erasure or gone/unknown resolve to bind them to. Binding the epoch hooks to the reference store behind the served env would pass, but as a property of that store, which the store legs already pin, never of the client. So the waivers stay; retentionEpochNoRoleWaiverReason's comment and reason string now say the above, in the shape #6661 gave asOfReadNoHTTPWireWaiverReason, instead of the earlier general "raw storage hooks with no publicops role" wording. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(epoch): report applied-but-unpublished epoch writes as indeterminate, bound address length, verify dup-key mints Maintainer fixup for the #6664 review (adopt-pr attempt 1, iteration 1). Major 1, applied writes reported as failed. An epoch writer whose SQL commit has landed, or may have, now wraps storage.ErrCommitIndeterminate on both legs and hands back what it applied, so nothing replays a bump that has already advanced the counter: - embedded BumpEpoch and BumpEpochCarrying return the new epoch with the error (failedBump), and MintUnderEpoch its address; - server bumps wrap the sentinel on every Dolt failure after the SQL commit, including a failed staged-set read (unpublishedBump), and so does LoseVersion; an indeterminate SQL commit returns the epoch or address it may have committed, and a definite (typed MySQL) commit error returns neither. Tests: TestEpochWritesReportAnUnpublishedCommitAsIndeterminate (new, embedded, through an afterSQLCommit seam in runTransactionWithMessage); on the server leg TestEpochWritesMarkAFailedStagedReadIndeterminate, TestEpochWritesReturnWhatAnIndeterminateSQLCommitMayHaveApplied and TestEpochWritesReturnNothingWhenTheSQLCommitFailsDefinitely, and the sentinel asserted in every publication-failure test. Major 2, address overflow. MintUnderEpochInTx refuses a pair whose address would outgrow epoch_minted_addresses.address (VARCHAR(255)) at the widest epoch the counter can reach, with a typed ErrEpochAddressTooLong, so a carry can never fail on a lineage that gained an epoch digit. Major 3, duplicate-key mint. A duplicate key from the mint's INSERT is no longer success: the row is read again and the mint stands only if this transaction sees it served; a Gone row fails the mint with ErrEpochAddressNotServed, an unreadable one with the duplicate-key error. Measured on dolt-sql-server 2.2.0, the stale-snapshot INSERT does not report a duplicate key at all: its COMMIT fails with Error 1213 and the retried mint answers ErrEpochAddressNotServed (TestAMintRacingTheMintAndLossOfItsAddressConflictsAtCommit). Minors: - absent store_epoch row: sqlmock cases pin that CurrentEpoch, StillServes, Resolve, CurrentAddressFor and LoseVersion never seed it; switching any of the five to the seeding reader now fails the test; - the server publication tests mint their address instead of writing it by hand, and TestEpochCASTestsBuildEveryAddressWithEpochAddress scans that file too (issueops_test gains //internal/storage/dolt:go_srcs as data); - stale text: the duplicate-key and carry comments, the issueops header's CompareAndSetVersionInTx citation, the embedded header's parity claim, and the 0072 header's "upserts the same row" (0072 is past the frozen floor). Declined, for the owner: - a scheme-change carry voids an older live lineage re-minted after a restore: rule (a), document and pin it, or rule (b), resolve the loser to the winner's carry, is a design call about R20-n, not a review fix; - the uow epoch fixtures' in-transaction DOLT_COMMIT('-Am'): test-only fixtures with no production caller; routing them through RunTxScoped is follow-up work. Validation: go build ./...; go vet; nogo (bazel --config=nogo) on issueops, dolt and embeddeddolt; issueops epoch tests; the dolt epoch tests against a real dolt-sql-server (56 pass) and the fake-backed publication tests; embedded epoch tests with BEADS_TEST_EMBEDDED_DOLT=1; uow epoch contract; the schema package; the address guard under bazel in the local sandbox. All 14 overlay mutants of the fixes are killed. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Jim Wordelman <mayor@quad341.uk> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…pins (gastownhall#6132, gastownhall#6135) (gastownhall#7681) * test(domain/db): pin the statements the history-off upsert Insert issues The participation_generation write fence (gastownhall#6943) gave domain/db Insert's upsert path (CreateOnly unset: the quick, todo, gate and batch proxied servers' create) an existence probe ahead of the upsert, skipped while versioned history is off. Pin that skip with a sqlmock statement-sequence test: with history off, the upsert into issues and into wisps issues exactly the three statements the pre-stack code (4a67d0d) issues -- the upsert, the created event's same-content scan and its insert -- and nothing else. The mock is reached through internal/storage/sqlcount, and the pin also requires exactly three statements to reach the driver. sqlmock alone answers an unscripted statement with an error and fails only if the caller returns it, so a best-effort read whose error Insert dropped would pass its checks; the count catches it. The history-on run of the same script is the control: the probe (and the mint after it) must make the pin refuse it, which shows the script is exhaustive and that Insert reads the transaction's scope. Passes on 4a67d0d and on main; main issues no extra read with history off. Before-parity pin P2 (Insert half) from the fork gap analysis, for gastownhall#6132 / gastownhall#6135. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(issueops): pin the statements the history-off defer-wake sweep issues Port the fork's sqlmock pin of WakeExpiredDefersInTx with versioned history off (donnabox/codex/preview3-source-catchup-46aa 11c74cb): a one-row sweep issues exactly the expired-row SELECT, the UPDATE, the event's same-content SELECT and INSERT, and the empty wisps pass, so any read added before or after waking a row while history is off fails the pin. It passes on main unchanged and guards the fork's wake-skip change, which checks each expired row against the mint before waking it and must keep that check free with history off. Adapted for main: the doc no longer describes the fork's pre-wake check as existing; a history-on run of the same script is added as the control (the mint's read must make the pin refuse it), so the pin cannot pass vacuously; and the mock is reached through internal/storage/sqlcount, so the pin also requires exactly five statements to reach the driver. That catches a read whose error the sweep swallowed, which sqlmock alone does not see. Passes on 4a67d0d and on main. Before-parity pin P2 (wake half), for gastownhall#6132 / gastownhall#6135. Co-authored-by: Jim Wordelman <jim@wordelman.name> Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(storage): versioned-history flag-off differential against pre-stack goldens gastownhall#6132 and gastownhall#6135 require a differential test proving that with versioned history off (the default) storage behaves byte-identically to before the feature. Existing coverage stops short of that: TestDualWriteContractFlagOff only counts version rows, the participation-generation contracts check one column, and createbatchequiv runs its batch with history on over a column subset. Add internal/storage/historyoffequiv. Each leg (embedded Dolt, Dolt server, unit of work) runs one scripted mutation set through its own front doors on a store whose history was never turned on: - on the issues plane, every write role: creates, batch create, apply batch, updates, the no-op update, reparent, dependency add/remove, comments, claim/heartbeat/release, lease reclaim, metadata CAS, close/reopen, batch close with a refused item, defer and wake, delete; - the persistence moves in both directions; - on the wisps plane, the roles again: create, update and the no-op update, dependency add/remove, comment, metadata CAS, close/reopen, apply batch, batch close, release, defer and wake (the sweep's wisps pass), delete, a forced close of a no-history wisp, and the refusals the lease roles' contracts give a wisp (Claim, Heartbeat; Reclaim finds nothing); - each leg's own surface: the store legs' DoltStorage methods (import upsert, promotion, RunInTransaction, ...) and the uow leg's CreateOnly-unset domain upsert and importer. Neither reclaim sweep finds an expired lease, since no role can age one. The harness then dumps every column of every base table, plus the scenario's Dolt commit messages and the final dolt_status, and compares per-table SHA-256 digests with goldens recorded by running the same harness against origin/main 4a67d0d, the commit before the stack (gastownhall#6943, gastownhall#6661, gastownhall#6664). The only tolerated differences are listed in schemaAdditions: the stack's new columns (issues/wisps.participation_generation, issue_versions.removed_restriction) must be NULL in every row and are then left out of the digest; its new table (epoch_minted_addresses) must be empty; its own migration bookkeeping rows (0070-0072, ignored/0028) may each be there once. Recording and checking apply that rule the same way, so a golden re-recorded from main is byte-identical to the pre-stack one (verified on all three legs). The package doc says how the goldens are kept: a later migration whose schema flag-off leaves untouched adds its own schemaAdditions entry; a deliberate flag-off change, a scenario change or an engine rendering change re-records them and shows the dump diff. Wall-clock instants, wall-clock-derived ids and random tokens are masked by explicit, documented rules found by diffing two runs; instants the scenario supplies stay verbatim, so a write that starts overwriting one still shows. All three legs pass on main. Before-parity pin P1 from the fork gap analysis; the new embedded test is placed in the 40-shard storage block. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Jim Wordelman <jim@wordelman.name>
…0 upstream commits)
.github/scripts/embedded-cmd-test-shards.txt: d (upstream side; gen_embedded_cmd_shard_manifest.py --write adds the fork's TestEmbedded* gc/memory tests and TestEmbeddedIfRevisionRecloseReportsAlreadyClosed)
cmd/bd/main.go: a (fork attachParentConsole first line of main, chg-8hnz; upstream initprocs.Done after it)
internal/storage/schema/BUILD.bazel: a+c (upstream 0070-0072 and ignored/0028 srcs; fork label_definitions entries renamed to 0073)
internal/storage/schema/migration_0069_datetime_precision_test.go: a (upstream supersede comment)
internal/templates/agents/render_test.go: a (fork TestRenderedSectionsNoRetiredMemoryRule and upstream TestRenderSectionUserLevelAppliesOnlyInBeadsRepositories, both kept as whole functions)
internal/testutil/BUILD.bazel: a (fork //internal/execx and upstream //internal/execenv)
internal/testutil/git_test_hooks.go: a (fork execx.GitCommand kept; upstream os import for WithoutGitRepoLocationEnv; os/exec dropped, unused)
Migration renumbering (c): fork-only 0070_create_label_definitions.{up,down}.sql -> 0073 (upstream took 0070 gastownhall#6943, 0071 gastownhall#6661, 0072 gastownhall#6664); migration_0070_label_definitions_test.go -> migration_0073_label_definitions_test.go pinning LatestVersion 73; upstream TestLatestVersionIncludesMigration0072 replaced by a supersede comment (only one pin at a time); 0070 references updated in internal/httpclient/store.go, internal/storage/dolt/label_definitions_test.go, internal/storage/issueops/label_definitions{,_test}.go
cmd/bd/close_if_revision_reclose_embedded_test.go (clean merge, edited): fork test renamed TestEmbeddedIfRevisionRecloseReportsAlreadyClosed, required by upstream's embedded-lane coverage check
Dropped fork hunks: none
What this changes
This adds the participation marker and the write fence from design §16.2b of versioned beads Phase 2 (#6135). Versioned history is off by default, and with it off nothing below changes what a write does.
participation_generation BIGINT NULLtoissues. It also adds the column towisps, for schema parity only; nothing reads or writes it there.ignored/0028_add_wisps_participation_generation.up.sqlis the clone-local twin. There is no backfill.RecordVersionInTx(internal/storage/issueops/version_history.go). With versioned history on, an update-shaped mutation of a row whoseparticipation_generationisNULLmints nothing: noissue_versionsrow and nocurrent_revisionbump. A create-shaped mutation goes throughRecordVersionForCreateInTxinstead, which stamps the column fromstore_epoch.epochas part of the row's first version. Three kinds of write are create-shaped: a create on the issues plane, a wisp promotion, and a persistence move out of the wisps table (bd update --persistenton a wisp).0068_add_attribution_status.{up,down}.sqlbefore that file merged. Both files are byte-identical tomainagain, and the steps now live in 0070.TestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommitafter this change was written. That test creates its neighbor with history off and then expects the neighbor to be versioned, which the fence refuses by design. test(dolt): turn history on before the delete-neighbor fixtures exist #6961's two commits turn history on before the fixtures exist, and they change test code only.TestDualWriteDeleteSkipsALegacyNeighborsRewritenow pins the case the reorder left uncovered: a delete's rewrite of a legacy neighbor mints nothing.What changes when history is on
NULL, so the fence treats it as legacy and its updates stop minting. That is the intended §16.2b outcome: a record that predates the column stays legacy until it is explicitly promoted (R2.3), which is later-phase work. Onmain, nothing outside tests turns history on yet (the config switch is still in review in bd versions + a config switch for versioned history — the minimum cut that makes versioned beads usable (#6138) #6661), so no store should have version rows for this to strand.bd update --persistenton anissuesrow that still carries a wisp flag: a legacy row stays legacy, and a row created with history on still mints.issuesrow, so it starts versioning at that promotion.Review notes
git diff origin/main -- internal/storage/schema/migrations/0068_add_attribution_status.*.sqlis empty.0070_*migration: our bd versions + a config switch for versioned history — the minimum cut that makes versioned beads usable (#6138) #6661 and Phase 3 (R20): epoch-transition enforcement + minted-address CAS - gastownhall/beads#6136 #6664 (0070_add_removed_restriction), and storage: opt-in label vocabulary registry #6008 and cmd/bd: label vocabulary enforcement (stacked on #6008) #6010 (0070_create_label_definitions). Whichever merges after this one has to renumber. For bd versions + a config switch for versioned history — the minimum cut that makes versioned beads usable (#6138) #6661 and Phase 3 (R20): epoch-transition enforcement + minted-address CAS - gastownhall/beads#6136 #6664, that is on us.issuesrow. On a store without 0070 that read fails, and the mutation fails with it. The 0070 header says so.Test plan
At
3c5e0d743, go1.26.7 linux/amd64:TestParticipationGenerationFence(all 7 cases), the dual-write contract, and the promote and persistence-move behavior tests. 13 tests, 0 failures, 0 skips.BEADS_TEST_REQUIRE_DOLT_CONTAINER=1): the participation-generation and dual-write families, includingTestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommit, the promote andMoveIssuePersistenceInTxtests,TestPersistenceRepairKeepsTheRowsOwnParticipation, andTestDualWriteDeleteSkipsALegacyNeighborsRewrite. 33 tests, 0 failures, 0 skips.TestParticipationGenerationFence(all 7 cases) and the dual-write contract. 6 tests, 0 failures, 0 skips.internal/storage/issueops(including the version and journal completeness guards),TestEveryLegWiresEveryRoleContract,internal/storage/schema, andscripts/check-migration-hygiene.sh.b1c607237(0 version rows,NULLcolumn) and pass from39afe33e5on.scripts/test.sh): 103 packages ok, withcmd/bdrun in a standalone clone (see the review reply for why).go vet ./..., golangci-lint, andmake ci-pr-policy.Maintainer update (adopt-pr, 2026-10-18)
The test plan above was recorded at
3c5e0d743, and it is left as written. The branch has moved since then:main(4a67d0d028) and added maintainer commits. His update comment on this PR describes them.5014880099and763d3cc1b6.At the final head,
763d3cc1b6:TestParticipationGenerationFencecovers 12 cases on the embedded Dolt, server Dolt and unit-of-work legs. At3c5e0d743it covered 7.TestParticipationGenerationUpsertCreate(unit of work) pins the upsert's create/update dispatch in 5 subtests, includingWispOverLegacyIssuesRowKeepsItLegacy.