Skip to content

Close and sweep shipped plan-review tasks across reruns (#3943) - #4139

Open
ElNeMeR70 wants to merge 1 commit into
garrytan:mainfrom
ElNeMeR70:fix/tasks-lifecycle-close-sweep-3943
Open

ElNeMeR70 wants to merge 1 commit into
garrytan:mainfrom
ElNeMeR70:fix/tasks-lifecycle-close-sweep-3943

Conversation

@ElNeMeR70

@ElNeMeR70 ElNeMeR70 commented Nov 7, 2026 •

Copy link
Copy Markdown

Closes shipped plan-review tasks when a pull request merges and sweeps prior-run task files during reruns so completed items do not remain stuck in todo state. This keeps task lists accurate across review and deploy workflows.

Details

  • Disposition reader & lifecycle transitions (lib/tasks-lifecycle.ts): Follow carried_from back to the root <run_id>/<id> identity and replay task-dispositions-<phase>-*.jsonl in chronological order (timestamp, filename, line order) so a later transition (done, dropped) overrides an earlier todo record. Added closeShippedRunTasks and sweepShippedTasksFromGitHistory.
  • CLI (bin/gstack-tasks-lifecycle): Added close-shipped and sweep-shipped subcommands and wired sweep-shipped into extract before carrying forward prior runs.
  • Skill templates (ship/SKILL.md.tmpl, land-and-deploy/SKILL.md.tmpl): Close shipped tasks when landing or shipping a pull request.
  • Tests (test/tasks-lifecycle.test.ts): Added unit tests covering chronological disposition override, closing shipped tasks across carried_from chains, and sweeping shipped tasks from git history.

Fixes #3943

@trunk-io

trunk-io Bot commented Nov 7, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@ElNeMeR70
ElNeMeR70 force-pushed the fix/tasks-lifecycle-close-sweep-3943 branch from 52def22 to cbe171c Compare November 8, 2026 02:59
@ElNeMeR70 ElNeMeR70 changed the title feat(tasks): close and sweep shipped plan-review tasks across reruns Close and sweep shipped plan-review tasks across reruns (#3943) Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan-review task lists never close: /ship and /land-and-deploy don't mark shipped tasks done

1 participant