Skip to content

fix(browse): preserve prettyscreenshot path after hide#1419

Open
jbetala7 wants to merge 1 commit into
garrytan:mainfrom
jbetala7:oss/fix-1378-prettyscreenshot-hide-path
Open

fix(browse): preserve prettyscreenshot path after hide#1419
jbetala7 wants to merge 1 commit into
garrytan:mainfrom
jbetala7:oss/fix-1378-prettyscreenshot-hide-path

Conversation

@jbetala7
Copy link
Copy Markdown
Contributor

@jbetala7 jbetala7 commented May 10, 2026

Summary

  • keep the explicit prettyscreenshot output path when --hide appears before it
  • parse prettyscreenshot arguments with hide-selector values separated from positional args
  • add regression coverage for --hide before path, trailing --hide selector, and stdout mode

Fixes #1378

Tests

  • bun test browse/test/prettyscreenshot-args.test.ts
  • git diff --check

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prettyscreenshot: --hide as the trailing flag drops the explicit path argument

1 participant