fix(codex): avoid review prompt with --base#1209
fix(codex): avoid review prompt with --base#1209jbetala7 wants to merge 1 commit intogarrytan:mainfrom
Conversation
fc5c02f to
9463b75
Compare
|
Empirical confirmation from a downstream user — this is a real and recurring failure mode. We've hit the silent stall ~5 times across PRs in our project (claude-teams-bot) when running Currently maintaining a hand-patched A few notes from the downstream perspective:
Happy to test against this branch from our worktrees if you'd like a downstream confirmation before merge. Any timeline thoughts on landing this? Filing a related defensive recommendation as a separate issue (the wrapper currently swallows non-zero exits other than 124, which is what made this failure mode look like a silent stall in the first place — different problem from the parse error itself, but same observable symptom). |
Summary
codex review <PROMPT> --base <base>shape from/codex,/review, and/shipgit diff origin/<base>...HEADitselfFixes #1196.
Testing
bun run gen:skill-docs --host allbun test test/gen-skill-docs.test.tsbun test test/host-config.test.tsbun test test/skill-validation.test.ts --test-name-pattern "codex review invocations"Note:
bun test test/gen-skill-docs.test.ts test/skill-validation.test.ts test/host-config.test.tsstill hits an unrelated existing guard failure because tracked fixturebrowse/test/fixtures/security-bench-haiku-responses.jsonis 27MB and exceeds the 2MB limit.