Skip to content

Deferred review finding: browse/src/routes/commands.ts:172 — screenshot <bare tag> parses as an output path, so the tunn #4120

Closed as not planned

Description

@capy-ai

Filed by /ship's pre-landing review of PR #4116 (head 6574c9d). The finding is in code that PR did not change, so it was deferred here instead of being fixed there (review scope frozen after pass 1).

  • Severity: CRITICAL
  • Where: browse/src/routes/commands.ts:172
  • Finding: screenshot parses as an output path, so the tunnel 403 hint says it cannot name an output path; hint could mention --selector. Fails closed. Reader: FIXABLE, Low, Blocks: no.

Activity

  1. capy-ai commented on Nov 7, 2026

    @capy-ai
    ContributorAuthor

    Closing: this finding was fixed in dd6c3d2 on #4116 before the issue was filed (an automated defer step filed it by mistake).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions