Under improvement -Event page #236
Conversation
|
Congratulations for making your first Pull Request at JagratiWebApp!! 🎉 Someone from our team will review it soon. |
There was a problem hiding this comment.
- Put all the static files in
static/events/directory only. - Use the images directly from
static/home/images, don't add any additional dummy images anywhere. - Indent all the files properly, they are currently not readable (use
Alt + Shift + Fin VSCode). - Revert back the changes in all the files which are not related to this PR.
First do all these changes so that your PR is readable. After that, I'll test it on my system and review it again.
apps/events/admin.py
Outdated
| @@ -8,7 +8,7 @@ class EventAdmin(admin.ModelAdmin): | |||
| list_display = ('title', 'schedule', 'venue') | |||
| search_fields = ('title', 'venue') | |||
| ordering = ('-schedule',) | |||
|
|
|||
There was a problem hiding this comment.
Revert back all the changes in this file. Remove this tab and an extra line inserted at the end of this file.
apps/events/models.py
Outdated
| @@ -15,7 +15,7 @@ class Event(models.Model): | |||
| schedule = models.DateTimeField() | |||
| venue = models.CharField(max_length=50) | |||
| thumbnail = models.ImageField( | |||
| upload_to=event_thumbmail_path, null=True, blank=True) | |||
| upload_to='events/images', null=True, blank=True) | |||
There was a problem hiding this comment.
It is already fetching the path where the thumbnail needs to be saved from the event_thumbnail_path function. You should revert back this change.
If you want to get the URL of the thumbnail, you can simply use <event>.get_thumbnail_url.
apps/events/models.py
Outdated
| images = models.ImageField(upload_to = 'gallery/image',null=True ,blank=True) | ||
|
|
||
| def __str__(self): | ||
| return self.post |
There was a problem hiding this comment.
Why a new Gallery model?? Gallery model is already present in the file (last model). Also, what do you mean by the post field here?
| padding-left: 0, | ||
| padding-right: 0; | ||
| } | ||
| {% endblock %} |
There was a problem hiding this comment.
Indent the CSS above properly, it is not readable. You may use Alt + Shift + F in VSCode to auto-indent everything.
| @@ -1,9 +1,13 @@ | |||
| from django.contrib import admin | |||
There was a problem hiding this comment.
I don't see admin being used anywhere.
| from . import views | ||
|
|
||
| app_name = 'events' | ||
| urlpatterns = [ | ||
| path('', views.index, name='index'), | ||
| path('add/', views.add_event, name='add_event'), | ||
| ] | ||
| path('show_event/<int:myid>',views.show_event,name='show_event'), |
There was a problem hiding this comment.
Use pk instead of myid to represent a primary key input.
| from . import views | ||
|
|
||
| app_name = 'events' | ||
| urlpatterns = [ | ||
| path('', views.index, name='index'), | ||
| path('add/', views.add_event, name='add_event'), | ||
| ] | ||
| path('show_event/<int:myid>',views.show_event,name='show_event'), | ||
| ]+static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT) |
There was a problem hiding this comment.
No need to add this here. It is already added in Jagrati.urls.py.
home/urls.py
Outdated
| @@ -8,4 +8,5 @@ | |||
| path('dashboard/', views.dashboard, name='dashboard'), | |||
| path('dashboard/update_cwhw/', views.update_cwhw, name='update_cwhw'), | |||
| path('ajax/dashboard/', views.ajax_dashboard, name='ajax_dashboard'), | |||
|
|
|||
There was a problem hiding this comment.
Remove this extra line from here.
| @@ -15,6 +17,8 @@ | |||
| min-height: 100vh; | |||
| /* height: 100%; */ | |||
| } | |||
| {% block style %} | |||
| {% endblock %} | |||
There was a problem hiding this comment.
Don't add any additional CSS and make any changes in templates/layout.html directly. Doing this will break our all other pages.
|
|
||
| left:0; | ||
| bottom: 0; | ||
| width:100%; |
There was a problem hiding this comment.
Don't make any changes in some file which directly affects our all other pages.
| @@ -15,7 +15,7 @@ class Event(models.Model): | |||
| schedule = models.DateTimeField() | |||
| venue = models.CharField(max_length=50) | |||
| thumbnail = models.ImageField( | |||
| upload_to='events/images', null=True, blank=True) | |||
| upload_to='<event>.get_thumbnail_url', null=True, blank=True) | |||
There was a problem hiding this comment.
This isn't what I meant. Keep upload_to=event_thumbnail_path here.
I meant, if you want to get the URL of the thumbnail image anywhere in views or templates, you can just use the get_thumbnail_url property. For ex, if event is an instance of Event table, you can do event.get_thumbnail_url and it will return you the URL of thumbnail of that event.
Lots of work still needs to be done , hope u will understand and please let me know if something is wrong or if i need to add on something! @garg3133
Thank you!