[TEST] Refactor minkapi server tests by takoverflow · Pull Request #66 · gardener/scaling-advisor

takoverflow · 2025-09-21T22:39:30Z

What this PR does / why we need it:
Refactor minkapi server tests into a uniform, readable format

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

* create function to check for changes to name and namespace * removed duplicate `GenerateName` from typeinfo

elankath · 2025-10-16T05:00:42Z

minkapi/server/store/store_test.go


 package store

 import (


There is already a server_test.go in main. This PR does not appear merged with main ?

This is rebased on top of main, it's not creating a new server_test, just adding the refactored minkapi server tests to the existing file.

gardener-robot · 2025-10-18T03:18:11Z

@aaronfern You have pull request review open invite, please check

elankath · 2025-11-13T13:30:30Z

@takoverflow due to lots of changes in main, this PR is severely dated. Please let me know if you wish to close this/re-open

takoverflow · 2025-11-13T13:31:56Z

I'll close this soon, and create a new PR.

gardener-ci-robot · 2025-12-19T18:29:19Z

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

After 15d of inactivity, lifecycle/stale is applied
After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Mark this PR as rotten with /lifecycle rotten
Close this PR with /close

/lifecycle stale

gardener-ci-robot · 2026-01-03T18:57:40Z

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

After 15d of inactivity, lifecycle/stale is applied
After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close

/lifecycle rotten

gardener-prow · 2026-01-13T07:38:00Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gardener-ci-robot · 2026-02-12T08:27:34Z

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as active with /lifecycle active
Mark this PR as fresh with /remove-lifecycle stale
Mark this PR as rotten with /lifecycle rotten
Close this PR with /close

/lifecycle stale

gardener-robot added needs/review Needs review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Sep 21, 2025

takoverflow changed the title ~~[TEST] Refactor minkapi server "unit" tests~~ [TEST] Refactor minkapi server tests Sep 21, 2025

takoverflow changed the title ~~[TEST] Refactor minkapi server tests~~ [TEST] Refactor minkapi server tests Sep 21, 2025

takoverflow force-pushed the refactor-test branch from a557ad7 to 2b91127 Compare October 7, 2025 01:08

takoverflow added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2025

github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 7, 2025

takoverflow removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2025

takoverflow force-pushed the refactor-test branch from 2b91127 to 9a5df59 Compare October 7, 2025 03:52

takoverflow added 2 commits October 15, 2025 18:22

fix(testdata): change instanceType to name

d4e709c

refactor: DRY for functions

0f6e5f0

* create function to check for changes to name and namespace * removed duplicate `GenerateName` from typeinfo

takoverflow force-pushed the refactor-test branch from 9a5df59 to c45de99 Compare October 15, 2025 12:53

takoverflow added 2 commits October 15, 2025 18:28

fix(store): shutdown broadcaster when resetting in-mem store

bd6e13e

feat(test): minkapi server test combined

0566a86

takoverflow force-pushed the refactor-test branch from c45de99 to e3ae723 Compare October 15, 2025 13:01

fix linter errors

9712bb4

takoverflow force-pushed the refactor-test branch from e3ae723 to 9712bb4 Compare October 15, 2025 13:08

takoverflow marked this pull request as ready for review October 15, 2025 13:13

takoverflow requested review from aaronfern and elankath October 15, 2025 13:13

elankath reviewed Oct 16, 2025

View reviewed changes

cli: fix genscenario help docstring

4de46c6

gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2025

gardener-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2026

aaronfern removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 5, 2026

gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026

gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2026

gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Mar 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEST] Refactor minkapi server tests#66

[TEST] Refactor minkapi server tests#66
takoverflow wants to merge 6 commits intogardener:mainfrom
takoverflow:refactor-test

takoverflow commented Sep 21, 2025 •

edited

Loading

Uh oh!

elankath Oct 16, 2025

Uh oh!

takoverflow Oct 16, 2025

Uh oh!

gardener-robot commented Oct 18, 2025

Uh oh!

elankath commented Nov 13, 2025

Uh oh!

takoverflow commented Nov 13, 2025 •

edited

Loading

Uh oh!

gardener-ci-robot commented Dec 19, 2025

Uh oh!

gardener-ci-robot commented Jan 3, 2026

Uh oh!

gardener-prow bot commented Jan 13, 2026

Uh oh!

gardener-ci-robot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

takoverflow commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elankath Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

takoverflow Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

gardener-robot commented Oct 18, 2025

Uh oh!

elankath commented Nov 13, 2025

Uh oh!

takoverflow commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gardener-ci-robot commented Dec 19, 2025

Uh oh!

gardener-ci-robot commented Jan 3, 2026

Uh oh!

gardener-prow bot commented Jan 13, 2026

Uh oh!

gardener-ci-robot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

takoverflow commented Sep 21, 2025 •

edited

Loading

takoverflow commented Nov 13, 2025 •

edited

Loading