ScaleOutSimulator for SimulatorStrategyMultiNodeSingleSim#153
Closed
elankath wants to merge 37 commits intogardener:mainfrom
Closed
ScaleOutSimulator for SimulatorStrategyMultiNodeSingleSim#153elankath wants to merge 37 commits intogardener:mainfrom
elankath wants to merge 37 commits intogardener:mainfrom
Conversation
* Renamed planner service binary from scalp to splanner. * Renamed samples/types.go SimplePodMetadata to SimplePodGenInput. * Added PCVNames and SchedulerName to SimplePodGenInput. * Added templates for PVC and PV in samples/data. * Created utility functions to generate simple PVCs.
* introduced VolumeClaimAssignment representing PV<->PVC in planner API * introduced StorageMetaAccess to query CSI storage meta-info in planner API * introduced Planner util: BindClaimsAndVolumes, BindClaimAndVolume, IsPVBindCandidate * planner request view is now popualated with SC's, PVC's and PV's * introduced viewutil.GetStorageClassesClaimsAndVolumes * introduced viewutil.ListStorageClassesClaimsAndVolumes * run Simulation now invokes new createCSINode method before launching scheduler. * run Simulation now performs util.BindClaimsAndVolumes before launching scheduler. * introduced samples.GenFillStorageAndVolumeObjects * introduced samples.CSIDefaults for holding CSI defaults. * introduced samples.StorageVolGenInput as common input gen obj for SC's,PV's,PVC's * introduced samples.GetCSINodeDrivers, samples.GetCSIDefaults * introduced TestBasicOnePoolScaleOutWithBoundPVC, TestBasicOnePoolScaleOutWithUnboundPVC * introduced TestGeneratePVCs * using Factory interfaces in planner instead of functions, impls don't depend on other impls. * introduced Factories struct in planner API that encapsulates all factory facades * methods added to ScalingConstraintSpec to get zones, NodePlacements * ViewFactory moved to api/minkapi * rename pkg weights->weigher * scale-out Result types prefixed with ScaleOut * sentinel errors for view pop and volume binding in planner API * moved ScaleOut types to scaleout_types.go in planner API * rename Simulator -> ScaleOutSimulator * rename Simulation -> ScaleOutSimulation * rename SimGroupKey -> PriorityKey * rename SimulationGroupPassScores -> ScaleOutSimGroupPassScores * rename SimulationGroupCycleResult -> ScaleOutSimGroupCycleResult * removed BasicObjectMeta, using metav1.ObjectMeta as many fields are used. * rename samples.ResourceCategory to samples.ResourcePreset * rename samples.SimplePodGenInput to PodGenInput * added missing json tags to PodInfo, NodeInfo
* introduced samples.GenScalingConstraints * support constraint generation for pools with multiple zones. * all tests write request and response json to tmp test dir * renamed samples.PoolCategory -> samples.PoolPreset
* dont use eventTime in simulation for tracking - reset event list instead * added mutex to simulator state to prevent data race for sandbox view creation/access
Co-authored-by: Prashant Tak <prashant.tak@sap.com>
…viewutil.go Co-authored-by: Aaron Francis Fernandes <79958509+aaronfern@users.noreply.github.com>
Co-authored-by: Prashant Tak <prashant.tak@sap.com>
Co-authored-by: Prashant Tak <prashant.tak@sap.com>
* TestOnePoolScaleOutWithUnboundPVC_ImmediateVolumeBinding(t * rename util.BindClaimsAndVolumes -> BindClaimsAndVolumesForImmediateMode * rename defaultScaleOut.trackUntilStabilized -> workAndTrackUntilStabilized * introduced defaultScaleOut.doWork * introduced util.BindClaimsAndVolumesWithNonNilClaimRefs invoked by doWork * samples and planner testutil changes to support Immediate and WFFC volume bindings
* ScaleOutSimulator under planner/simulator/scaleout * ScaleOutSimulation under planner/simulation/scaleout * factory packages under planner/simulation, planner/simulator * minkapi typeinfo moved to api/minkapi/typeinfo
* introduced plannerapi.ScaleOutNodeTemplate * introduced scaleout.RunState used by scaleout.defaultSimulation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
bot
added
do-not-merge/needs-kind
gardener-prow
bot
added
the
do-not-merge/work-in-progress
gardener-prow
bot
removed
the
do-not-merge/needs-kind
gardener-prow
bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/close This is being closed in favour of simpler PR #154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #85
Special notes for your reviewer:
Release note: