Skip to content

Conversation

@MartinWeindel
Copy link
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
Implement controller for DNSProvider replication.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@MartinWeindel MartinWeindel requested a review from a team as a code owner October 28, 2025 14:37
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2025
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the DNSProvider replication in the controller-runtime!

I left a few comments below 👇

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@MartinWeindel MartinWeindel force-pushed the enh/dnsman2/dnsprovider-source-controller branch from 33121da to 8eb8132 Compare November 3, 2025 07:40
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2025
@MartinWeindel
Copy link
Member Author

rebased to resolve merge conflicts

Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my suggestions!

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@gardener-prow
Copy link

gardener-prow bot commented Nov 3, 2025

LGTM label has been added.

Git tree hash: e69a45b65d65b4c3d545bb8e8fa8494534aff14e

@gardener-prow
Copy link

gardener-prow bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@gardener-prow gardener-prow bot merged commit 6b0e1f7 into master Nov 3, 2025
29 checks passed
@gardener-prow gardener-prow bot deleted the enh/dnsman2/dnsprovider-source-controller branch November 3, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants