-
Notifications
You must be signed in to change notification settings - Fork 74
Consider update group on applying changes to keep provenance information #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @Lappihuan |
|
/test all |
|
/test all |
|
/hold needs more testing |
|
I tested this PR in our staging environment and can confirm it resolves the issue. |
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle rotten |
|
/remove-lifecycle rotten |
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
|
We still had some edge cases that weren’t fixed by this PR. @MartinWeindel informed me that it wouldn’t be feasible to integrate these fixes into the current controllers, but the rewrite will automatically handle this use case. |
|
/close will be addressed in context of new implementation "dnsman2" |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
The DNS controller manager assumes that it doesn't matter which set of credentials is used for a specific zone if different credentials are used for different
DNSProviders.This assumption can lead to the loss of the correct provenance information on updates if the backend supports it (like PowerDNS).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: