fix: resolve race condition in Clerk auth signup flow to prevent duplicate login attempts #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate login attempts
…of user.update behavior
nrainhart
approved these changes
Jan 2, 2026
| @@ -1,5 +1,6 @@ | |||
| Released Jazz 0.19.16: | |||
| - Improved sync timeout error messages to include known state, peer state, and any error information when waiting for sync times out | |||
| - Bugfix: fixed a race condition in Clerk auth where the signup flow could trigger a duplicate login attempt | |||
Contributor
There was a problem hiding this comment.
Is this needed? I thought our release process took care of updating this file
Collaborator
Author
There was a problem hiding this comment.
No, it only updates the individual changelogs in each package.
The result is unreadable, and can't be used when publishing on discord, so I've started to manually keep track of the changes to release here.
Comment on lines
+56
to
+59
| private previousUser: Pick< | ||
| NonNullable<MinimalClerkClient["user"]>, | ||
| "unsafeMetadata" | ||
| > | null = null; |
Contributor
There was a problem hiding this comment.
Nit: I'd extract the repeated type into a named type
Collaborator
Author
There was a problem hiding this comment.
Trying to clean up the module, there is a bit of unnecessary code that's here for tech debt.
Going to do it in a follow-up PR, so I can release this fix ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue I've found that when signing up with Clerk the user also goes through the logIn flow, creating a new context and interrupting the previous sync ops.