Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Info in FinitePolycyclicCollector_IsConfluent #5911

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

fingolfin
Copy link
Member

... instead of commented out debug messages. The new Info statements are taken from the IsConfluent method for IsPcGroup from lib/rwspcgrp.gi.

... instead of commented out debug messages. The new `Info` statements are
taken from the `IsConfluent` method for `IsPcGroup` from `lib/rwspcgrp.gi`.
@fingolfin fingolfin added topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jan 21, 2025
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
(Having a test would be difficult because of the involved timings.)

lib/rwspcclt.gi Outdated Show resolved Hide resolved
lib/rwspcclt.gi Outdated Show resolved Hide resolved
@fingolfin fingolfin enabled auto-merge (squash) January 28, 2025 15:12
@fingolfin fingolfin merged commit 6800c66 into gap-system:master Jan 28, 2025
33 checks passed
@fingolfin fingolfin deleted the mh/InfoConfluence branch January 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants