kernel: refactor InitSystem
#5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
changed the title
fingolfin
changed the title
fingolfin
force-pushed
the
mh/split-InitSystem
branch
from
68061a0 to
eea420c
Compare
ChrisJefferson
approved these changes
Jan 9, 2025
|
I approved, but the failing test does identify a valid warning (an assert which should be changed). |
fingolfin
force-pushed
the
mh/split-InitSystem
branch
from
23bcec8 to
cd0902c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitSysteminto multiple partsgetwindowsize->InitWindowSizeDotGapPathParseCommandLineOptionsParseCommandLineOptionsReaping the fruits of previous labor...
Best to view this commit-by-commit, and possibly with "ignore whitespace" turned on.