-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: remove SyOriginalArgv
& SyOriginalArgc
#5887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly moving things in a good direction
c2a72fe
to
558ff48
Compare
The But I still can't figure out why it would do that. What change in this PR could even be responsible?!? @ChrisJefferson if you have any idea at all... |
794f344
to
acb54a5
Compare
It hangs in test suite testworkspace, which may give a clue... |
OK, |
acb54a5
to
240603b
Compare
These kept references to the `argv` array around. This is potentially problematic for consumers of libgap API, specifically when calling `GAP_Initialize` it is not obvious that one has to keep the `argv` passed to it alive until after GAP completed its startup. While we could amend the documentation for `GAP_Initialize` (which unfortunately currently does exist at all) to mention this, it seems better to obviate the need for it. This patch is a first step towards this. However, several pointers to `argv` members remain, at least these: - `SyCompileOutput` - `SyCompileInput` - `SyCompileName` - `SyCompileMagic1` - `SyRestoring`
7b7190a
to
5d27d2f
Compare
So the problem was that when restoring a workspace, The true mystery thus is why |
|
@limakzi we already run CI tests on macOS runners, just fewer than on Linux because they are bottlenecked (we can have 40 concurrent Linux jobs but only 5 concurrent macOS jobs, IIRC) |
@limakzi thanks for the review! |
These kept references to the
argv
array around. This is potentially problematic for consumers of libgap API, specifically when callingGAP_Initialize
it is not obvious that one has to keep theargv
passed to it alive until after GAP completed its startup.While we could amend the documentation for
GAP_Initialize
(which unfortunately currently does exist at all) to mention this, it seems better to obviate the need for it.This patch is a first step towards this. However, several pointers to
argv
members remain, at least these:SyCompileOutput
SyCompileInput
SyCompileName
SyCompileMagic1
SyRestoring