Fix error in code handling subgroups of finitely presented groups with generators of order 2 which could lead to wrong results #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the MT detects that generators must be of order 2, it avoids the inverse column. This however means that all ocurrences of the inverse generator in the conjugate relators also need to be replaced with the positive powers. This fixes gap-system#5744
hulpke
added
kind: bug: wrong result
fingolfin
approved these changes
Jun 17, 2024
fingolfin
added
kind: bug
fingolfin
changed the title
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the MT detects that generators must be of order 2, it avoids the inverse column. This however means that all ocurrences of the inverse generator in the conjugate relators also need to be replaced with the positive powers.
This fixes #5744
Text for release notes
An error in the MTC for subgroups of finitely presented groups, in which generators of order 2 were not properly handled, was corrected. It could have led to wrong results.