Skip to content

Commit

Permalink
Fix Extensions for nonsolvable group and trivial cohomology (#5908)
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasBreuer authored and fingolfin committed Jan 20, 2025
1 parent fad9aad commit 2f5918d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/twocohom.gi
Original file line number Diff line number Diff line change
Expand Up @@ -2026,7 +2026,7 @@ InstallOtherMethod(Extensions,"generic method for finite groups",
function(G,M)
local coh;
coh:=TwoCohomologyGeneric(G,M);
return List(Elements(VectorSpace(coh.module.field,coh.cohomology)),
return List(Elements(VectorSpace(coh.module.field,coh.cohomology,coh.zero)),
x->FpGroupCocycle(coh,x,true:normalform));
end);

Expand Down
3 changes: 3 additions & 0 deletions tst/teststandard/twocohom.tst
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ gap> cp:=CompatiblePairs(g,mo);
<group of size 240 with 4 generators>
gap> Length(ExtensionRepresentatives(g,mo,cp));
2
gap> mo:= TrivialGModule( g, GF(3) );;
gap> Length( Extensions( g, mo ) );
1

# New code for Pc groups
gap> g:=AbelianGroup([2,2]);;
Expand Down

0 comments on commit 2f5918d

Please sign in to comment.