Add tests for invalid inputs

gap-packages · Nov 6, 2021 · 9f4c917 · 9f4c917
1 parent 6698815
commit 9f4c917
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/gap/SubfieldMatrixGroups.gi b/gap/SubfieldMatrixGroups.gi
@@ -285,17 +285,17 @@ function (d, p, e, f)
     local F, q0, b, gens, l, zeta, omega, zetaPower, C, gen;
 
     if IsOddInt(d) then
-    	ErrorNoReturn("Dimension <d> must be even.");
+    	ErrorNoReturn("<d> must be even.");
     fi;
 
     if e mod f <> 0 then
-        ErrorNoReturn("<f> must be a divisor of <e>");
+        ErrorNoReturn("<f> must be a divisor of <e>.");
     fi;
 
     b := QuoInt(e, f);
 
     if not IsPrime(b) then
-        ErrorNoReturn("The quotient of <f> by <e> must be a prime");
+        ErrorNoReturn("the quotient of <f> by <e> must be a prime.");
     fi;
 
     F := GF(p ^ e);

diff --git a/tst/standard/SubfieldMatrixGroups.tst b/tst/standard/SubfieldMatrixGroups.tst
@@ -87,3 +87,9 @@ gap> TestSubfieldSp := function(args)
 gap> testsSubfieldSp := [[6, 2, 2, 1], [4, 3, 2, 1], [4, 3, 4, 2], [4, 7, 2, 1]];;
 gap> ForAll(testsSubfieldSp, TestSubfieldSp);
 true
+gap> SubfieldSp(3, 2, 2, 1);
+Error, <d> must be even.
+gap> SubfieldSp(4, 2, 1, 2);
+Error, <f> must be a divisor of <e>.
+gap> SubfieldSp(4, 2, 4, 1);
+Error, the quotient of <f> by <e> must be a prime.