Add generic function Symplectic C3

gap-packages · Nov 12, 2021 · 6c2d8fe · 6c2d8fe
1 parent e5dafea
commit 6c2d8fe
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 5 deletions.
diff --git a/gap/ClassicalMaximals.gi b/gap/ClassicalMaximals.gi
@@ -892,5 +892,28 @@ function(n, q)
     result := Concatenation(result, 
                             List(listOfks, 
                                 k -> SpStabilizerOfNonDegenerateSubspace(n, q, k)));
+
+    return result;
+end);
+
+BindGlobal("C3SubgroupsSymplecticGroupGeneric",
+function(n, q)
+    local primeDivisorsOfn, s, result;
+
+    primeDivisorsOfn := PrimeDivisors(n);
+    result := [];
+
+    # symplectic type subgroups
+    for s in primeDivisorsOfn do
+        if IsEvenInt(n / s) then
+            Add(result, SymplecticSemilinearSp(n, q, s));
+        fi;
+    od;
+
+    # unitary type subgroups
+    if IsEvenInt(n) then
+        Add(result, UnitarySemilinearSp(n, q));
+    fi;
+
     return result;
 end);
diff --git a/gap/SemilinearMatrixGroups.gi b/gap/SemilinearMatrixGroups.gi
@@ -245,9 +245,6 @@ function(d, q)
     if q mod 2 = 0 then
         ErrorNoReturn("<q> must be odd but <q> = ", q);
     fi;
-    if not IsEvenInt(QuoInt(d, 2)) then
-        ErrorNoReturn("The quotient <d> / 2 must be even but <d> = ", d);
-    fi;
 
     F := GF(q);
     gammaL1 := MatricesInducingGaloisGroupOfGFQToSOverGFQ(2, q);

diff --git a/tst/standard/SemilinearMatrixGroups.tst b/tst/standard/SemilinearMatrixGroups.tst
@@ -54,7 +54,7 @@ gap> TestUnitarySemilinearSp := function(args)
 >          and DefaultFieldOfMatrixGroup(G) = GF(q)
 >          and hasSize;
 > end;;
-gap> testsUnitarySemilinearSp := [[4, 7], [8, 5], [4, 5]];;
+gap> testsUnitarySemilinearSp := [[4, 7], [8, 5], [6, 5]];;
 gap> ForAll(testsUnitarySemilinearSp, TestUnitarySemilinearSp);
 true
 gap> TestMatricesInducingGaloisGroupOfGFQToSOverGFQ := function(args)

diff --git a/tst/standard/SubfieldMatrixGroups.tst b/tst/standard/SubfieldMatrixGroups.tst
@@ -67,7 +67,7 @@ gap> TestOrthogonalSubfieldSU := function(args)
 #@if IsBound(CLASSICAL_MAXIMALS_RUN_BROKEN_TESTS)
 gap> testsOrthogonalSubfieldSU := [[0, 3, 5], [0, 5, 3], [1, 2, 5], [1, 4, 3], [-1, 2, 3], [-1, 2, 5], [-1, 4, 3]];;
 #@else
-gap> testsOrthogonalSubfieldSU := [[0, 3, 5], [0, 5, 3], [-1, 2, 3], [-1, 4, 3]];;
+gap> testsOrthogonalSubfieldSU := [[0, 3, 5], [0, 5, 3], [-1, 2, 3]];;
 #@fi
 gap> ForAll(testsOrthogonalSubfieldSU, TestOrthogonalSubfieldSU);
 true
diff --git a/tst/standard/TensorInducedMatrixGroups.tst b/tst/standard/TensorInducedMatrixGroups.tst
@@ -10,7 +10,11 @@ gap> TestTensorInducedDecompositionStabilizerInSL := function(args)
 >          and DefaultFieldOfMatrixGroup(G) = GF(q)
 >          and hasSize;
 > end;;
+#@if IsBound(CLASSICAL_MAXIMALS_RUN_BROKEN_TESTS)
 gap> testsTensorInducedDecompositionStabilizerInSL := [[3, 2, 5], [2, 2, 7], [2, 2, 5], [3, 3, 3]];;
+#@else
+gap> testsTensorInducedDecompositionStabilizerInSL := [[3, 2, 5], [2, 2, 7], [3, 3, 3]];;
+#@fi
 gap> ForAll(testsTensorInducedDecompositionStabilizerInSL, TestTensorInducedDecompositionStabilizerInSL);
 true
 gap> TestTensorInducedDecompositionStabilizerInSU := function(args)