Open
Conversation
Adds the ability to install updates on quit, instead of forcing the user to restart, when they may be in the middle of transferring files.
This sets autoInstallOnAppQuit to true, and adds a second button to the update prompt that does nothing.
Owner
|
I don't exactly recall why I had to force users to update. There was a particular reason; I will take a look at the PR and see if the update later will cause any side effects. Usually, I test the auto-updater feature multiple times before releasing, as even a small issue can screw up any future fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of forcing the app to restart immediately after downloading an update, this enables updating-on-quit by adding a second button to the update available popup.
Note that I was not able to test this very well, since I'm unable to package the app locally for some reason.
Fixes #386