py2filesystem file sources: always use context managers#21645
Open
bernt-matthias wants to merge 2 commits intogalaxyproject:devfrom
Open
py2filesystem file sources: always use context managers#21645bernt-matthias wants to merge 2 commits intogalaxyproject:devfrom
bernt-matthias wants to merge 2 commits intogalaxyproject:devfrom
Conversation
bernt-matthias
changed the title
davelopez
reviewed
Jan 27, 2026
davelopez
reviewed
Jan 27, 2026
bernt-matthias
force-pushed
the
py2fs-context-manager
branch
from
1572f46 to
943b4de
Compare
nsoranzo
reviewed
Jan 27, 2026
bernt-matthias
force-pushed
the
py2fs-context-manager
branch
from
943b4de to
9466114
Compare
as already done in `_list`. I guess _realize_to and _write_from will be called from jobs and celery jobs, i.e. the impact will be marginal, but its cleaner anyway.., Co-authored-by: David López <dlopez@informatik.uni-freiburg.de>
bernt-matthias
force-pushed
the
py2fs-context-manager
branch
from
9466114 to
a81365d
Compare
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as already done in
_list.I guess _realize_to and _write_from will be called from jobs and celery jobs, i.e. the impact will be marginal, but its cleaner anyway..,
How to test the changes?
(Select all options that apply)
License