Skip to content

refactor: convert string enums to const objects with type extraction #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luo2430 wants to merge 2 commits into
base: dev/2.0
Choose a base branch
from
+162 −137
Open

refactor: convert string enums to const objects with type extraction #3052

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc17d2b
refactor(core): replace enum with const object for EngineEventType
luo2430 Jun 25, 2026
8eb4a35
refactor: convert string enums to const objects with type extraction
luo2430 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/core/src/EngineEventType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
/**
* Engine event type.
*/
export enum EngineEventType {
export const EngineEventType = {
/** Dispatched when the engine starts running. */
Run = "run",
Run: "run",
/** Dispatched when the engine shuts down. */
Shutdown = "shutdown",
Shutdown: "shutdown",
/** Dispatched when the graphic device is lost. */
DeviceLost = "devicelost",
DeviceLost: "devicelost",
/** Dispatched when the graphic device is restored. */
DeviceRestored = "devicerestored"
}
DeviceRestored: "devicerestored"
} as const;

export type EngineEventType = (typeof EngineEventType)[keyof typeof EngineEventType];
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Loading