Add CC and ADA-M to Beacon spec

[sdelatorrep]

Implementation proposal of #22

[antbro]

Hi Sabela et al Francis (who is leading the ADA-M API and related matters) and I are very happy with this Cheers Tony From: Sabela [mailto:[email protected]] Sent: 22 September 2017 11:05 To: ga4gh/beacon-team <[email protected]> Cc: Subscribed <[email protected]> Subject: [ga4gh/beacon-team] Add CC and ADA-M to Beacon spec (#110) Implementation proposal of #22<#22>

…

________________________________ You can view, comment on, or merge this pull request online at: #110 Commit Summary * Add ConsentCodes and ADA-M. * Fix error. File Changes * M src/main/proto/ga4gh/beacon.proto<https://github.com/ga4gh/beacon-team/pull/110/files#diff-0> (28) Patch Links: * https://github.com/ga4gh/beacon-team/pull/110.patch * https://github.com/ga4gh/beacon-team/pull/110.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#110>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AI_EVOFVt-LOcg8usV0_VVByaQiQltHUks5sk4YygaJpZM4PgfpB>.

[jdylan]

Hi All,
Can we add support for DUO also ( http://www.obofoundry.org/ontology/duo.html ) - this is based on consent codes

[antbro]

Great! And I believe DUO was being extended to incorporate ADA-M elements as well. So we'd then have everything interconnected. Plus, the conjunction via DUO would give us a great place to work on unambiguously defining and harmonising term definitions regarding data use conditions Cheers Tony

…

________________________________________ From: jdylan <[email protected]> Sent: 03 October 2017 13:55 To: ga4gh/beacon-team Cc: Brookes, Anthony J. (Prof.); Comment Subject: Re: [ga4gh/beacon-team] Add CC and ADA-M to Beacon spec (#110) Hi All, Can we add support for DUO also ( http://www.obofoundry.org/ontology/duo.html ) - this is based on consent codes — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#110 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AI_EVIkznxIRoI-DBWMCA9ZMsxZlZisUks5soi6vgaJpZM4PgfpB>.

[sdelatorrep]

I suggest creating a new issue for including DUO and placing it in the next milestone. Do you agree?

[antbro]

yes Thanks, T

…

________________________________________ From: Sabela <[email protected]> Sent: 04 October 2017 11:03 To: ga4gh/beacon-team Cc: Brookes, Anthony J. (Prof.); Comment Subject: Re: [ga4gh/beacon-team] Add CC and ADA-M to Beacon spec (#110) I suggest creating a new issue for including DUO and placing it in the next milestone. Do you agree? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#110 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AI_EVIyXxfTBVt0AMpe1yTDcuyeCuBXTks5so1fzgaJpZM4PgfpB>.

[sdelatorrep]

Done. New issue #111

[susheel]

TravisCI check fails as it uses avro-schema-test Need to update to protobuf-test-base

[sdelatorrep]

Hi,
Could somebody merge this PR? I can't do it.
Thanks!

[mcupak]

CI is failing, the build should be fixed before merging.

[sdelatorrep]

But it's failing because it's using the avro-schema-test, isn't it? If so, I would disable this tests until the protobuf tests (#103) are finished and merged (although I'm not sure that working on that makes any sense if we're moving away from protobuf after v0.4).
BTW, if this is not the reason, I don't know how to fix it.