Use RTP demuxer, change notification API #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gBillal
reviewed
Jan 27, 2025
| |> via_out(Pad.ref(:output, ssrc), options: [depayloader: get_rtp_depayloader(track)]) | ||
| get_child(demuxer_name) | ||
| |> via_out(:output, options: [stream_id: {:payload_type, track.rtpmap.payload_type}]) | ||
| |> child({:jitter_buffer, make_ref()}, %Membrane.RTP.JitterBuffer{ |
There was a problem hiding this comment.
Don't you think we should have two separate pipelines for tcp and udp ? the jitter buffer will only introduce latency for tcp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces RTP.SessionBin with RTP.Demuxers, elements that take in a single RTP stream, demuxes and depayloads it into a single or multiple media streams. Due to that, when using UDP transport, each incoming stream will have it's own demuxer.
This allows us to simplify the notification API. Up until now the element sent
set_up_tracksandnew_tracknotifications. From now on the element would send onlyset_up_tracksnotification and the parent could connect all pads based on control paths provided in the notification instead of relying on ssrcs.For example, when the source finishes the
SETUPphase it sends theset_up_tracksnotification containing information about all tracks that have been set up. The parent can now connect a pad for each set up track upfront, withPad.ref(:output, <track_control_path>), instead of waiting for thenew_tracknotifications.closes membraneframework/membrane_core#935