Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Checking does not consider optional_options #37

Open
Oberacda opened this issue Dec 18, 2023 · 4 comments
Open

Duplicate Checking does not consider optional_options #37

Oberacda opened this issue Dec 18, 2023 · 4 comments
Assignees
@nspielbau
Labels
bug Something isn't working Core Library Issues concerning the core BT library. good first issue Good for newcomers High Priority
Milestone
ROSCon 2024

Comments

@Oberacda
Copy link
Contributor

The node_config is checked for duplicate parameters but does not explicitly consider the optional_options.
@Oberacda Oberacda added bug Something isn't working good first issue Good for newcomers Core Library Issues concerning the core BT library. High Priority labels Dec 18, 2023
@Oberacda Oberacda added this to the First ROS2 Release milestone Dec 18, 2023
@nspielbau nspielbau self-assigned this Mar 28, 2024
@nspielbau nspielbau mentioned this issue Apr 2, 2024
Merged
@nspielbau
Copy link
Contributor

This does mean an option + optional option of the same name in one node

@Oberacda
Copy link
Contributor Author

This does mean an option + optional option of the same name in one node

Yes

@nspielbau
Copy link
Contributor

It is unclear how/what a optional_option actually does right now -> Further discussion needed

@nspielbau
Copy link
Contributor

Optional Options do not really make sense. We should change this to align with #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nspielbau nspielbau

Labels
bug Something isn't working Core Library Issues concerning the core BT library. good first issue Good for newcomers High Priority
Projects
None yet
Milestone
ROSCon 2024
Development

No branches or pull requests
2 participants
@Oberacda @nspielbau