Finish localising the DateEntry and Calendar

[andydotxyz]

Fixes #5141

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

[coveralls]

coverage: 62.292% (+0.002%) from 62.29%
when pulling 617a3a8 on fix/5141
into 6b733a7 on develop.

[andydotxyz]

Thanks for adding the Sunday starts - but I don't think they all use US date format ...

[dweymouth]

Thanks for adding the Sunday starts - but I don't think they all use US date format ...

I have them using the day/month/year format?

[andydotxyz]

So you do - I can't read sorry.

[Jacalz]

This seems like a very memory inefficient data structure with quite a lot of duplicated data. Is there any way we can make this more efficient as languages grow?

One idea I have is to just use trucks and avoid the map inside map. It might also make sense to have the starting day as an index (maya be as an enum) and not a string to avoid duplicating that data a lot.

[andydotxyz]

This was included to be a replacement for the lan file lookups until a better solution was decided upon - you can see the suggestion from @dweymouth.

Yes there are many more efficient ways to pack this data in, but they would not work if we ever make this more configurable again through something like weblate. Optimising for storage in code seems premature with that in mind. Similarly using "0" to represent Sunday (or Monday) makes it hard to read if we move to such a file later.

[Jacalz]

If you wish to add Swedish to the list then it is Monday and time.DateOnly that is correct.

[andydotxyz]

If you wish to add Swedish to the list then it is Monday and time.DateOnly that is correct.

Thanks for this - but given that Swedish is the language do you mean Sweden? (i.e. (SE)?

This seems like a very memory inefficient data structure with quite a lot of duplicated data.

I have significantly reduced the memory requirement, hopefully this makes it good for now?