Add new canvas.RecolorSVG API #5345
Conversation
dweymouth
changed the title
|
CI Failures appear to be unrelated flakiness |
internal/svg/svg.go
Outdated
| } | ||
|
|
||
| // ColorizeError is the same as Colorize, except returning instead of logging any error. | ||
| func ColorizeError(src []byte, clr color.Color) ([]byte, error) { |
There was a problem hiding this comment.
Sorry for the pickiness but I'm not sure about the function name here. ColorizeError sounds as if it is changing the colour of an error and not an svg?
There was a problem hiding this comment.
Do you have a better name in mind? ColorizeReturnError?
There was a problem hiding this comment.
Not really, no. I think having in the name that something returns an error will be strange. Also the idea of having a version that returns errors and one that doesn't is strange in most cases. I think there are two options:
- Depending on how many call sites there are, it might make sense to only use the version that returns errors and either look at it or ignore it completely.
- The standard library seems to follow the convention that a function always returns an error and in the case where there is a version of it that doesn't, it is called MustXYZ (although the latter usually panics on errors).
It is a bit of a strange pattern in general come to think of it. Any ideas?
There was a problem hiding this comment.
I would agree with 1 - there is little point in exposing the non-error as a public helper API if errors can be generated.
Description:
Fixes #4815
Checklist:
Where applicable: