Fix cargo update
error when compiling ws
#412
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like @isabelrios discovered this morning,
cargo update
breaks today's build.After an investigation with @ferjm, we found out that
url
is now compiled in 3 different versions: 0.2.38, 0.5.9 and 1.0.0. The first 2 versions have been here so far, so the culprit is 1.0.0.ws
is not meant to be built against a version > 0.5. But it turns out only a few commits pinpoint version. d154fc5 (the revision we picked) was one of them.r? @isabelrios
Edit: The build failed on Travis because it requires #411 to land first.