Skip to content

Fix cargo update error when compiling ws #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix cargo update error when compiling ws #412

wants to merge 1 commit into from

Conversation

JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented Apr 22, 2016

Like @isabelrios discovered this morning, cargo update breaks today's build.

/home/jlorenzo/.multirust/toolchains/nightly-2016-04-10/cargo/git/checkouts/ws-rs-012dd83a96dba3eb/d154fc5/src/handshake.rs:339:21: 339:35 error: no method named `serialize_path` found for type `&url::Url` in the current scope
/home/jlorenzo/.multirust/toolchains/nightly-2016-04-10/cargo/git/checkouts/ws-rs-012dd83a96dba3eb/d154fc5/src/handshake.rs:339                 url.serialize_path().unwrap_or("/".to_owned()),

After an investigation with @ferjm, we found out that url is now compiled in 3 different versions: 0.2.38, 0.5.9 and 1.0.0. The first 2 versions have been here so far, so the culprit is 1.0.0.

ws is not meant to be built against a version > 0.5. But it turns out only a few commits pinpoint version. d154fc5 (the revision we picked) was one of them.

r? @isabelrios

Edit: The build failed on Travis because it requires #411 to land first.

@JohanLorenzo
Copy link
Contributor Author

Actually done in #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant