Infix code completion#521
Conversation
b1f6efb to
67cb16c
Compare
|
Neat, thanks a lot for looking into this! Bit short on time, so I won't review it in detail right now, but it looks pretty good from a first glance (thanks for adding tests too). |
themkat
left a comment
themkat
left a comment
There was a problem hiding this comment.
Tested it manually as well, and works great 🙂 Good job! 🎉
The only little case that is not working is when completing nothing (i.e, 1 instead of 1 a, where the last gives us and as an alternative). The server is not generally good at handling these cases, so think we might need bigger rewrites to make it work. Maybe we should consider it future work and make an issue for it? I have been missing global completion with EVERYTHING when completing nothing, but unsure if it is just me or not...
Added global completions @themkat let me know how it looks. Detekt isn't agreeing with these changes so will need to look into that. |
Sorry for the late reply, will try to have a closer look tomorrow 🙂 Been busy with some other things... 🙁 Looking at the detekt violations, it seems to me that those are because of the existing implementation more than what you have done. I would say that you use |
elamco
changed the title
themkat
left a comment
themkat
left a comment
There was a problem hiding this comment.
Can't see any obvious faults! Good job! Completing infix functions works amazing, especially globally! Thank you for amazing work! ❤️ Very happy to see that your changes are verified by both your own and existing tests.
Sorry if I'm a downer with this last sentence... but.. I'm going to give @fwcd a day or two to have a look before merging. Like to give him a chance to have a look before merging, especially since he have his own set of opinions on code style etc. 🙂 (FWs repo after all)
|
It's been 2 days, so merging now. Thank you @ElamC 😄 |
3 participants
Closes #446
Adds missing completions for infix functions.