Use AX_COMPARE_VERSION macro for golang version checks #987
Conversation
Kangie
force-pushed
the
mj/future-proof-golang-detection
branch
from
1e34faf to
4888a81
Compare
|
Thanks -- I was hoping there would be an easier way. But you've got syntax issues with this change. CI isn't passing. Please fix. |
|
Ah. We can either ship m4/ax-compare-version.m4 or add autoconf-archive to the fvwm3-build container. Edit: @ThomasAdam I think updating the build container and adding autoconf-archive to the installed packages is the neater solution, but do you have a preference? |
Kangie
force-pushed
the
mj/future-proof-golang-detection
branch
3 times, most recently
from
af022a1 to
e260a6d
Compare
|
Thanks. But, please only make the necessary changes required to introduce |
|
Sure, I was hacking away anyway - Some of these changes should simplify your meson port though by removing unnecessary checks. Do you have a preference around updating the build image or shipping the m4 macro in-repo? |
Add it to |
Kangie
force-pushed
the
mj/future-proof-golang-detection
branch
from
e260a6d to
9be90a9
Compare
|
Dropped the offending commits. Please be aware of https://bugs.gentoo.org/919163 (AC_FUNC_SELECT is broken) Is it worth hacking away at the meson build path instead? |
Kangie
force-pushed
the
mj/future-proof-golang-detection
branch
from
9be90a9 to
0bdb24e
Compare
There was a problem hiding this comment.
Hi @Kangie
Thanks -- one slight change, please. I've left an inline comment.
The previous approach was fragile, required manual updates, and results in unexpected outcomes when the user has updated golang. Reported-by: Denny Rivetti <[email protected]>
Kangie
force-pushed
the
mj/future-proof-golang-detection
branch
from
0bdb24e to
aa58f83
Compare
|
That should take care of it. I still think that the autotools tidyup I did will make maintaining the code and build system easier going forward, regardless of the system used (i.e. less complexity for meson). Would you consider a separate PR? |
|
Hi @Kangie Thanks. Will merge this. I'm aware of some of the configure problems, and have some patches myself to address a few of them. For example, the select problem. I'd much rather effort was put into the meson build... |
The previous approach fragile, required manual updates, and results in unexpected outcomes when the user has updated golang.
We stop manually whitelisting golang versions in favour of checking against a minimum version.
I know that meson is coming (yay!), but this keeps biting us in Gentoo. :)