Remove single screen support, -s. #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
force-pushed
the
js/remove-dash-s
branch
3 times, most recently
from
136adc8 to
f0ef481
Compare
ThomasAdam
added
the
type:breaking
Fvwm no longer needs to run separate instances on each screen to manage screens independently. With RandR support and DesktopConfiguration per-monitor, each screen can be managed independently, with the advantage that all windows are managed by a single instance of fvwm, so windows can be moved between screens to. This removes single screen support from fvwm.
There should be no reason this function should ever return false, now that fvwm will always occupy all screens. Remove the extra logic checking around this function and make it a void function.
ThomasAdam
force-pushed
the
js/remove-dash-s
branch
from
f0ef481 to
e421d6c
Compare
cmeerw
added a commit
to cmeerw/fvwm3
that referenced
this pull request
Jul 10, 2024
…ality, as session.c still appends "-s screen_num" to the restart command args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fvwm no longer needs to run separate instances on each screen to manage screens independently. With RandR support and
DesktopConfiguration per-monitor, each screen can be managed independently, with the advantage that all windows are managed by a single instance of fvwm, so windows can be moved between screens and controlled by a single instance. This removes the old single screen support from fvwm.Note, users of the old
-soption should switch toDesktopConfiguration per-monitorand run a single instance of fvwm. If there are features thatper-monitoris missing, report issues so they are known and can be addressed. In generalper-monitorshould provide the same functionality and more than running separate instances on each Xinemera screen.